Commit Graph

39 Commits

Author SHA1 Message Date
GitLab Bot 133924c6cc Add latest changes from gitlab-org/gitlab@master 2019-10-11 00:06:24 +00:00
GitLab Bot 2abb1b54c0 Add latest changes from gitlab-org/gitlab@master 2019-09-27 18:06:20 +00:00
Igor Drozdov 72544449cf Change the way totalNotes is calculated
totalNotes is only used to prerender a number of
skeleton containers until real notes are loaded

issuable.discussions makes multiple requests, so
too expensive for this

This commit uses mere notes for this and sends
actual totalNotes number if it's less than 10;
otherwise it sends 10 - it allows us to avoid
bunch of skeleton prerenderings, which are not
necessary since they doesn't fit into the whole
screen and disappear quite fast
2019-08-28 08:30:13 +03:00
Ezekiel Kigbo 0c028a816b Vue-i18n: app/assets/javascripts/notes directory
i18n linting for .vue files under the
app/assets/javascripts/notes directory
2019-07-04 10:20:38 +00:00
Winnie Hellmann aea013eab9 Move NoteApp tests to Jest 2019-06-03 14:36:34 +00:00
Paul Gascou-Vaillancourt 911701ae47 Extract discussion notes into new component
- Moved discussion notes out of `NoteableDiscussion` component into a
new `DiscussionNotes` component
- Wrote Jest tests for the new `DiscussionNotes` component
- Updated Jest config for emojis fixtures
- Updated Karma tests `NoteableDiscussion` to match its new structure
- Convert `DiffDiscussions` tests to use Vue test utils
2019-05-01 10:04:07 +00:00
Kushal Pandya 2dd22ecb46 Add support for toggling discussion filter from notes section
Adds discussion note style section under notes app from where
user can toggle discussion when they have selected a filter to show
only system notes.
2019-02-26 14:04:15 +00:00
Phil Hughes 810a8b78b6
CE backport of design-management-issue-tab
Backports template and Vue changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9632 to CE
2019-02-20 14:51:06 +00:00
Winnie Hellmann 8441fc4799 Remove noteId prop from ReplyButton component
Move convertToDiscussion call from ReplyButton to NoteApp component
2019-02-18 09:43:13 +00:00
Heinrich Lee Yu f60734d3cb Fix polling for replies to individual notes
Sets `updated_at` so that the transformed note is returned together with
the new reply
2019-02-14 10:07:13 +00:00
Heinrich Lee Yu a04d9ba90c Add reply to notes to turn into discussions 2019-02-06 10:31:46 +00:00
Jan Provaznik b2c70230b3 Remove Redcarpet markdown engine
This engine was replaced with CommonMarker in 11.4, it was deprecated
since then.
2019-02-04 12:48:35 +01:00
Oswaldo Ferreira ed3034bbb7 Allow suggesting single line changes in diffs 2018-12-13 19:17:19 +00:00
Phil Hughes 4e65fe2f1e
Fixed emoji awards not being added to notes
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55141
2018-12-11 09:14:59 +00:00
Tim Zallmann ddd4cc649f Resolve "Extended user centric tooltips" 2018-12-08 03:12:23 +00:00
Phil Hughes adf8ad9eee
Improve discussion rendering performance
Improve the renderign of new and existing discussions
by reducing the number of watchers on each object & array.
Previously every discussion change would trigger an update for every
discussion component.

Also tidied up some components to get them closer to our docs.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51506
2018-11-27 11:40:39 +00:00
Mike Greiling 5b9495c5db
Prettify all the things 2018-11-20 09:30:01 -06:00
Phil Hughes cfedc31b7a
Improve initial rendering of discussion notes
This improves the initial rendering performance of notes
by only creating a new TaskList for the whole app,
rather than on a per-note component basis.
2018-11-09 09:55:37 +00:00
Phil Hughes 1519c3470c
Stop multiple discussion requests
With multiple discussion requests we loose the reactivity of the
previously stored discussions state.
This means that certain features, toggling line discussions for example,
are no longer reactive.
2018-11-08 10:42:11 +00:00
Felipe Artur b4d005eb7b Add 'only history' option to notes filter 2018-11-05 12:30:14 +00:00
Mike Greiling 160157a92b
Prettify remaining files with differences in CE and EE 2018-10-31 14:33:12 -05:00
Oswaldo Ferreira 86ead874e2 Resolve "Filter discussion (tab) by comments or activity in issues and merge requests" 2018-10-23 09:49:45 +00:00
Winnie Hellmann 23563f5e0a Highlight current user in comments and system notes 2018-10-02 11:12:22 +02:00
Mike Greiling f829b181bc
Resolve eslint-plugin-vue errors
The eslint-plugin-vue upgrade had some breaking changes to
vue/attribute-order which needed to be resolved in order to avoid
disabling the rule entirely
2018-09-20 02:39:50 -05:00
Clement Ho f815b48f39 Use gitlab-ui loading icon 2018-09-11 22:19:21 +00:00
Tim Zallmann c9bacfd682 Fixed Resolving, Loading more and Line Bugs 2018-09-07 12:25:50 +02:00
Brett Walker 750af9fd32 Use proper markdown rendering for previews 2018-07-06 18:49:33 +00:00
Tim Zallmann fb44cb3d90 Performance Improvements to Vue MR page 2018-06-30 13:17:46 +00:00
Fatih Acet d690cd9992 Prevent fetching diffs and discussions data unnecessarily on MR page 2018-06-29 07:22:07 +00:00
gfyoung 23cdae8eee Enable "prefer-destructuring" in JS files
Partially addresses #47006.
2018-06-25 11:53:57 -07:00
Felipe Artur 3e66795ef1 Changes tab VUE refactoring 2018-06-21 12:22:40 +00:00
Kushal Pandya 223eeae1a7 Return noteableType from app initial config 2018-04-06 14:26:39 +05:30
Jan Provaznik 65664c2eae Refactor discussions/notes code 2018-04-03 16:03:00 +00:00
Fatih Acet fdc9ae2edf
Prettify notes. 2018-03-16 23:16:21 +03:00
Mike Greiling f248be7257
require jQuery to be explicitly imported 2018-03-09 15:18:09 -06:00
Fatih Acet 059ab73b8e Render MR Notes with Vue with behind a cookie 2018-02-28 00:10:43 +00:00
Filipa Lacerda cdc4938834
[ci skip] Fix more rules 2018-01-05 00:45:32 +00:00
Fatih Acet 8d739237de Merge branch 'issue-note-rename' into 'master'
rename remaining issue_ prefixed files

See merge request gitlab-org/gitlab-ce!15818
2017-12-11 21:56:50 +00:00
Simon Knox 874deb4142 rename remaining issue_ prefixed files 2017-12-09 07:24:52 +11:00