Commit Graph

48 Commits

Author SHA1 Message Date
Mike Greiling 8e0e902b13 resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
Mike Greiling 23f5865e18 expand remaining non-explicit eslint-disable blocks and factor out globals when no-undef encountered 2016-12-13 21:07:31 -06:00
Phil Hughes a085e3fb97 Fixed resolved discussion timeago not rendering
Closes #24787
2016-11-22 11:47:26 +00:00
Phil Hughes 948b4828ce Issue board spec fixes 2016-11-10 17:53:34 +03:00
Phil Hughes a9349f5734 Fixed jump to discussion button not showing 2016-11-10 17:53:34 +03:00
Phil Hughes c8133c53b2 Changed how resolving notes is rendered
Vue2 was taking the template out & then appending again. This changes that
2016-11-10 17:53:34 +03:00
Phil Hughes 4fba69dc90 Fixed up resolve discussions 2016-11-10 17:53:34 +03:00
Fatih Acet 99b421da2c Migrate Vue v1 to v2. 2016-11-10 17:53:34 +03:00
winniehell 02f94cf038 disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
Phil Hughes 5461a5d10a Pass the full project path for resolve buttons
This fixes an issue that would stop the resolve buttons working when GitLab is installed with a relative URL

Closes #21704
2016-09-21 10:07:24 +01:00
Douwe Maan ac89bb0fad Fix jumping between discussions on changes tab 2016-08-18 18:14:47 -05:00
Douwe Maan 409bc05428 Fix bug causing “Jump to discussion” button not to show 2016-08-18 16:56:13 -05:00
Connor Shea 36fd507b4b
Function should return a boolean. 2016-08-17 12:42:16 -06:00
Connor Shea 26c49cc156
Forgot another one. 2016-08-17 12:30:59 -06:00
Connor Shea c648756a36
Fix more incomplete if/else statements. 2016-08-17 12:18:53 -06:00
Connor Shea f3acf9fd24
Remove non-standard VueJS files from vendor. 2016-08-17 10:01:26 -06:00
Connor Shea c8df2c5f06
Add return statements for if statements that were missing them. 2016-08-17 08:38:23 -06:00
Connor Shea 32e31d626f
Resolve feedback. 2016-08-15 11:25:28 -06:00
Douwe Maan 33edde50ab Don’t show “Resolve discussion” for non-author/members 2016-08-12 15:10:05 -05:00
Connor Shea 6073b281aa
Fix a bug and a test. 2016-08-10 09:13:55 -06:00
Connor Shea d7d69b2839
If the next discussion is closed, toggle it open. 2016-08-09 11:53:29 -06:00
Douwe Maan ffbba55bc8 Implement Jump behavior for Changes tab 2016-08-04 18:01:32 -07:00
Phil Hughes 69c7fc5f72 Jumps between discussions on the changes tab
Ordered the jump to discussion by order in the DOM
2016-08-04 11:02:04 +01:00
Phil Hughes 433f1c42c3 Comment & resolve button no longer looks for can-resolve attribute
Fixed some bugs when removing notes
2016-08-04 09:52:17 +01:00
Phil Hughes ee62a2fd5a Moved update headline HTML into discussion model 2016-08-01 11:31:35 +01:00
Phil Hughes d6e724d90f Moved method to compile components from window into diffnotesapp 2016-08-01 10:21:57 +01:00
Phil Hughes f65d8eb326 Updated method name to be more descriptive 2016-08-01 10:15:15 +01:00
Phil Hughes 9accca43c3 Unminified versions of vue & vue-resource 2016-08-01 10:09:30 +01:00
Phil Hughes c51cbc1f2f Updated issues with jump tp button
Fixed styling bugs
2016-08-01 10:06:31 +01:00
Phil Hughes 822624b717 File rename 2016-07-29 18:25:54 +01:00
Phil Hughes 03ea267f67 Added tests for hidden jump to button 2016-07-29 15:50:58 +01:00
Phil Hughes d147894b84 Hides jump to next button if only one discussion visible 2016-07-29 15:22:26 +01:00
Phil Hughes 9878356dbc Added JS spec tests for CommentsStore
Updated other tests
2016-07-29 15:03:58 +01:00
Phil Hughes 6f94f62f72 Correctly cycles the unresolved discussions
Switches back to discussion tab when clicking jump to next unresolved button
2016-07-29 13:31:32 +01:00
Phil Hughes 4e679819f2 Fixed failing tests 2016-07-29 11:52:08 +01:00
Phil Hughes efb74875cf Moved most of the data handling into discussion & notes models
Reduced some duplicated code with compiling components
Fixed bug with resolve button tooltip not updating after resolving discussion
2016-07-29 11:19:56 +01:00
Douwe Maan 27471d01c2 Don’t depend on unique class. 2016-07-28 20:09:50 -06:00
Phil Hughes 8b1a2e4d0b Moved the parentheses outside to make Babel happy 2016-07-28 15:07:47 +01:00
Phil Hughes 2247d8a4fd Updates the text above discussions when resolving notes & discussions 2016-07-27 18:34:04 +01:00
Phil Hughes 86446846e9 Added tests for resolving comments feature 2016-07-27 16:57:48 +01:00
Phil Hughes 5a0cd0e947 Added jump tp next discussion button 2016-07-27 09:27:00 +01:00
Phil Hughes 5ec7a40bcb Added jump to next discussion button 2016-07-26 18:28:11 +01:00
Phil Hughes f4746d01ff Variables renames 2016-07-26 17:49:49 +01:00
Phil Hughes e786c2b21c Comment & resolve button text is done through VueJS 2016-07-26 17:45:48 +01:00
Phil Hughes 14710f7704 Shows tooltip for resolved even if user cant resolve comments 2016-07-26 15:57:14 +01:00
Phil Hughes a678fef836 Added resolved by users name into tooltip 2016-07-26 15:47:19 +01:00
Phil Hughes 5e8606562d Added ability to toggle resolving by commenting 2016-07-26 14:30:57 +01:00
Phil Hughes 6537a4a8fe Correctly resolves/unresolves discussions 2016-07-26 13:44:51 +01:00