Commit Graph

111 Commits

Author SHA1 Message Date
Yorick Peterse a54af831ba
Use rake db:reset instead of db:setup
Using db:reset ensures existing tables are first dropped. This in turn
ensures that we can drop tables regardless of any foreign key
constraints. While CE currently doesn't have any foreign keys EE defines
the following relation:

    remote_mirrors.project_id -> projects.id

MySQL will complain whenever you try to drop the "projects" table first
even when using "DROP TABLE ... CASCADE".
2016-04-14 15:53:54 +02:00
Yorick Peterse 15cbbd09fb Merge branch 'metrics-measure-block-transaction' into 'master'
Store block timings as transaction values

See merge request !3649
2016-04-11 13:16:58 +00:00
Yorick Peterse d9110a7eca
Track call counts in Gitlab::Metrics.measure_block 2016-04-11 13:27:52 +02:00
Yorick Peterse 16926a676b
Store block timings as transaction values
This makes it easier to query, simplifies the code, and makes it
possible to figure out what transaction the data belongs to (simply
because it's now stored _in_ the transaction).

This new setup keeps track of both the real/wall time _and_ CPU time
spent in a block, both measured using milliseconds (to keep all units
the same).
2016-04-11 13:09:36 +02:00
Robert Speicher 0c6923e2d1 Re-add a note about sarcasm to the Code Review guide
[ci skip]
2016-04-10 22:54:44 -04:00
Robert Speicher c7ec5929b1 First pass at a Code Review guide
Largely borrowed from thoughtbot's code review guide, so attribution is
included.

[ci skip]
2016-04-09 21:49:47 -04:00
Robert Speicher cedcc1453c Minor Testing guide copyedits
[ci skip]
2016-04-09 01:19:21 -04:00
Dmitriy Zaporozhets 4a1fdc78a4 Merge branch 'remove-todo' into 'master'
Remove TODO for not documented stuff

We should not put a `TODO` in a released product.

See merge request !3553
2016-04-08 17:42:53 +00:00
Dmitriy Zaporozhets 0396c8525c Merge branch 'rs-testing-guide' into 'master'
First pass at a Testing styleguide

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14121

[ci skip]

See merge request !3465
2016-04-08 17:34:55 +00:00
Yorick Peterse 352bc7d2b9 Added dev guide for measuring Ruby blocks 2016-04-06 14:32:27 +02:00
Robert Schilling 3911e77eb4 Remove TODO for not documented stuff 2016-04-05 23:08:22 +02:00
Robert Speicher 6ffda88c97 Add a link back to Development documentation to Testing guide
[ci skip]
2016-04-01 20:36:59 -04:00
Robert Speicher 2e83b56203 Add a section about `let` to the Testing guide
[ci skip]
2016-04-01 20:31:16 -04:00
Robert Speicher 60f4081e13 Factories don't have to be limited to `ActiveRecord` objects
[ci skip]
2016-04-01 20:31:12 -04:00
Robert Speicher 0b9d9816f8 Add a note about Four-Phase Test to Testing guide
[ci skip]
2016-04-01 20:31:12 -04:00
Robert Speicher fb8b0041d8 First pass at a Testing styleguide
[ci skip]
2016-04-01 20:31:12 -04:00
connorshea 2c9f6cfa42 SCSS Style Guide fixes.
Fix a typo and add a section on ignoring issues.

[ci skip]
2016-03-23 14:39:12 -06:00
connorshea 8d8b457ceb Add SCSS Lint, CSSComb config file, run SCSS Lint in GitLab CI, add documentation for SCSS Style Guide.
See !3069 for more information.
2016-03-14 20:33:54 -06:00
Yorick Peterse d69dff5b4b Removed benchmark suite and its documentation
The rationale for this can be found in
https://gitlab.com/gitlab-org/gitlab-ce/issues/13718 but in short the
benchmark suite no longer serves a good purpose now that we have proper
production monitoring in place.

Fixes gitlab-org/gitlab-ce#13718
2016-03-10 11:15:43 +01:00
Yorick Peterse 059df2256e Added basic SQL guidelines
[ci skip]
2016-03-08 11:28:50 +01:00
Achilleas Pipinellis bfeab78ab5 Change doc styleguide to use quotes for notes
[ci skip]
2016-02-29 15:00:40 +02:00
Douwe Maan 17251cf447 Merge branch 'rs-development-docs' into 'master'
Add "Gotchas" to development docs

Also:

- Alphabetizes the "Developer" index page
- Fixes the broken `db_dump.md` link

See merge request !2846
2016-02-29 11:00:33 +00:00
Achilleas Pipinellis 83ba37e544 Merge branch 'fix_git_tag_in_architecture' into 'master'
Fixed ~git beeing displayed as link to issues tagged with git in architecture.md

The architecture documentation explains `~git` from the picture below which is replaced by a [link to issues tagged with `git`](https://gitlab.com/gitlab-org/gitlab-ce/issues?label_name=git). I believe that this was unintended and should be fixed by using backticks.

![Screenshot_from_2016-02-13_21-36-30](/uploads/5ea1a60e8b230952874e58eab0abe1ac/Screenshot_from_2016-02-13_21-36-30.png)

See merge request !2814
2016-02-24 20:16:50 +00:00
James Lopez af0ba6605b revert back to ruby 2.1 - use 2.1.8 2016-02-19 17:19:57 +01:00
James Lopez 83829c0902 revert back to ruby 2.1 2016-02-19 15:59:46 +01:00
Robert Speicher 0afe2e0513 Update Gotchas doc
[ci skip]
2016-02-17 15:35:28 -05:00
Rémy Coutable a4ffdf922d Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce 2016-02-17 17:33:09 +01:00
Robert Speicher 6053ad8474 Add "Gotchas" development doc 2016-02-16 22:09:00 -05:00
Robert Speicher e82b17fa43 Fix the "How to dump production data" link
[ci skip]
2016-02-16 21:31:42 -05:00
Robert Speicher 4a9d174b91 Alphabetize Development doc index
[ci skip]
2016-02-16 21:31:40 -05:00
Douwe Maan c29517aaf4 Merge branch 'offline-migration-docs' into 'master'
Add notice about offline migrations

/cc @sytses 

See merge request !1723
2016-02-15 11:43:50 +00:00
Finn Glöe 81ab172a25 Fixed ~git beeing displayed as link to issues tagged with git
[ci skip]
2016-02-13 23:59:38 +01:00
Prayag Verma b877afc371 Fix a typo [ci skip]
Remove extra `make`
2016-02-12 19:02:35 +05:30
Achilleas Pipinellis a95c6e38c6 Add ruby version update info in doc_styleguide
[ci skip]
2016-02-05 17:26:40 +02:00
James Lopez 3d81f1da6e Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into update-ruby-2.2.4
# Conflicts:
#	.gitlab-ci.yml
2016-01-22 18:01:38 +01:00
James Lopez 1c51fb1778 update Ruby version to 2.2.4 (latest previous stable) and update docs 2016-01-21 16:12:49 +01:00
Achilleas Pipinellis 086cbca6bf Link to restart_gitlab.md and some more fixes
[ci skip]
2016-01-20 10:44:26 +01:00
Achilleas Pipinellis 9d756f3d8b Add document on restarting GitLab
[ci skip]
2016-01-20 10:33:59 +01:00
Achilleas Pipinellis 4eae95c03c Update doc_styleguide.md [ci skip]
- Fix some syntax/grammar typos
- Link to GFM documentation on newlines
- Be less strict on the alphabetical order styleguide
- You can override the "numbers in headings" rule if you discuss it first
- Do not mention CE in notes if the feature is in both CE and EE
2016-01-13 18:24:08 +01:00
Achilleas Pipinellis 20c327fcfd Clarify the naming guideline
[ci skip]
2016-01-12 16:19:11 +01:00
Achilleas Pipinellis d0b2d278f4 Move doc_styleguide in the development directory
[ci skip]
2016-01-12 11:57:42 +01:00
Anton Davydov d6e0a1883b Fix typos in all docs [skip ci] 2015-11-24 02:19:17 +03:00
Alex Jordan 3300db70ff Rewrite HTTP links to force TLS, where possible 2015-11-16 16:50:05 -08:00
Yorick Peterse 126a2428cd Updated profiling guides for Sherlock 2015-11-09 14:29:10 +01:00
Robert Speicher 312375ac7c Update Shell Commands doc for configurable git binary path 2015-11-03 17:10:17 -05:00
Kamil Trzciński 35b93f9d22 Add notice about offline migrations 2015-11-02 15:14:34 +00:00
Robert Schilling 98008a2db8 Fix typo in rake task doc 2015-10-31 22:56:24 +01:00
Jacob Vosmaer 5ff830cf32 Clarify puppies 2015-10-26 14:28:31 +01:00
Jacob Vosmaer 0b082b348b Start putting shared files in "shared" 2015-10-26 13:42:09 +01:00
Yorick Peterse 97e02f4bc9 Added documentation on the various profiling tools 2015-10-15 12:15:18 +02:00