133924c6cc
Add latest changes from gitlab-org/gitlab@master
2019-10-11 00:06:24 +00:00
4e9f718e19
Add latest changes from gitlab-org/gitlab@master
2019-09-26 15:06:18 +00:00
80f61b4035
Add latest changes from gitlab-org/gitlab@master
2019-09-18 14:02:45 +00:00
a93dfc1b7e
Add latest changes from gitlab-org/gitlab@master
2019-09-14 00:06:25 +00:00
589c8d5625
Hide resolve thread button from guest
...
- Show if user can_resolve all of the notes
2019-09-12 07:41:19 +00:00
72544449cf
Change the way totalNotes is calculated
...
totalNotes is only used to prerender a number of
skeleton containers until real notes are loaded
issuable.discussions makes multiple requests, so
too expensive for this
This commit uses mere notes for this and sends
actual totalNotes number if it's less than 10;
otherwise it sends 10 - it allows us to avoid
bunch of skeleton prerenderings, which are not
necessary since they doesn't fit into the whole
screen and disappear quite fast
2019-08-28 08:30:13 +03:00
a13abd6731
Add edit_note and spec for editing quick actions
...
Call QuickActionsService on Note update
Add support for notes which just contain
commands after editing
Return http status gone (410) if note was deleted
Temporary frontend addition so it is not
failing when a note is deleted
Move specs to shared examples
Fix rubocop style issue
Deleting note on frontend when status is 410
Use guard clause for note which got deleted
Simplified condition for nil note
This method should no longer be called
with nil note
Refactoring of execute method to reduce
complexity
Move errors update to delete_note method
Note is now deleted visually when it only
contains commands after update
Add expectation
Fix style issues
Changing action to fix tests
Add tests for removeNote and update
deleteNote expectations
2019-08-26 09:20:00 +00:00
b179b752e8
Refactor nextUnresolvedDiscussionId and previousUnresolvedDiscussionId getters
2019-08-15 14:07:20 -05:00
eba4422803
Add kbd shortcuts for discussion navigation
...
Add keyboard shortcuts `p` and `n` to navigate duscussions.
2019-08-12 06:41:04 +00:00
b689ddd9b6
Do not persist notes filter when auto-switching
...
Send a `persist_filter: false` param to backend when
opening links to notes and auto-switching to show
all notes
2019-08-07 15:45:23 +00:00
d90865a960
Backport from EE
2019-08-01 16:00:36 -05:00
6911c3435a
Resolve "Tooltips on note timestamps not showing for issues"
2019-07-18 13:16:18 +00:00
49d5cc34ca
Remove deleteNote from notes service
2019-07-10 16:48:15 +00:00
b9e52612fe
Updates on success of an MR the count on top and in other tabs
...
New API endpoint for merge request count
Updates all open tabs at the same time with one call
Restructured API response
API response changed to 401 if no current_user
Added API + JS specs
Fix for Static Check
Updated Count on Open/Close, Assign/Unassign of MR's
Checking if MR Count is refreshed
Added # frozen_string_literal: true to spec
Added Changelog
2019-07-09 08:44:19 +00:00
23bd46cf01
Remove applySuggestion from notes service
2019-07-05 22:59:30 +00:00
b94daa35a4
Merge branch 'master' into michel.engelen/gitlab-ce-issue/55953
2019-07-03 10:28:13 +01:00
d4151b14c2
Rebased and squashed commits
...
- all commits squashed to make danger review happy
2019-07-03 08:26:57 +00:00
c2429ed553
Fix typo in updateResolvableDiscussionsCounts action
2019-07-02 23:11:13 +00:00
f41ab869ee
prettified noteable_discussion spec file
2019-07-02 14:29:54 +02:00
385ef2abf7
prettified js testfile for noteable_discussion component
2019-07-02 14:29:54 +02:00
e671ab06ce
updated karma test for noteable_discussion component
2019-07-02 14:29:54 +02:00
2ded70292e
prettified noteable_discussion component and updated tests
2019-07-02 14:29:54 +02:00
4bf0434359
Rearrange discussion resolve buttons & update button display
...
- next-discuss button is always show unless there is only 1 discussion
- regroup buttons arrangements
2019-06-28 07:32:03 +00:00
08359a8ebc
Add back trimChar method to remove trailing +/-
...
Add test for checking output
2019-06-21 10:10:05 +00:00
982463e944
Change "Report abuse to GitLab" to more generic wording.
2019-06-06 10:05:42 +00:00
aea013eab9
Move NoteApp tests to Jest
2019-06-03 14:36:34 +00:00
7099211ea7
Fix emoji picker visibility issue
2019-05-31 14:45:37 +02:00
ede97703ea
Increase global karma timeout
...
Revert useless timeout added in karma spec
2019-05-29 13:01:15 +08:00
d480fc5192
Increase timeout of flaky specs
2019-05-28 17:59:45 +08:00
0625ccc652
Add failing test for saveNote error handling
2019-05-07 23:15:36 +02:00
d24d77a93a
Resolve discussion when suggestion is applied
...
- Adds color and a tooltip to describe this new behavior
- Does not resolve if discussion is already resolved
- Adds an action `resolveDiscussion` to simplify `toggleResolveNote`
- Updates docs
https://gitlab.com/gitlab-org/gitlab-ce/issues/54405
2019-05-07 00:00:40 -05:00
911701ae47
Extract discussion notes into new component
...
- Moved discussion notes out of `NoteableDiscussion` component into a
new `DiscussionNotes` component
- Wrote Jest tests for the new `DiscussionNotes` component
- Updated Jest config for emojis fixtures
- Updated Karma tests `NoteableDiscussion` to match its new structure
- Convert `DiffDiscussions` tests to use Vue test utils
2019-05-01 10:04:07 +00:00
e540c0d71e
Fixed test specs
...
- added suggestions to mock data
- fixed props to be not required
2019-04-04 13:08:34 +00:00
c17b7afa02
Remove reply_to_individual_notes feature flag
...
Also removes specs related to the flag
2019-04-03 10:00:18 +08:00
4f0b2079de
Upgraded Vue to 2.6.8
...
Upgrade to latest Version
2019-03-27 21:33:20 +00:00
4d1ac56518
Remove top-level mount from note_form_spec.js
2019-03-26 19:53:07 +01:00
514ee63826
Move some tests from Karma to Jest
2019-03-23 17:53:46 +01:00
53e23a296d
Pass autosaveKey from NoteableDiscussion to NoteForm
2019-03-21 17:14:44 +01:00
93c27c3b22
Validate NoteForm props in noteable_discussion_spec.js
2019-03-21 17:14:44 +01:00
f5ce678dfe
Use autosave utilities in NoteForm component
2019-03-21 17:14:44 +01:00
d72a61b41d
Handle transformed notes from polling response
...
Transforms notes when the note was transformed in some other tab
2019-03-06 17:19:27 +08:00
3754111477
Move EE differences in CE diff files into CE
...
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/9974 , https://gitlab.com/gitlab-org/gitlab-ee/issues/9973 , https://gitlab.com/gitlab-org/gitlab-ee/issues/9969
2019-03-01 09:34:16 +00:00
1b85760467
Merge branch 'winh-note_form_spec-vue-test-utils' into 'master'
...
Refactor note_form_spec.js to use Vue test utils
See merge request gitlab-org/gitlab-ce!25571
2019-03-01 00:40:28 +00:00
910c7f5f63
Refactor note_form_spec.js to use Vue test utils
2019-02-28 09:21:32 +01:00
a565f3d88d
Fix misspellings in app/spec executable lines
...
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
2019-02-27 22:41:34 +09:00
2dd22ecb46
Add support for toggling discussion filter from notes section
...
Adds discussion note style section under notes app from where
user can toggle discussion when they have selected a filter to show
only system notes.
2019-02-26 14:04:15 +00:00
a26cd1235a
Extract ResolveWithIssueButton from NoteableDiscussion component
2019-02-25 16:38:29 +00:00
161851de36
Merge branch 'winh-jest-gitlab-ui' into 'master'
...
Make Jest work with gitlab-ui
Closes #56689
See merge request gitlab-org/gitlab-ce!25440
2019-02-21 11:26:05 +00:00
0e619d01b0
Move discussion_jump_to_next_button_spec.js to Jest
2019-02-21 10:53:00 +01:00
810a8b78b6
CE backport of design-management-issue-tab
...
Backports template and Vue changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9632 to CE
2019-02-20 14:51:06 +00:00
GitLab Bot
Samantha Ming
Igor Drozdov
Patrick Derichs
Arun Kumar Mohan
Sam Bigelow
Heinrich Lee Yu
jboyson1
Natalia Tepluhina
Winnie Hellmann
Tim Zallmann
Sean McGivern
Michel Engelen
Marc Schwede
Fatih Acet
Paul Slaughter
Paul Gascou-Vaillancourt
Oswaldo Ferreira
Phil Hughes
Takuya Noguchi
Kushal Pandya