3a2abc1d50
Enable the Layout/ExtraSpacing cop
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-01-24 13:05:45 +01:00
b44a2c801a
Update specs to rails5 format
...
Updates specs to use new rails5 format.
The old format:
`get :show, { some: params }, { some: headers }`
The new format:
`get :show, params: { some: params }, headers: { some: headers }`
2018-12-19 10:04:31 +11:00
87444fb6ed
Adds pagination to pipelines table in merge request page
2018-10-31 17:10:36 +00:00
70830c2300
Add target branch to cherry pick confirmation message
2018-08-19 23:11:49 +03:00
a63bce1a4b
Resolve "Rename the `Master` role to `Maintainer`" Backend
2018-07-11 14:36:08 +00:00
dfdd881510
Workhorse to send raw diff and patch for commits
...
Prior to this change, this was done through unicorn. In theory this
could time out. Workhorse has been sending these raw patches and diffs
for a long time and is stable in doing so.
Added bonus is the fact that `Commit#to_patch` can be removed.
`Commit#to_diff` too, which closes
https://gitlab.com/gitlab-org/gitaly/issues/324
Closes https://gitlab.com/gitlab-org/gitaly/issues/1196
2018-05-16 11:52:43 +02:00
360b94ceba
adding view and feature specs
2017-12-07 09:06:59 -05:00
cb6f51ec9b
add support for the commit reference filter
2017-12-07 09:01:37 -05:00
142edf0afc
diff notes created in merge request on a commit have the right context
...
add a spec for commit merge request diff notes
2017-12-07 09:01:23 -05:00
f9565e3039
Batchload blobs for diff generation
...
After installing a new gem, batch-loader, a construct can be used to
queue data to be fetched in bulk. The gem was also introduced in both
gitlab-org/gitlab-ce!14680 and gitlab-org/gitlab-ce!14846 , but those mrs
are not merged yet.
For the generation of diffs, both the old blob and the new blob need to
be loaded. This for every file in the diff, too. Now we collect all
these so we do 1 fetch. Three `.allow_n_plus_1_calls` have been removed,
which I expect to be valid, but this needs to be confirmed by a full CI
run.
Possibly closes:
- https://gitlab.com/gitlab-org/gitlab-ce/issues/37445
- https://gitlab.com/gitlab-org/gitlab-ce/issues/37599
- https://gitlab.com/gitlab-org/gitlab-ce/issues/37431
2017-11-21 13:53:26 +01:00
d9313795e7
Merge branch '37824-many-branches-lock-server' into 'master'
...
Project with many branches can lock server running "git branch --contains XXX"
Closes #37824
See merge request gitlab-org/gitlab-ce!14812
2017-11-07 21:49:27 +00:00
2f40dac352
Refactor `have_http_status` into `have_gitlab_http_status` in the specs
2017-10-20 10:13:18 +02:00
cbdf372eb8
implemented using an ivar, and added specs
2017-10-13 19:11:11 +02:00
706d99aed8
Update Pipeline's badge count in Merge Request and Commits view to match real-time content
2017-07-14 15:52:54 +00:00
fe13f11041
Create and use project path helpers that only need a project, no namespace
2017-07-05 11:11:59 -05:00
0430b76441
Enable Style/DotPosition Rubocop 👮
2017-06-21 13:48:12 +00:00
a6ec5121f0
Correct RSpec/SingleLineHook cop offenses
2017-06-14 13:18:56 -05:00
336016fa85
Satisfy Rubocop
2017-04-05 17:44:14 +01:00
08bbb9fce6
Add option to start a new discussion on an MR
2017-04-05 17:44:14 +01:00
6cc4cf1e15
Fix cherry-picking or reverting through an MR
2017-03-02 17:41:05 -06:00
ad640bc5f9
Use Namespace#full_path instead of #path where appropriate
2017-02-23 17:55:01 -06:00
ac5b3ce02a
Add controller tests for commit pipelines endpoint
2017-01-27 15:23:09 +01:00
4642ca6686
Use `empty_project` where possible in controller specs
2017-01-25 17:14:38 -05:00
2dd5db749f
Add sorting pipeline for a commit
2017-01-19 18:04:02 +09:00
c90483406e
refactors tests because of gitlab-test repository changes
2016-10-11 16:33:06 +01:00
519275c110
fixes part1 of files to start using active tense
2016-08-09 15:06:23 +01:00
8f359ea917
Move to Gitlab::Diff::FileCollection
...
Instead calling diff_collection.count use diff_collection.size which is cache on the diff_collection
2016-08-03 07:00:20 +02:00
cd7c2cb6dd
Cache highlighted diff lines for merge requests
...
Introducing the concept of SafeDiffs which relates
diffs with UI highlighting.
2016-08-03 07:00:19 +02:00
08bac55149
Fix failing CommitController spec
2016-07-28 16:37:03 -04:00
5266ae87c4
Support renames in diff_for_path actions
2016-07-11 09:31:34 +01:00
e462e12278
Tidy up spec action names
2016-07-08 18:11:47 +01:00
b6b26692ea
Collapse large diffs by default
...
When rendering a list of diff files, skip those where the diff is over
10 KB and provide an endpoint to render individually instead.
2016-07-08 10:56:55 +01:00
0fdfd2dd6e
Fix Error 500 when viewing a blob with binary characters after the 1024-byte mark
...
Here was the problem:
1. When determining whether a given blob is viewable text, gitlab_git reads the first 1024 bytes and checks with Linguist whether it is a text or binary file.
2. If the blob is text, GitLab will attempt to display it.
3. However, if the text has binary characters after the first 1024 bytes, then GitLab will attempt to load the entire contents, but the encoding will be ASCII-8BIT since there are binary characters.
4. The Error 500 results when GitLab attempts to display a mix UTF-8 and ASCII-8BIT.
To fix this, we load as much data as we are willing to display so that the detection will work properly. Requires
an update to gitlab_git: gitlab-org/gitlab_git!86
Closes #13826
2016-06-12 07:36:25 -07:00
f5ab126fd0
Ensure Commit#show responds 404 instead of 500 when given an invalid ID
...
Closes #13467
2016-02-15 15:48:16 -05:00
Rémy Coutable
blackst0ne
Filipa Lacerda
George Andrinopoulos
Mark Chao
Zeger-Jan van de Weg
micael.bergeron
Annabel Dunstone Gray
Jacopo
Brett Walker
Douwe Maan
Grzegorz Bizon
Robert Speicher
Grzegorz Bizon
Takuya Noguchi
tiagonbotelho
Paco Guzman
Alejandro Rodríguez
Sean McGivern
Stan Hu