2b6307f6ad
Enable RuboCop Style/RegexpLiteral
2018-02-01 02:06:07 +09:00
729f05f0e3
Adds Rubocop rule for line break around conditionals
2018-01-11 16:34:01 +00:00
aeb2f49fd4
Revert "check for `read_only?` first before seeing if request is disallowed"
...
This reverts commit 91075c8237
2017-11-21 15:35:30 +01:00
91075c8237
check for `read_only?` first before seeing if request is disallowed
2017-11-21 13:30:54 +01:00
cba68d338b
use `Gitlab::Routing.url_helpers` instead of `Rails.application.routes.url_helpers`
...
since `Rails.application.routes.url_helpers` creates a new anonymous module every time it's called
2017-11-21 13:29:57 +01:00
3c52e2f06e
Optimize read-only middleware so that it does not consume as much CPU
...
In !15082 , we changed the behavior of the middleware to call
`Rails.application.routes.recognize_path` whenever a new route arrived.
However, this can be a CPU-intensive task because Rails needs to allocate
memory and compile 850+ different regular expressions, which are complicated
in GitLab.
As a short-term fix, we can do a lightweight string match before
we do the heavier comparison.
Closes #40185 , gitlab-com/infrastructure#3240
2017-11-20 15:27:52 -08:00
4f09d099e9
Merge branch '18040-rubocop-line-break-after-guard-clause' into 'master'
...
Adds Rubocop rule for line break after guard clause
Closes #18040
See merge request gitlab-org/gitlab-ce!15188
2017-11-20 09:22:14 +00:00
f767dd4a4d
Fix go-import meta data when enabled_git_access_protocol is a blank string
2017-11-17 12:17:16 +01:00
181cd299f9
Adds Rubocop rule for line break after guard clause
...
Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.
2017-11-16 17:58:29 +01:00
b579cc7620
Merge branch 'feature-change-signout-route' into 'master'
...
Change Sign Out route from a DELETE to a GET
Closes #39708
See merge request gitlab-org/gitlab-ce!15231
2017-11-08 09:28:50 +00:00
4dea7944c4
Updates tests to reflect sign_out route change
...
- Also remove sign_out DELETE route from read-only whitelist routes
2017-11-07 11:42:25 -06:00
67b3e3d84a
move metrics for ActiveRecord, RailsCache and queue duration to instance variables
2017-11-02 18:18:16 +01:00
77e938a8f9
Avoid using Send (but is it better?) + small rubocop cleanup
2017-11-02 18:11:44 +01:00
95a23d246c
Convert rails_queue_duration to metric_rails_queue_duration_seconds
2017-11-02 18:11:44 +01:00
2fd5cc2bff
Geo route whitelisting is too optimistic
2017-11-02 12:50:04 +00:00
1cc92dae77
Returns a ssh url for go-get=1
2017-10-31 19:22:40 -02:00
d13669716a
Create idea of read-only database
...
In GitLab EE, a GitLab instance can be read-only (e.g. when it's a Geo
secondary node). But in GitLab CE it also might be useful to have the
"read-only" idea around. So port it back to GitLab CE.
Also having the principle of read-only in GitLab CE would hopefully
lead to less errors introduced, doing write operations when there
aren't allowed for read-only calls.
Closes gitlab-org/gitlab-ce#37534 .
2017-10-06 22:37:40 +02:00
bc10afb600
Merge branch 'dm-go-get-xss' into 'security-9-3'
...
Fix XSS issue in go-get handling
See merge request !2128
2017-09-07 20:22:16 -04:00
4edfad9678
Enable Layout/TrailingWhitespace cop and auto-correct offenses
2017-08-15 13:44:37 -04:00
d0622b79d8
Better categorize test coverage results
...
Also marks a few things as uncovered, and removes an unused class.
2017-08-11 10:59:11 -04:00
359f04e8a1
Fix go-get support for projects in nested groups
2017-03-07 19:40:19 -06:00
780e3e976d
fix missing @ symbol
2017-02-27 12:20:00 -06:00
48707bc2ab
ensure webpack dev server proxy connects regardless of request headers
2017-02-27 00:32:50 -06:00
b7d8df503c
Enable Style/MutableConstant
2017-02-23 09:31:56 -06:00
a2d837a371
add rack middleware to proxy webpack dev server
2017-02-01 16:23:26 -06:00
4ec259fd36
Inject ::UploadedFile from Multipart middleware
...
I mistakenly concluded Rack::Multipart injects File instances into the
params. These should be UploadedFile instances. This reuses a mock
UploadedFile class we already had in GitLab.
2016-12-21 13:07:53 +01:00
6731ab5d76
Add Gitlab::Middleware::Multipart
2016-12-15 12:26:36 +01:00
2bd0ed4a5c
Fix typo in gitlab-workhorse header
2016-08-19 12:25:52 +02:00
face87b7bb
Enable Style/Semicolon rubocop style cop
...
See #17478
2016-06-01 08:45:14 +02:00
5771114f9b
Rename metric to 'rails queue duration'
2016-05-26 17:53:21 +02:00
c049534da6
Align class name with field name
2016-05-25 14:55:23 +02:00
3c785a761c
Send data to InfluxDB instead of stdout
2016-05-25 14:28:21 +02:00
cee07c5919
Measure proxy timing: needs influxdb code
2016-05-24 17:07:41 +02:00
74d7de8196
Revert "Revert "Merge branch 'support-go-subpackages' into 'master'
""
...
This reverts commit 5a586f364c
2016-03-12 21:05:23 +00:00
5a586f364c
Revert "Merge branch 'support-go-subpackages' into 'master'
"
...
This reverts merge request !3191
2016-03-12 17:42:51 +00:00
380a67ad4c
Ensure PATH_INFO exists for go-get
2016-03-12 08:10:54 -08:00
bb206f947f
Simplify code
2016-03-12 07:50:02 -08:00
cc065fbeaa
Support Golang subpackage fetching
...
Closes #13805
2016-03-12 01:09:37 -08:00
efd8491d49
Revert "Increase timeout for Git-over-HTTP requests."
...
This reverts commit 516bcabbf4
2015-03-19 18:29:20 -07:00
516bcabbf4
Increase timeout for Git-over-HTTP requests.
2015-03-04 23:20:47 +01:00
938a1381fc
Satisfy Rubocop.
2015-02-20 16:04:03 +01:00
4310431ee7
Use modified ActionDispatch::Static to let uploads go through to routes.
2015-02-20 12:44:07 +01:00
Takuya Noguchi
🙈 jacopo beschi 🙉
digitalMoksha
Stan Hu
Rémy Coutable
Douwe Maan
Jacopo
Douwe Maan
Joe Marty
Pawel Chojnacki
Brett Walker
Guilherme Vieira
Toon Claes
Robert Speicher
Robert Speicher
Mike Greiling
Jacob Vosmaer
Grzegorz Bizon
Dmitriy Zaporozhets