API: Return 404 if user does not have access to group
Closes#15185
After !3587 is merged, I'll update this one to also fix the return code of the tests in !3587.
See merge request !3683
API: Ability to update a group
This makes it much easier to update a group after introducing the group visibility.
* Closes#14991
See merge request !3587
Decouple membership and notifications
This allow you to have notification setting per project even if you are member of group.
It also creates background for having notification settings in project you are not member of.
- [x] Make it work
- [x] Migrations
- [x] CHANGELOG
- [x] More tests
- [x] API
For #3359
After this merge request there is still some work to be done:
* create migration that remove duplicates in notification settings table and create uniq index (8.8 probably)
* remove notification_level field from Member model in 9.0
* make proper API for notification settings
* use `MemberCreateService` instead of Member#after_create callback for creating notification settings (after #14709)
* maybe more tests
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
See merge request !3421
Delete notes via API
Supports deleting issues, snippets, and merge requests via the API.
* Closes#14944
* Closes#14845
* Closes#6060
@zj I did not see that you assigned yourself in #6060. Hopefully, you did not start yet.
@rymai In #6060 this is targeted for 8.7 release. Could you review that and maybe this still lands in 8.7.
See merge request !3557
API: Add iid filter to milestones
This was documented in the API docs but it was never working because the iid filter was never applied to the milestones. The tests were working by accident because the were checking the first element, which was by accident the request element.
* Closes https://github.com/gitlabhq/gitlabhq/issues/10122
See merge request !3588
not_found appends string "Not Found" to the argument causing the resulting message to be "Branch does not exist Not Found" which is an incorrect error message.
Changed the argument of not_found! for 'unprotect' command to "Branch" from "Branch does not exist". This makes the final error message to appear as "Branch Not Found" which is correct and same as error messages for other commands like 'protect'.
Rails' "url_helpers" method creates an anonymous Module (which a bunch
of methods) on every call. By caching the output of this method in a
dedicated method we can shave off about 10 seconds of loading time for
an issue with around 200 comments.
Dmitriy Zaporozhets
Rémy Coutable
Robert Schilling
Douwe Maan
Robert Speicher
Zeger-Jan van de Weg
Douglas Barbosa Alexandre
Yasser Hussain
Robert Speicher
Yorick Peterse
connorshea
Mariusz Jachimowicz
Douwe Maan