Commit Graph

130 Commits

Author SHA1 Message Date
Gosia Ksionek 6c5e948013 Fix error on project name
Add project path to sql query to build proper path
2019-08-05 21:15:00 +00:00
Małgorzata Ksionek 822129b6b7 Change sql query 2019-07-23 22:00:50 +02:00
Małgorzata Ksionek 5ce4236b66 Add code review remarks
Add cr remarks

Improve specs according to the review

Fix schema

Add cr remarks

Fix naming

Add cr remarks
2019-07-23 12:01:39 +02:00
Małgorzata Ksionek 1b102f5d11 Add basic project extraction
To allow project filtering

Prepare summary for accepting multiple groups

Modify deploys group summary class

Add filtering by project name in issues summary

Fix rubocop offences

Add changelog entry

Change name to id in project filtering

Fix rebase problem

Add project extraction
2019-07-23 12:01:39 +02:00
Małgorzata Ksionek 18535eb411 Add code review remarks
Change small things for better readability
2019-07-16 18:45:15 +02:00
Małgorzata Ksionek 1dde18f394 Add code review remarks
Make specs more readable
2019-07-16 12:33:42 +02:00
Małgorzata Ksionek beaa635306 Add class for group level analytics
Add specs for group level

Update entities

Update base classes

Add groups-centric changes

Update plan and review stage

Add summary classes

Add summary spec

Update specs files

Add to specs test cases for group

Add changelog entry

Add group serializer

Fix typo

Fix typo

Add fetching namespace in sql query

Update specs

Add rubocop fix

Add rubocop fix

Modify method to be in sync with code review

Add counting deploys from subgroup

To group summary stage

Add subgroups handling

In group stage summary

Add additional spec

Add additional specs

Add more precise inheritance

Add attr reader to group level

Fix rubocop offence

Fix problems with specs

Add cr remarks

Renaming median method and a lot of calls in specs

Move spec setup

Rename method in specs

Add code review remarks regarding module

Add proper module name
2019-07-15 15:06:40 +02:00
Małgorzata Ksionek 198df06fea Add attribute reader 2019-07-10 13:22:29 +02:00
Małgorzata Ksionek 2d283dd403 Add guard clause 2019-07-09 12:16:38 +02:00
Małgorzata Ksionek 3459ba13b2 Add cr remarks 2019-07-09 12:16:38 +02:00
Małgorzata Ksionek f6423fa468 Add code review remarks 2019-07-09 12:16:38 +02:00
Małgorzata Ksionek 21bc038b8d Add one method to base event fetcher
FIx file
2019-07-09 12:16:37 +02:00
Małgorzata Ksionek 04dea6546a Fix rubocop offences 2019-07-09 12:16:37 +02:00
Małgorzata Ksionek ae2514d0a1 Update class calls 2019-07-09 12:16:37 +02:00
Małgorzata Ksionek abca34d08e Modify base class for cycle analytics fetching 2019-07-09 12:16:37 +02:00
Małgorzata Ksionek 68a5e20532 Change constant path 2019-07-09 12:16:37 +02:00
Gosia Ksionek 976b8b5391 Fix plan stage query
Fix plan stage query and the way it is displayed
2019-06-17 13:17:18 +00:00
Andrew Newdigate 3288e1a874 Adds the Rubocop ReturnNil cop
This style change enforces `return if ...` instead of
`return nil if ...` to save maintainers a few minor review points
2019-03-06 17:51:56 +02:00
gfyoung 7e6f6e1603 Enable even more frozen string in lib/gitlab
Enables frozens string for the following:

* lib/gitlab/conflict/**/*.rb
* lib/gitlab/cross_project_access/**/*.rb
* lib/gitlab/cycle_analytics/**/*.rb
* lib/gitlab/data_builder/**/*.rb
* lib/gitlab/database/**/*.rb
* lib/gitlab/dependency_linker/**/*.rb
* lib/gitlab/diff/**/*.rb
* lib/gitlab/downtime_check/**/*.rb
* lib/gitlab/email/**/*.rb
* lib/gitlab/etag_caching/**/*.rb

Partially addresses gitlab-org/gitlab-ce#47424.
2018-11-06 22:47:32 -08:00
Kim Carlbäcker 1d50b6a4ad Migrate CycleAnalytics::CommitCount to Gitaly 2018-06-11 12:59:11 +00:00
Jacob Vosmaer (GitLab) edb9db37ed Add "deny disk access" Gitaly feature (tripswitch) 2018-06-01 11:56:29 +00:00
Tiago Botelho 522f4b2c6a Adapt cycle analytics spec helper and cycle analytics usage data spec 2018-03-01 16:43:26 +00:00
Tiago Botelho 335ee79a73 Refactors median code to work with both single and multiple projects 2018-02-28 10:46:20 +00:00
Tiago Botelho 3f31da9c69 Restrict cycle analytics usage data to instances that use postgres only 2018-02-28 10:46:20 +00:00
Tiago Botelho 41bb23ae1d Restore memoization to base query and add a batch base query method 2018-02-28 10:46:20 +00:00
Tiago Botelho 4fcbcce364 Add BatchLoader as a way to refactor the base stage code 2018-02-28 10:46:20 +00:00
Tiago Botelho 7c109c5750 Refactor CycleAnalytics base stage class and model 2018-02-28 10:46:19 +00:00
Tiago Botelho a7b3f11edd Adds get all medians to Cycle Analytics model 2018-02-28 10:46:19 +00:00
Yorick Peterse d0b8f536a1
Remove soft removals related code
This removes all usage of soft removals except for the "pending delete"
system implemented for projects. This in turn simplifies all the query
plans of the models that used soft removals. Since we don't really use
soft removals for anything useful there's no point in keeping it around.

This _does_ mean that hard removals of issues (which only admins can do
if I'm not mistaken) can influence the "iid" values, but that code is
broken to begin with. More on this (and how to fix it) can be found in
https://gitlab.com/gitlab-org/gitlab-ce/issues/31114.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37447
2018-01-08 17:04:45 +01:00
Lin Jen-Shin 85be6d83be Merge remote-tracking branch 'upstream/master' into no-ivar-in-modules
* upstream/master: (170 commits)
  support ordering of project notes in notes api
  Redirect to an already forked project if it exists
  Reschedule the migration to populate fork networks
  Create fork networks for forks for which the source was deleted.
  Fix item name and namespace text overflow in Projects dropdown
  Minor backport from EE
  fix link that was linking to `html` instead of `md`
  Backport epic tasklist
  Add timeouts for Gitaly calls
  SSHUploadPack over Gitaly is now OptOut
  fix icon colors in commit list
  Fix star icon color/stroke
  Backport border inline edit
  Add checkboxes to automatically run AutoDevops pipeline
  BE for automatic pipeline when enabling Auto DevOps
  I am certainly weary of debugging sidekiq but I don't think that's what was meant
  Ensure MRs always use branch refs for comparison
  Fix issue comment submit button disabled on GFM paste
  Lock seed-fu at the correct version in Gemfile.lock
  Improve indexes on merge_request_diffs
  ...
2017-11-30 15:20:00 +08:00
Sean McGivern 4ebbfe5d3e Remove serialised diff and commit columns
The st_commits and st_diffs columns on merge_request_diffs historically held the
YAML-serialised data for a merge request diff, in a variety of formats.

Since 9.5, these have been migrated in the background to two new tables:
merge_request_diff_commits and merge_request_diff_files. That has the advantage
that we can actually query the data (for instance, to find out how many commits
we've stored), and that it can't be in a variety of formats, but must match the
new schema.

This is the final step of that journey, where we drop those columns and remove
all references to them. This is a breaking change to the importer, because we
can no longer import diffs created in the old format, and we cannot guarantee
the export will be in the new format unless it was generated after this commit.
2017-11-28 16:13:40 +00:00
Lin Jen-Shin 689658456f Cache allowed_ids 2017-11-22 23:30:51 +08:00
Lin Jen-Shin 07d3d44775 Move ModuleWithInstanceVariables to Gitlab namespace
And use .rubocop.yml to exclude paths we don't care,
rather than using the cop itself to exclude.
2017-11-22 17:06:57 +08:00
Lin Jen-Shin 0b6d01ed77 Just define allowed_ids and override it with empty value
if not needed for those sub-classes.
2017-11-22 17:06:57 +08:00
Lin Jen-Shin 9ac0c76b78 Use StrongMemoize and enable/disable cops properly 2017-11-18 01:01:53 +08:00
Lin Jen-Shin 6a4ee9aa71 Allow simple ivar ||= form. Update accordingly 2017-09-19 01:29:32 +08:00
Lin Jen-Shin 9ae92b8caa Add cop to make sure we don't use ivar in a module 2017-09-18 21:23:45 +08:00
Alejandro Rodríguez c21ae07e33 Refactor Gitlab::Git::Commit to include a repository 2017-08-07 22:34:34 -04:00
Sean McGivern aff5c9f3e5 Add table for merge request commits
This is an ID-less table with just three columns: an association to the merge
request diff the commit belongs to, the relative order of the commit within the
merge request diff, and the commit SHA itself.

Previously we stored much more information about the commits, so that we could
display them even when they were deleted from the repo. Since 8.0, we ensure
that those commits are kept around for as long as the target repo itself is, so
we don't need to duplicate that data in the database.
2017-07-06 17:36:10 +01:00
Grzegorz Bizon 0430b76441 Enable Style/DotPosition Rubocop 👮 2017-06-21 13:48:12 +00:00
Rémy Coutable d40e1f547e Enable the Style/TrailingCommaInLiteral cop
Use the EnforcedStyleForMultiline: no_comma option.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-10 18:25:45 +02:00
Ruben Davila 7f24b87b3b Some small updates for Spanish translations. 2017-05-04 19:27:17 -05:00
Ruben Davila 7fd42698aa Merge branch 'master' into 28433-internationalise-cycle-analytics-page
Conflicts:
	lib/gitlab/cycle_analytics/review_stage.rb
	lib/gitlab/cycle_analytics/staging_stage.rb
	lib/gitlab/cycle_analytics/test_stage.rb
2017-05-04 18:51:18 -05:00
Douwe Maan 897f98cc9d Fix wording of Cycle Analytics stage legends 2017-05-04 18:12:49 -05:00
Ruben Davila dbd1bdaeed More updates for translations plus some refactoring. 2017-05-03 21:08:43 -05:00
Ruben Davila ee65de48d8 More translations updates. 2017-05-03 12:40:21 -05:00
Ruben Davila e4526e061c Add more translation for Spanish. 2017-04-26 20:04:33 -05:00
Jacob Schatz 12cd4c8360 Merge branch 'add-additional-checks-to-ca-data' into 'master'
Small improvements for Cycle Analytics

See merge request !9153
2017-02-18 18:52:43 +00:00
Alfredo Sumaran d3ff2fa59b Restore exposure of legend property for events 2017-02-10 16:17:44 -05:00
Alfredo Sumaran 7b20784715 Revert "Merge branch 'add-additional-checks-to-ca-data' into 'master' "
This reverts commit b7c5ca499d, reversing
changes made to 9745c98bb7.
2017-02-10 15:21:45 -05:00