Commit Graph

48 Commits

Author SHA1 Message Date
GitLab Bot 38a1a6cb91 Add latest changes from gitlab-org/gitlab@master 2021-06-18 12:10:03 +00:00
GitLab Bot f5823d9c24 Add latest changes from gitlab-org/gitlab@master 2021-06-01 03:10:06 +00:00
GitLab Bot a880341a7b Add latest changes from gitlab-org/gitlab@master 2021-05-25 18:10:42 +00:00
GitLab Bot 71a67d17b0 Add latest changes from gitlab-org/gitlab@master 2021-05-12 12:10:24 +00:00
GitLab Bot d6d1051383 Add latest changes from gitlab-org/gitlab@master 2021-04-22 21:09:53 +00:00
GitLab Bot cb840235d7 Add latest changes from gitlab-org/gitlab@master 2021-03-17 15:09:03 +00:00
GitLab Bot f784f7d3b1 Add latest changes from gitlab-org/gitlab@master 2020-09-15 18:09:43 +00:00
GitLab Bot c4b69460e8 Add latest changes from gitlab-org/gitlab@master 2020-08-28 09:10:32 +00:00
GitLab Bot f8454d351e Add latest changes from gitlab-org/gitlab@master 2020-07-23 03:09:42 +00:00
GitLab Bot 4bc0e06402 Add latest changes from gitlab-org/gitlab@master 2020-07-17 03:09:14 +00:00
GitLab Bot 6b922f9bb0 Add latest changes from gitlab-org/gitlab@master 2020-06-17 18:09:08 +00:00
GitLab Bot 8b0ef13236 Add latest changes from gitlab-org/gitlab@master 2020-06-03 18:08:28 +00:00
GitLab Bot 2164573e45 Add latest changes from gitlab-org/gitlab@master 2020-06-02 21:08:00 +00:00
GitLab Bot d3c29eae5c Add latest changes from gitlab-org/gitlab@master 2020-03-05 21:08:13 +00:00
GitLab Bot 1ca9950d5f Add latest changes from gitlab-org/gitlab@master 2020-02-11 18:08:58 +00:00
GitLab Bot c57e10faab Add latest changes from gitlab-org/gitlab@master 2020-02-10 18:09:00 +00:00
GitLab Bot 211a8c3361 Add latest changes from gitlab-org/gitlab@master 2020-02-07 12:09:13 +00:00
Peter Leitzen afe5f171db Expose update project service JSON endpoint
Utilize `json_fields` to expose fields via
`Service#as_json(only: json_fields)`.
2019-09-09 20:22:00 +00:00
GitLab Release Tools Bot 7d6ec7f7ed Merge branch 'security-fix_jira_ssrf_vulnerability' into 'master'
Fix DNS rebind vulnerability for JIRA integration

See merge request gitlab/gitlabhq!3266
2019-08-29 21:34:17 +00:00
Vitali Tatarintev 6a6411938a Change `be_success` to `be_successful` in specs
Fixes deprecation warning:

```
DEPRECATION WARNING: The success? predicate is deprecated and
will be removed in Rails 6.0.
Please use successful? as provided by Rack::Response::Helpers.
```
2019-08-19 14:40:56 +02:00
Felipe Artur 492a7e753d Fix DNS rebind vulnerability for JIRA integration
Uses Gitlab::HTTP for JIRA requests instead of Net::Http.
Gitlab::Http comes with some built in SSRF protections.
2019-08-08 10:24:43 -03:00
Takuya Noguchi af5da7564e Replace 'JIRA' with 'Jira'
https://community.atlassian.com/t5/Jira-questions/Is-it-quot-JIRA-quot-or-quot-Jira-quot/qaq-p/681163

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
2019-06-28 13:25:56 +00:00
James Fargher 6b9157d5dc Make KubernetesService readonly
We are deprecating this service in favor of instance wide clusters.
Therefore we removed some code that is not anymore needed for a
readonly cluster and also we added some flags to allow for this
deprecation. These flags are to be removed in the next release when
we finally completelly remove KubernetesService.
2019-06-18 00:01:56 +00:00
gfyoung 93a44e135b Add some frozen string to spec/**/*.rb
Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-04-15 10:17:05 +00:00
Thong Kuah 4ec16912b8 Autocorrect with RSpec/ExampleWording cop
- rewords examples starting with 'should'
- rewords examples starting with 'it'

Note: I had to manually fixup "onlies" to "only"
2019-04-05 08:43:27 +00:00
Daniel Juarez 72b59d6e3b Fix comparing equality between `ActionController::Parameters` and a `Hash`.... 2019-02-05 12:30:06 +00:00
blackst0ne b44a2c801a Update specs to rails5 format
Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`
2018-12-19 10:04:31 +11:00
Nick Thomas ed4597538c
Stop using HipChat in the ServicesController spec 2018-12-13 16:40:46 +00:00
Mark Chao a63bce1a4b Resolve "Rename the `Master` role to `Maintainer`" Backend 2018-07-11 14:36:08 +00:00
Francisco Javier López 840f80d48b Add validation to webhook and service URLs to ensure they are not blocked because of SSRF 2018-06-01 11:43:53 +00:00
James Edwards-Jones ef15668d82 Service integration displays validation errors on test fail
Fixes attempts to update a service integration which had `can_test?`
set to true but validations were causing the "Test and save changes"
button to return "Something went wrong on our end."

Removes references to index action left from 0af9943314
2018-03-07 17:50:11 +00:00
Mayra Cabrera e028d795c4 41054-Disallow creation of new Kubernetes integrations 2018-01-04 09:33:51 +00:00
blackst0ne 27c95364b5 Replace '.team << [user, role]' with 'add_role(user)' in specs 2017-12-22 19:18:28 +11:00
Jacopo 2f40dac352 Refactor `have_http_status` into `have_gitlab_http_status` in the specs 2017-10-20 10:13:18 +02:00
Rubén Dávila e6880ebc7d Fix inability to test some project integrations 2017-08-22 11:05:02 -05:00
Robert Speicher 72a7b30c9f Change all `:empty_project` to `:project` 2017-08-02 17:47:31 -04:00
Douwe Maan fe13f11041 Create and use project path helpers that only need a project, no namespace 2017-07-05 11:11:59 -05:00
Grzegorz Bizon 0430b76441 Enable Style/DotPosition Rubocop 👮 2017-06-21 13:48:12 +00:00
Jarka Kadlecova 84c68bb140 Address MR comments 2017-06-01 07:47:16 +02:00
Jarka Kadlecova 6fad5640e7 fix failing specs 2017-06-01 07:47:15 +02:00
Jarka Kadlecova 33d82ccb45 simplify test&save actions when setting a service integration 2017-06-01 07:47:15 +02:00
Tiago Botelho 6368072fd7 improves test settings for chat notification services for empty projects 2017-04-27 18:36:10 +01:00
Robert Speicher 4642ca6686 Use `empty_project` where possible in controller specs 2017-01-25 17:14:38 -05:00
Tiago Botelho 4b6e583ce0 adds test suite 2017-01-22 00:02:29 +00:00
Airat Shigapov b76ef40e36
Fix missing flash messages on service edit page 2016-09-05 14:13:15 +03:00
tiagonbotelho 519275c110 fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
Stan Hu 9bfc531ec6 Redirect to a default path if HTTP_REFERER is not set
Safari 9.0 does not yet honor the HTML5 `origin-when-cross-origin` mode,
and it's possible load balancers/proxies strip the HTTP_REFERER from
the request header. In these cases, default to some default path.

Closes #3122

Closes https://github.com/gitlabhq/gitlabhq/issues/9731
2015-10-20 07:45:48 -07:00
Stan Hu 2379057002 Provide more feedback what went wrong if HipChat service failed test
Issue gitlab-com/support-forum#213
2015-08-12 07:31:25 -07:00