Commit Graph

71 Commits

Author SHA1 Message Date
GitLab Bot 2ac4833015 Add latest changes from gitlab-org/gitlab@master 2020-10-08 18:08:32 +00:00
gfyoung 12ee2753c1 Enable even more frozen string in app/controllers
Enables frozen string for some vestigial files as
well as the following:

* app/controllers/projects/**/*.rb
* app/controllers/sherlock/**/*.rb
* app/controllers/snippets/**/*.rb
* app/controllers/users/**/*.rb

Partially addresses #47424.
2018-09-25 22:43:49 -07:00
Douwe Maan fe13f11041 Create and use project path helpers that only need a project, no namespace 2017-07-05 11:11:59 -05:00
Lin Jen-Shin 524c947eaf Add checks before redirect, remove status/trace
compatible urls, which were for javascripts
2017-05-24 15:31:30 +08:00
Lin Jen-Shin 43981250c4 Use controllers to redirect 2017-05-23 21:20:59 +08:00
Lin Jen-Shin 71777a4a18 Rename BuildsController to JobsController
Rename other URL generators

admin_builds_path -> admin_jobs_path

Fix tests and more renaming

Fix more tests

Also change build_id to job_id in the controller
2017-05-17 20:17:30 +08:00
Fatih Acet 0151325dac Merge request widget redesign 2017-05-09 04:15:34 +00:00
Grzegorz Bizon 3264e09c6f Require build to be present in the controller 2017-05-05 14:04:51 +02:00
Grzegorz Bizon 61dd92aaff Authorize build update on per object basis 2017-05-05 14:04:45 +02:00
Dosuken shinya 73ac7b2dd6 Resolve "Add more tests for spec/controllers/projects/builds_controller_spec.rb" 2017-04-28 09:38:32 +00:00
Kamil Trzcinski 16a2eba52b
Count number of queries 2017-04-07 18:34:03 +02:00
Kamil Trzciński 828d81ee1f Optimise trace handling code to use streaming instead of full read 2017-04-06 16:20:27 +00:00
Kamil Trzciński 8391fa37f0 Merge branch '12818-expose-simple-cicd-status-endpoints-with-status-serializer-gitlab-ci-status-for-pipeline-job-and-merge-request' into 'master'
Expose CI/CD status API endpoints with Gitlab::Ci::Status facility on pipeline, job and merge request for favicon

See merge request !9561
2017-03-27 12:21:22 +00:00
Shinya Maeda 68aae3ab9e No need to authorize_update_build! if 'trace' requested (as same as 'raw') 2017-03-23 17:28:17 +09:00
Shinya Maeda 38b1ec2cc0 Fix rspec failure 2017-03-23 17:11:49 +09:00
Shinya Maeda 2b33e9eeb6 with_status to only_status 2017-03-23 17:11:49 +09:00
Shinya Maeda 0191455471 Remove legacy def status from builds_controller 2017-03-23 17:11:48 +09:00
Shinya Maeda ba27f1b954 Expose only status. ci_cd_status to status. Support abstract class. 2017-03-23 17:11:48 +09:00
Shinya Maeda 0e06cfc059 Add api points for ci cd status. Add favicon. 2017-03-23 17:11:48 +09:00
Rémy Coutable 0ac65b6cc3 Don't override presentee methods for Gitlab::View::Presenter::Delegated
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-01-24 10:24:47 +01:00
Rémy Coutable 061bb6eb6e More improvements to presenters
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-01-18 16:38:35 +01:00
Rémy Coutable 78874519db Add Presentable concern
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-01-18 16:38:34 +01:00
Lin Jen-Shin 637a41400c Merge remote-tracking branch 'upstream/master' into pipeline-emails
* upstream/master: (206 commits)
  Implement fourth round of comments from @DouweM.
  Fix `CreateDeploymentService` spec.
  Reload issues in spec to ensure label<->issue mapping properly loaded
  Fix build.
  Remove unnecessary #{} in cycle analytics template.
  Update cycle analytics icon and fix color of the dismiss button.
  Use triple dashes for the empty value in cycle analytics.
  Fix typo on cycle analytics copy.
  Add page title and fix sub menu width in Cycle Analytics page.
  Update Cycle Analytics Read more link URL.
  Display the cycle analytics navbar based on the `:read_cycle_analytics` ability.
  Improve indentation in `Gitlab::Database::Median`
  Add a spec for merge request metric caching while refreshing a merge request from a forked project.
  Use the `IssuableBaseService` lifecycle hooks to cache `MergeRequestsClosingIssues`
  Implement a second round of review comments from @DouweM.
  Add docs on Cycle Analytics
  Test if issue authors can access private projects
  Update .pkgr.yml with Ubuntu 16.04 dependencies
  fix issues mr counter
  Move JSON generation (cycle analytics) into a controller method.
  ...
2016-09-21 16:19:07 +08:00
Lin Jen-Shin 63e03dada7 Make various trace methods take last_lines argument:
So that we could read last few lines rather than read
the entire file which could be huge.
2016-09-21 16:12:32 +08:00
Kamil Trzcinski 967eb8fb55 Merge branch 'master' into per-build-token 2016-09-19 13:31:42 +02:00
Kamil Trzcinski b51ededc5f Don't leak build tokens in build logs 2016-09-19 12:38:10 +02:00
Stan Hu 5a30a1eae6 Fix spelling: sucessfully -> successfully
Originally from gitlab-org/gitlab-ee!682
2016-09-15 19:27:49 -07:00
Tomasz Maczukin c8861da767
Update specs - add mocks to simulate old versions 2016-09-01 14:00:46 +02:00
Tomasz Maczukin 77295de407
Change 404 to 410 error when raw trace is unavailable 2016-09-01 14:00:45 +02:00
Tomasz Maczukin ed51734030
Handle error on trace raw download with old builds (DB stored) 2016-09-01 14:00:44 +02:00
Kamil Trzcinski 39203f1adf Pre-create all builds for Pipeline when a trigger is received
This change simplifies a Pipeline processing by introducing a special new status: created.
This status is used for all builds that are created for a pipeline.
We are then processing next stages and queueing some of the builds (created -> pending) or skipping them (created -> skipped).
This makes it possible to simplify and solve a few ordering problems with how previously builds were scheduled.
This also allows us to visualise a full pipeline (with created builds).

This also removes an after_touch used for updating a pipeline state parameters.
Right now in various places we explicitly call a reload_status! on pipeline to force it to be updated and saved.
2016-08-11 15:22:35 +02:00
Kamil Trzcinski f12faae8b8 Improve code design 2016-07-18 18:42:03 +02:00
Kamil Trzcinski e00da96c88 Improve manual actions code and add model, service and feature tests
Manual actions are accessible from:
- Pipelines
- Builds
- Environments
- Deployments
2016-07-18 14:46:20 +02:00
Kamil Trzcinski 7d0fe1f04e Add implementation of manual actions 2016-07-18 14:44:21 +02:00
Katarzyna Kobierska 5813aec22d Add Pending Tab to Admin Builds
Add Pending Tab to Project Builds

Update CHANGELOG
2016-07-18 10:23:32 +02:00
Kamil Trzcinski 907c0e6796 Added initial version of deployments 2016-06-10 23:36:54 +02:00
Phil Hughes dc6ec2adf8 CI build page UI update
Added sidebar
Removed elements not present in design
2016-06-10 12:07:51 +01:00
Kamil Trzcinski d9b292f872 Merge remote-tracking branch 'origin/master' into rename-ci-commit
# Conflicts:
#	spec/features/builds_spec.rb
2016-06-06 16:33:52 +02:00
Tomasz Maczukin 1f608ac461
Remove 'unscoped' from project builds selection 2016-06-04 00:02:40 +02:00
Kamil Trzcinski 021d3810c3 Rename Ci::Commit to Ci::Pipeline and rename some of the ci_commit to pipeline 2016-06-02 16:59:04 +02:00
Kamil Trzcinski 74520f23db Encode state as base64 string 2016-05-09 20:19:27 +03:00
Kamil Trzcinski baef6728fa Send trace to a browser incrementally when build is running
We send a state of ansi2html to client, client needs to send this state back.
The state describes the configuration of generator and position within trace.
2016-05-09 19:59:45 +03:00
Tomasz Maczukin 0a13f5f864
Use Rails-way to send file by X-Sendfile 2016-04-19 23:18:43 +02:00
Tomasz Maczukin 81510b46d5
Add feature specs for raw trace 2016-04-19 23:17:50 +02:00
Tomasz Maczukin bf4371d60d
Switch raw trace to use X-Sendfile header 2016-04-19 23:17:49 +02:00
Tomasz Maczukin 27d1349f2b
Add raw trace output for GitLab Workhorse 2016-04-19 23:17:49 +02:00
Grzegorz Bizon 86a49dfb88 Move build erasable implementation from concern to model
Discussion:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2560#note_3659905
2016-02-19 17:24:59 +01:00
Grzegorz Bizon 2c7f36f430 Update relevant build fields when build is erased 2016-02-19 17:24:59 +01:00
Grzegorz Bizon c8102d938b Add build eraseable feature implementation 2016-02-19 17:24:03 +01:00
Grzegorz Bizon c1affed196 Add build remove button to build summary view 2016-02-19 17:24:03 +01:00