gitlab-ce

Commit Graph

Author	SHA1	Message	Date
gfyoung	3836d69119	Enable frozen string in lib/api and lib/backup Partially addresses #47424. Had to make changes to spec files because stubbing methods on frozen objects is a mess in RSpec and leads to failures: https://github.com/rspec/rspec-mocks/issues/1190	2018-09-29 21:04:50 -07:00
Timothy Andrew	afbc7520c2	`AccessTokenValidationService` accepts `String` or `API::Scope` scopes. - There's no need to use `API::Scope` for scopes that don't have `if` conditions, such as in `lib/gitlab/auth.rb`.	2017-06-30 07:32:25 +00:00
Timothy Andrew	b8ec1f4201	Extract a `Gitlab::Scope` class. - To represent an authorization scope, such as `api` or `read_user` - This is a better abstraction than the hash we were previously using.	2017-06-29 06:15:57 +00:00

Author

SHA1

Message

Date

gfyoung

3836d69119

Enable frozen string in lib/api and lib/backup

Partially addresses #47424.

Had to make changes to spec files because
stubbing methods on frozen objects is a mess
in RSpec and leads to failures:

https://github.com/rspec/rspec-mocks/issues/1190

2018-09-29 21:04:50 -07:00

Timothy Andrew

afbc7520c2

`AccessTokenValidationService` accepts `String` or `API::Scope` scopes.

- There's no need to use `API::Scope` for scopes that don't have `if`
  conditions, such as in `lib/gitlab/auth.rb`.

2017-06-30 07:32:25 +00:00

Timothy Andrew

b8ec1f4201

Extract a `Gitlab::Scope` class.

- To represent an authorization scope, such as `api` or `read_user`
- This is a better abstraction than the hash we were previously using.

2017-06-29 06:15:57 +00:00

3 Commits