Commit Graph

4269 Commits

Author SHA1 Message Date
DJ Mountney 2afd2fbcb8 Merge branch 'upstream-9-2-security' into master-security-update 2017-06-08 10:08:06 -07:00
Sean McGivern e9002222a0 Merge branch 'dm-diff-file-diffable' into 'master'
Move diffable? method from Repository to Diff::File

See merge request !11980
2017-06-08 16:14:56 +00:00
Sean McGivern 9ea883fb5d Merge branch 'dm-highlight-diff-file-blob' into 'master'
Use Diff::File blob methods from diff highlighter

See merge request !11978
2017-06-08 15:50:30 +00:00
Douwe Maan e50c31abc0 Merge branch '33383_add_bulgarian_translation_of_cycle_analytics_page' into 'master'
Add bulgarian translation of Cycle Analytics Page to I18N

Closes #33383

See merge request !11958
2017-06-08 14:49:35 +00:00
Douwe Maan cf23d2a97a Merge branch '33334_add_portuguese_brazil_translation_of_cycle_analytics_page' into 'master'
Add portuguese brazil translation of Cycle Analytics Page to I18N

Closes #33334

See merge request !11920
2017-06-08 14:44:51 +00:00
Douwe Maan e6e29f9220 Use Diff::File blob methods from diff highlighter 2017-06-08 09:39:54 -05:00
Douwe Maan ffbbd4112e Move diffable? method from Repository to Diff::File 2017-06-08 09:32:57 -05:00
Grzegorz Bizon 1490d65e45 Merge branch 'blob-load-all-data' into 'master'
Blob#load_all_data! doesn’t need an argument

See merge request !11977
2017-06-08 11:17:43 +00:00
DJ Mountney 1d1363e2bb Bring in security changes from the 9.2.5 release
Ran:
 - git format-patch v9.2.2..v9.2.5 --stdout > patchfile.patch
 - git checkout -b 9-2-5-security-patch origin/v9.2.2
 - git apply patchfile.patch
 - git commit
 - [Got the sha ref for the commit]
 - git checkout -b upstream-9-2-security master
 - git cherry-pick <SHA of the patchfile commit>
 - [Resolved conflicts]
 - git cherry-pick --continue
2017-06-07 21:16:20 -07:00
Bob Van Landuyt bdebe849b8 Translate project & repository pages 2017-06-07 20:13:44 +00:00
Douwe Maan dbffaaa97e Blob#load_all_data! doesn’t need an argument 2017-06-07 14:28:33 -05:00
Luke "Jared" Bennett 32cac59727 Added more actions and report as abuse to all notes 2017-06-07 18:33:50 +00:00
Douwe Maan 4cb619fd73 Merge branch 'backport_fix_slash_commands_for_multiple_assignee' into 'master'
Backport from EE: Fix '/unassign' slash command

See merge request !11926
2017-06-07 17:57:35 +00:00
Douwe Maan 6d09c1fed8 Merge branch 'sync-email-from-omniauth' into 'master'
Sync email address from specified omniauth provider

See merge request !11268
2017-06-07 17:41:59 +00:00
Rémy Coutable e263e9f54f Merge branch 'fix-memoization-in-contributions-calendar' into 'master'
Fix memoization in ContributionsCalendar#activity_dates

See merge request !11973
2017-06-07 16:39:30 +00:00
Robin Bobbitt 469acd190e Sync email address from specified omniauth provider 2017-06-07 11:13:57 -04:00
Sean McGivern ed6f6cf2fc Fix memoization in ContributionsCalendar#activity_dates
This doesn't appear to be actually called twice, but having it appear to work
but not would be a problem if it was.
2017-06-07 14:29:49 +01:00
Pawel Chojnacki 0edc1ef675 Use key? instead of has_key? method 2017-06-07 14:37:32 +02:00
Sean McGivern d27db3eaed Merge branch 'dm-diff-file-straight-diff' into 'master'
Fix Diff::Position#diff_file for positions on straight diffs

See merge request !11947
2017-06-07 11:34:11 +00:00
Kamil Trzciński 5c26f4718b Merge branch 'feature/gb/persist-pipeline-stages' into 'master'
Persist stages in the database

Closes #26481

See merge request !11790
2017-06-07 11:32:29 +00:00
Grzegorz Bizon 37dd19935b Merge branch 'instrument-infra' into 'master'
Add Prometheus metrics endpoint and basic infrastructure to meter code

See merge request !11553
2017-06-07 10:46:56 +00:00
Sean McGivern 19982333d7 Merge branch '32995-issue-contents-dynamically-replaced-with-stale-version-after-saving-or-refreshing-relative-external_url-only' into 'master'
Fix incorrect ETag cache key when relative instance URL is used

Closes #32995

See merge request !11964
2017-06-07 10:31:28 +00:00
Kamil Trzciński 7adddf4996 Merge branch 'zj-read-registry-pat' into 'master'
Allow pulling container images using personal access tokens

Closes #19219

See merge request !11845
2017-06-07 09:20:57 +00:00
Adam Niedzielski 280529c7f4 Fix incorrect ETag cache key when relative instance URL is used 2017-06-07 11:15:33 +02:00
Valery Sizov 223b87d7b1 Backport Fix '/unassign' slash command 2017-06-07 09:47:26 +03:00
黄涛 20afb35d68 add bulgarian translation of cycle analytics page to I18N
Fix #33383
2017-06-07 10:10:49 +08:00
Huang Tao da474692f6 Update i18n.rb style 2017-06-07 09:51:57 +08:00
黄涛 d2bfd329e9 add portuguese brazil translation of cycle analytics page
Fix #33334
2017-06-07 09:51:56 +08:00
Douwe Maan 3a5d375e49 Fix Diff::Position#diff_file for positions on straight diffs 2017-06-06 14:48:05 -05:00
Grzegorz Bizon 96a7236bfd Merge branch 'feature/gb/migrate-pipeline-stages' into feature/gb/persist-pipeline-stages
* feature/gb/migrate-pipeline-stages: (76 commits)
  redesign caching of application settings
  Fix binary encoding error on MR diffs
  Fix missing tooltip and ARIA labels for accessibility
  Add info on using self-signed certs with Registry
  Actually clean gitlab-test path when TestEnv.set_repo_refs fails
  Introduce optimistic locking support via optional parameter last_commit_id on File Update API
  Move issuable bulk edit form into a new sidebar.
  Add PowerShell to CI variable docs
  Responsive environment tables
  Accept a username for User-level Events API
  Introduce an Events API
  Update GitLab Pages to v0.4.3
  Allow numeric pages domain
  Remove references to old settings location
  Resolve "API: Environment info missed"
  Fix Projects API spec
  Resolve "When changing project visibility setting, change other dropdowns automatically"
  Update explanation of job-level variable override to fit example
  change headings to improve SEO
  backports changed import logic from pull mirroring feature into CE
  ...
2017-06-06 21:22:19 +02:00
Paul Charlton d93352825a redesign caching of application settings 2017-06-06 16:48:10 +00:00
James Lopez 6b53add3f9 Fix binary encoding error on MR diffs 2017-06-06 16:40:07 +00:00
Z.J. van de Weg 9fcc3e5982 Fix test failures 2017-06-06 16:19:15 +02:00
Brian Neel 9bc8932390 Merge branch '29690-rotate-otp-key-base' into 'master'
Add a Rake task to aid in rotating otp_key_base

Closes #29690

See merge request !11881
2017-06-06 03:24:10 +00:00
Nick Thomas b2800ee0c7 Add a Rake task to aid in rotating otp_key_base 2017-06-05 22:17:52 +01:00
Douwe Maan 5578506eb1 Merge branch 'mk-fix-git-over-http-rejections' into 'master'
Fix Git-over-HTTP rejections

See merge request !11398
2017-06-05 19:56:19 +00:00
Douwe Maan 059b9627df Merge branch 'added_chinese_for_i18n' into 'master'
Add Chinese translation of Cycle Analytics Page to I18N

See merge request !11644
2017-06-05 19:54:37 +00:00
Douwe Maan 07e7ce31e3 Merge branch '31983-increase-merge-request-diff-file-size-limit-for-default-toggle-opening' into 'master'
Increase diff limits to 100 KB for collapse and 200 KB overall

Closes #31983

See merge request !11875
2017-06-05 13:58:54 +00:00
Michael Kozono d7eee7332b Extract and memoize `user_access`
Because it is sometimes never used.
2017-06-05 05:32:26 -07:00
Michael Kozono 0e3cfc75a3 Remove GitAccessStatus (no longer needed) 2017-06-05 05:32:26 -07:00
Michael Kozono 0a0f66c816 Refactor to remove a special case 2017-06-05 05:32:26 -07:00
Michael Kozono 7d469cf1c1 Fix would-be regression
57e3e942de

I changed it to a separate condition rather than depending on the order of the case-when statements to prevent this mistake again.
2017-06-05 05:32:26 -07:00
Michael Kozono e8972c1190 Clarify error messages
And refactor to self-document a little better.
2017-06-05 05:32:26 -07:00
Michael Kozono 23d37382da Refactor to let GitAccess errors bubble up
No external behavior change.

This allows `GitHttpController` to set the HTTP status based on the type of error. Alternatively, we could have added an attribute to GitAccessStatus, but this pattern seemed appropriate.
2017-06-05 05:32:26 -07:00
Michael Kozono bad08fbea2 Move CI access logic into GitAccess 2017-06-05 05:32:26 -07:00
Michael Kozono a738a446f4 Check disabled commands in GitAccess instead 2017-06-05 05:32:26 -07:00
Michael Kozono ff8a053d5d Fix Git over HTTP spec
* The spec has 7 failures at this point
* Specify rendered error messages
* Render the GitAccess message rather than “Access denied”
* Render the Not Found message provided by GitAccess, instead of a custom one
* Expect GitAccess to check the config for whether Git-over-HTTP pull or push is disabled, rather than doing it in the controller
* Add more thorough testing for authentication
* Dried up a lot of tests
* Fixed some broken tests
2017-06-05 05:32:26 -07:00
Grzegorz Bizon 79380fe5fb Merge branch 'master' into feature/gb/persist-pipeline-stages
* master: (524 commits)
  Improve user experience around slash commands in instant comments
  Fix LFS timeouts when trying to save large files
  retryable? is now available for CommitStatus
  Resolve "Documentation of `.gitlab-ci.yml` states incorrect example for variables"
  Fix test failures
  Add slugify project path to CI enviroment variables
  Fixed typo: craeted -> created
  32118 Make New environment empty state btn lowercase
  Expose import_status in Projects API
  32832 Remove overflow from comment form for confidential issues and vertically aligns confidential issue icon
  Fix test failures
  Allow manual bypass of auto_sign_in_with_provider
  Fix keys seed
  Allow users to be hard-deleted from the API
  fixup some classnames and media queries
  Enable the Style/PreferredHashMethods cop
  Lint our factories creation in addition to their build
  Don’t schedule workers from inside transactions
  Allow scheduling from after_commit hooks
  Forbid Sidekiq scheduling in transactions
  ...

Conflicts:
	app/serializers/pipeline_entity.rb
	db/schema.rb
	spec/factories/ci/stages.rb
	spec/lib/gitlab/import_export/safe_model_attributes.yml
	spec/services/ci/create_pipeline_service_spec.rb
	spec/spec_helper.rb
2017-06-05 12:51:59 +02:00
Grzegorz Bizon 3801a0df80 Export pipeline stages in import/export feature 2017-06-05 12:46:57 +02:00
Z.J. van de Weg 0b81b5ace0 Create read_registry scope with JWT auth
This is the first commit doing mainly 3 things:
1. create a new scope and allow users to use it
2. Have the JWTController respond correctly on this
3. Updates documentation to suggest usage of PATs

There is one gotcha, there will be no support for impersonation tokens, as this
seems not needed.

Fixes gitlab-org/gitlab-ce#19219
2017-06-05 12:26:49 +02:00