Commit Graph

58 Commits

Author SHA1 Message Date
Eric Eastwood d2e5313ad8 Switch issue_show to Axios 2018-01-02 17:59:04 -06:00
Phil Hughes e0bbadc2d2
use exported methods instead of gl.utils 2017-12-08 08:54:51 +00:00
Eric Eastwood 078ba6a2d6 Fix issue comment submit button disabled on GFM paste
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/40373

When copying some text from another note and paste,
it goes through `copy_as_gfm` `paste` handler
that calls `e.preventDefault()` which stops things.
But then when inserting the text, we manually trigger
an `input` event with jQuery which doesn't seem to be
picked up by Vue `v-model`.

Using copy/paste trick from https://stackoverflow.com/a/41046276/796832
2017-11-28 10:53:01 -06:00
Filipa Lacerda 4563156256 Improve environments performance 2017-11-23 12:04:03 +00:00
Filipa Lacerda be4abe7719 Stops page reload when changing tabs or pages - uses API requests instead 2017-11-14 15:35:29 +00:00
Filipa Lacerda 1ff3f1a4f7 Export text utils as ES6 modules 2017-11-13 09:11:54 +00:00
Clement Ho 13b299f4ff Add ability to pass class name to spriteIcon helper 2017-10-12 12:43:00 -05:00
Eric Eastwood 03cd536b54 Cleanup data-page attribute after each Karma test
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/38871
2017-10-11 11:02:55 -05:00
Phil Hughes 333cb069af
Fixed anchored content not being scrolled into view
Correctly scrolls anchored content into view when the user loads the
page. This is most obvious when the user loads a link note in a
merge request & the page does not scroll down to the note.

Closes #38326
2017-09-29 09:24:56 +01:00
Tim Zallmann 55f772bb98 Resolve "Better SVG Usage in the Frontend" 2017-09-22 08:39:47 +00:00
Filipa Lacerda 8784d362ab
Exports all the methods in the same place 2017-09-18 18:02:18 +01:00
Filipa Lacerda 14a932f180
Fix context for jquery event
Remove unused function
2017-09-15 14:24:46 +01:00
Filipa Lacerda 96e6fc70b4 Import modules instead of using the ones in global namespace
Removes set favicon related methods from global scope
Improves test related with favicon

Removes convertPermissionToBoolean from global scope.
Adds tests for convertPermissionToBoolean - were non existant

Removes setParamInURL from gl.utils

Removes parseIntPagination from gl.utils namespace

Remove normalizeCRLFHeaders from gl.utils namespace

Removes normalizeHeaders from gl.utils namespace

Use gl.utils for filtered search

Fix bad import

Fix broken test by cleaning window.history namespace

Adds changelog
2017-09-09 09:54:27 +01:00
Filipa Lacerda 6a1b84c7b4 Use modules in common utils 2017-09-09 09:54:24 +01:00
Douwe Maan fbe82e4cd9 Merge branch 'master' into issue-discussions-refactor
# Conflicts:
#	package.json
2017-08-23 11:31:17 +02:00
Fatih Acet 46ed6cd8ca IssueNotesRefactor: Fix eslint errors. 2017-08-23 01:19:28 +03:00
Fatih Acet 48acfb5c05 IssueNotesRefactor: Show Cmd+Enter to comment tooltip. 2017-08-21 21:48:09 +03:00
Mike Greiling d4cb1ec9e9 fix unnecessarily long gl.utils.backOff test 2017-08-18 03:01:23 -05:00
Filipa Lacerda e4f8aa719b Merge branch 'master' into issue-discussions-refactor
* master: (162 commits)
  Since mysql is not a priority anymore, test it less
  Add container registry and spam logs icons
  Fix different Markdown styles
  Backport to CE for:
  Make new dropdown dividers full width
  Bump GITLAB_SHELL_VERSION and GITALY_VERSION to support unhiding refs
  Install yarn via apt in update guides
  Use long curl options
  Remove monkey-patched Array.prototype.first() and last() methods
  Openshift Getting Started
  35659 Rename Pipelines tab to CI / CD in new navigation
  Don't bother going through an entire Banzai pipeline for empty text
  Add active state for pipelines settings on old nav
  Bump rspec to 3.6.0
  Resolve "Specific Async Script Loading by using a Page Variable"
  Revert "Merge branch 'rs-warm-capybara-only-in-ci' into 'master'"
  another rubocop style fix
  Use mixin for new dropdown style
  Migrate Repository#last_commit_for_path to Gitaly
  Migrate blame loading to Gitaly
  ...
2017-08-04 19:38:37 +01:00
Phil Hughes d86cbe6941
fixed alignment in button
correctly scroll to element with sticky height offset
2017-08-03 17:03:49 +01:00
Fatih Acet 3c2d98f4c2 IssueNotesRefactor: Address MR comments. 2017-07-21 22:35:26 +03:00
Fatih Acet 993936fbd0 IssueNotesRefactor: Implement jumping to target note. 2017-07-21 22:35:25 +03:00
Annabel Dunstone Gray 588d55646d Fix offset for fixed nav 2017-06-23 08:24:15 +00:00
Alfredo Sumaran 323a326c73 Improve pagination when searching or filtering
[ci skip]
2017-06-06 04:31:40 -05:00
Douwe Maan 7e0a4c5e57 Don't wrap pasted code when it's already inside code tags 2017-05-19 07:26:28 -05:00
Phil Hughes 4579056476 Fixed tests with params being wrong 2017-05-15 14:03:52 +01:00
Phil Hughes 477be05661 Fixed issue boards not filtering when URL params are encoded
Closes #32084
2017-05-12 09:27:21 +01:00
Kushal Pandya 645593e5af Add instant comments support 2017-05-05 10:57:29 +00:00
Simon Knox ae2e0b6915 fix inline diff copying in firefox 2017-04-21 07:43:42 +10:00
Filipa Lacerda c15a2d7ffd Merge branch 'use-favicon-full-path-for-pipeline-status-favicon' into 'master'
Use favicon full path

See merge request !10676
2017-04-18 16:22:08 +00:00
barthc 04e2dde538 frontend prevent authored votes 2017-04-14 09:33:28 +01:00
Luke "Jared" Bennett b24cb99856
Updated specs 2017-04-13 12:50:03 +01:00
Luke "Jared" Bennett deb56f21cb
[ci skip] Use favicon full path 2017-04-13 11:09:20 +01:00
Kushal Pandya 28a4e9d8d0 Show CI status as Favicon on Pipelines, Job and MR pages 2017-04-06 10:40:39 +00:00
Filipa Lacerda 76b2fa3eeb Fixes method not replacing URL parameters correctly 2017-04-03 10:40:30 +01:00
Luke "Jared" Bennett c5eb5aa998 group links select2 infinite scroll 2017-03-30 12:14:32 +00:00
winniehell 572f9782d5 Remove .es6 from file extensions (!9241) 2017-03-05 21:22:40 +01:00
Regis 55df55367f move param helper to common utils 2017-01-09 10:26:43 -07:00
Fatih Acet 36412ee2c2 Fix review comments. 2017-01-05 00:44:00 +03:00
Fatih Acet 09fc4f557b Review fixes. 2017-01-04 23:37:54 +03:00
Fatih Acet 9ae7e99a09 Use gl.utils.isInViewport and improve gl.utils.animateToElement. 2017-01-04 23:37:54 +03:00
Fatih Acet 0143573dd5 Separate edit form in Changes and Discussions tab.
if we are in the Merge Requests page, this change will clone existing note-edit-form and add a mr-discussion-edit-form class to cloned element so we will have two note-edit-form in place. One for Discussions tab one for Changes tab.

For MR page, we basically need two note-edit-form because you may want to edit your comment in both tabs at the same time and we shouldn't remove or discard note-edit-form in other tab.
2017-01-04 23:37:54 +03:00
Fatih Acet 2193ccec3d Fix warning styling for responsive design. 2017-01-04 23:37:54 +03:00
Fatih Acet 1100320b0c Refactor discussion edit widget to have only one at a time. 2017-01-04 23:37:54 +03:00
Kushal Pandya 6fe5bb40b6 Add `isInViewport` 2016-12-21 13:16:17 +05:30
Steffen Rauh 0966c6d2c6 Fix compatibility with Internet Explorer 11 for merge requests 2016-12-03 22:40:18 +01:00
winniehell f90b6200e4 Clean up common_utils.js (!7318) 2016-12-01 23:16:09 +01:00
Mike Greiling 131a04d796 remove underscore from user-content id namespace 2016-11-30 15:28:11 -06:00
Mike Greiling ff2026f40e add transparent namespace to all user-generated anchors in GitLab flavored markdown 2016-11-30 15:28:10 -06:00
Mike Greiling ffd2823261 remove duplicate functionality (bad merge conflict resolution?) 2016-11-30 15:28:10 -06:00