966b1128d8
WIP: refactor the first-contributor to Issuable
...
this will remove the need make N queries (per-note) at the
cost of having to mark notes with an attribute
this opens up the possibility for other special roles for notes
2017-09-06 09:00:57 -04:00
fe13f11041
Create and use project path helpers that only need a project, no namespace
2017-07-05 11:11:59 -05:00
8e5bf9d8dc
Use the new check_project_feature_available! method in project controllers
2017-06-21 10:56:45 +01:00
563ea34692
Merge branch '12910-snippets-description' into 'master'
...
Support descriptions for snippets
Closes #31894
See merge request !11071
2017-06-07 09:26:48 +00:00
a544e46bb0
Add a rubocop rule to check if a method 'redirect_to' is used without explicitly set 'status' in 'destroy' actions of controllers
2017-06-07 09:45:16 +11:00
4464c22d6d
Support descriptions for snippets
2017-05-31 07:17:03 +02:00
aed0387f97
Consistent diff and blob size limit names
2017-05-29 17:02:02 -05:00
ad309f5d11
Merge branch 'snippets-finder-visibility' into 'security'
...
Refactor snippets finder & dont return internal snippets for external users
See merge request !2094
2017-05-10 16:48:18 +02:00
60ebd101d0
Use blob viewers for snippets
2017-04-30 11:21:20 -05:00
21e10888c3
Address review comments
2017-04-05 17:44:14 +01:00
08bbb9fce6
Add option to start a new discussion on an MR
2017-04-05 17:44:14 +01:00
2ace39f242
Spam check and reCAPTCHA improvements
2017-02-21 13:32:49 -03:00
c9d687d6fe
Download snippets with LF line-endings by default
2017-02-20 07:24:03 +01:00
c63194ce6f
Check public snippets for spam
...
Apply the same spam checks to public snippets (either personal snippets
that are public, or public snippets on public projects) as to issues on
public projects.
2017-02-02 10:23:51 +00:00
805bbe8893
adds specs for respective behaviour
2016-12-21 23:53:24 +00:00
9b66aa6e04
Prevent empty pagination when list is not empty
2016-12-21 23:53:24 +00:00
54a1193d79
add scope filters to project snippets page
2016-12-10 00:57:23 -06:00
412ff80b7b
Start Frontend work, fix routing problem
2016-09-19 19:50:40 +03:00
892dea6771
Project tools visibility level
2016-09-01 11:47:59 -03:00
d71983f599
Fix snippets comments not displayed
...
The issue was that @notes were not passed to Banzai::NoteRenderer.render
in Projects::SnippetsController#show. This was forgotten in d470f3d1
2016-07-01 18:39:19 +02:00
4f07c0a107
Ensure project snippets have their own access level
2016-03-25 18:51:17 +01:00
f4bdefdff1
Ensure private project snippets are not viewable by unauthorized people
...
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/14607 .
2016-03-25 12:33:42 +01:00
085538c2bd
Use the configured Kaminari "per page" default
2016-03-19 17:37:54 -04:00
f7240e03a6
Fix autocomplete for new issues/MRs/snippets
2016-01-15 11:29:53 +01:00
946f00ed7f
Update style of snippets pages
2015-10-18 13:03:26 +02:00
daa90e1182
Fix 500 error when try to create project snippet without content
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2015-08-26 23:59:52 +02:00
d63371ad78
Update controller filters
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2015-06-26 16:44:21 +02:00
342d553709
Rename abilities to correspond contoller/model action names
...
write_ was renamed to create_
modify_ was renamed to update_
So now in update action we have next code
def create
can?(current_user, :create_issue, @issue)
end
def update
can?(current_user, :update_issue, @issue)
end
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2015-06-26 15:55:56 +02:00
5a4ebfb47a
Fixed the Rails/ActionFilter cop
...
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
2015-04-20 15:39:37 +02:00
928fc94c3d
Enforce restricted visibilities for snippets
...
Add new service classes to create and update project and personal
snippets. These classes are responsible for enforcing restricted
visibility settings for non-admin users.
2015-03-08 17:57:08 -06:00
76aad9b76e
Upgrade to Rails 4.1.9
...
Make the following changes to deal with new behavior in Rails 4.1.2:
* Use nested resources to avoid slashes in arguments to path helpers.
2015-02-14 11:09:23 -07:00
118bd7178b
Sanitize snippet file name in raw headers
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-12-12 13:28:48 +02:00
47f539f5a6
Snippets: public/internal/private
2014-10-09 17:09:53 +03:00
1b14864549
Set charset encoding to UTF-8 for snippets
...
Fixes #2678
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
2014-08-16 14:58:53 +02:00
2acde87e0d
Project hook, milestone, snippet strong params
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-06-26 18:51:11 +03:00
f554aa38d5
Update commentable controllers with new note vars
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2013-12-25 22:32:48 +02:00
f7e7dc7ebb
Make note anchors actually work
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2013-12-25 13:32:43 +02:00
573d367be5
Modify permissions for project and group
...
* Hooks and team pages allowed only for masters/owners
* Group page allowed for admin
* Corrent authentication for Projects controller
* Hide some project elements from visitor
2013-09-25 14:05:35 +03:00
2ed7cbfba4
Move projects controllers/views in Projects module
2013-06-23 19:47:22 +03:00
0359f1d9ec
Codestyle improved
2013-03-25 16:28:39 +04:00
e3351287b4
Permissions for Project Snippet fixed
2013-03-25 14:22:14 +04:00
d4543eb5a7
Tests fixed
2013-03-25 11:20:14 +04:00
5b35000f16
Snippets feature refactored. Tests now use spinach
2013-03-24 22:31:14 +04:00
7d2fbe6bd8
Project Snippets now part of project
2013-03-24 19:12:28 +04:00
b49cfbc1d5
Project snippets moved to /projects
2013-03-23 23:17:25 +04:00
cc869d5dc1
Private field added to snippet
2013-03-23 22:14:37 +04:00
micael.bergeron
Douwe Maan
Nick Thomas
Phil Hughes
blackst0ne
Jarka Kadlecova
Douwe Maan
Oswaldo Ferreira
Sean McGivern
Tiago Botelho
Mike Greiling
Z.J. van de Weg
Felipe Artur
Rémy Coutable
Robert Speicher
Yorick Peterse
Dmitriy Zaporozhets
Jeroen van Baarsen
Vinnie Okada
Valery Sizov
Andrew8xx8