Commit Graph

264 Commits

Author SHA1 Message Date
GitLab Bot 6755df108b Add latest changes from gitlab-org/gitlab@master 2020-01-21 00:08:46 +00:00
GitLab Bot aa0f0e9921 Add latest changes from gitlab-org/gitlab@master 2020-01-16 18:08:46 +00:00
GitLab Bot 0ba3a054d2 Add latest changes from gitlab-org/gitlab@master 2020-01-10 09:07:49 +00:00
GitLab Bot 59026a49b3 Add latest changes from gitlab-org/gitlab@master 2019-12-27 09:07:37 +00:00
GitLab Bot 6b8040dc25 Add latest changes from gitlab-org/gitlab@master 2019-12-11 09:08:12 +00:00
GitLab Bot 93c6764dac Add latest changes from gitlab-org/gitlab@master 2019-12-09 12:07:58 +00:00
GitLab Bot 99ddca0d88 Add latest changes from gitlab-org/gitlab@master 2019-12-06 21:07:54 +00:00
GitLab Bot 63894d59ab Add latest changes from gitlab-org/gitlab@master 2019-12-06 12:06:21 +00:00
GitLab Bot 6a7cc8c147 Add latest changes from gitlab-org/gitlab@master 2019-12-05 18:07:51 +00:00
GitLab Bot 8723197387 Add latest changes from gitlab-org/gitlab@master 2019-12-05 12:07:43 +00:00
GitLab Bot bd8a202da6 Add latest changes from gitlab-org/gitlab@master 2019-11-27 00:06:23 +00:00
GitLab Bot 157f9a451a Add latest changes from gitlab-org/gitlab@master 2019-11-22 00:06:08 +00:00
GitLab Bot 0a6ffb540e Add latest changes from gitlab-org/gitlab@master 2019-11-21 12:06:40 +00:00
GitLab Bot 5ff1b520ba Add latest changes from gitlab-org/gitlab@master 2019-10-14 09:07:54 +00:00
GitLab Bot 0d46bf0638 Add latest changes from gitlab-org/gitlab@master 2019-10-04 12:06:14 +00:00
GitLab Bot 2ed368929a Add latest changes from gitlab-org/gitlab@master 2019-09-24 18:06:05 +00:00
Nathan Friend 11f1305ec7
Make MR pipeline widget text more descriptive (CE)
This change updates the text of the pipeline widget that appears on the
merge request page. The text has been made more consistent between
different types of pipelines; this makes the front-end implementation
simpler and more maintainable.  In addition, the type of pipeline is
(i.e. regular pipeline, merge request pipeline, detached pipeline)
included in the text, making this type more obvious to the end user.

Some information has been removed from the widget as part of this
change; however, any information that was removed already appears
elsewhere on the merge request page.
2019-09-11 07:27:58 -03:00
Paul Slaughter b1af2a78a2 Merge branch 'ce-13479-rename-atmtwps-to-mtwps' into 'master'
CE backport for gitlab-org/gitlab-ee!15535: Resolve "Rename `ATMTWPS` to `MTWPS` in code"

See merge request gitlab-org/gitlab-ce!32112
2019-08-30 06:45:15 +00:00
Illya Klymov 6bbba7017b Refactored Karma spec to Jest for mr_widget_auto_merge_failed 2019-08-27 18:50:22 +03:00
Nathan Friend 37e4f51400
Rename ATMTWPS to MTWPS (CE)
This commit does a find-and-replace from ATMTWPS -> MTWPS.
2019-08-22 14:55:55 -03:00
Igor 6a385b60f8 Remove mergeTrain from FE since it's used only in EE 2019-08-22 13:50:19 +00:00
Ezekiel Kigbo b7e6c898c7 Resolve "HTML code shown in merge request"
- Fixes double escaped text in `mr_widget_rebase.vue`
2019-08-21 14:47:04 +00:00
Nathan Friend 896af1acbd
Add merge train helper text to MR widget (CE)
This commit adds a helper text that describes what will happen when a
user clicks the "Start/Add to merge train when pipeline succeeds"
button.  This text appears at the bottom of the merge request widget.

In addition, this commit renames the "merge_train_info" component to
"merge_train_position_indicator" to avoid ambiguity with the
"merge_train_helper_text" component.
2019-08-14 17:13:09 -04:00
Nathan Friend eade5c067d
Fix merge button dropdown (CE)
This commit fixes an issue that was causing the merge button dropdown
trigger to be shown even if the dropdown itself was hidden. This commit
also fixes an issue that caused the "Merge Immediately" option not to be
available when merge trains were enabled.
2019-08-12 12:31:47 -04:00
Tanya Pazitny 9658e5ec33 Change qa-* class references to js-* for squash-checkbox 2019-07-29 19:20:28 +00:00
Lukas 'Eipi' Eipert 6df22f17d2 Karma: Fix css selector for loading icon
The GitLab UI update changed the spinner selector from `spinner` to
`gl-spinner`, so we need to update it, so that our tests won't fail.
2019-07-26 09:40:17 +00:00
Tim Zallmann b9e52612fe Updates on success of an MR the count on top and in other tabs
New API endpoint for merge request count
Updates all open tabs at the same time with one call
Restructured API response

API response changed to 401 if no current_user

Added API + JS specs

Fix for Static Check

Updated Count on Open/Close, Assign/Unassign of MR's

Checking if MR Count is refreshed

Added # frozen_string_literal: true to spec

Added Changelog
2019-07-09 08:44:19 +00:00
Michel Engelen f4de2453a0 updated Karma test for changed strings in mr-widget state 2019-07-02 14:29:54 +02:00
Ash McKenzie 1012cfb0b7 Merge branch 'id-extract-widget-into-different-request' into 'master'
Extract MR's widget into a separate request

Closes #62723

See merge request gitlab-org/gitlab-ce!29979
2019-06-28 10:01:30 +00:00
Igor Drozdov 07559fda51 Extract MR's widget into a separate endpoint
This commits extracts /merge_requests/1.json?serializer=widget
Into a separate /merge_requests/1/widget.json endpoint
This will allow to use caching for this request
2019-06-28 10:52:48 +03:00
Filipa Lacerda 5e6448f5fa Removes EE differences 2019-06-26 16:47:30 +01:00
Mike Greiling 55a5ced463
Upgrade prettier to latest (v1.18.2)
Upgrades prettier to the latest version, and auto-corrects files with
yarn prettier-all-save

The diffs all seem to stem from formatting changes in brackets within
template literals. Nothing major.

Relevant changelogs here:

https://prettier.io/blog/2019/04/12/1.17.0.html
https://prettier.io/blog/2019/06/06/1.18.0.html
2019-06-21 12:36:03 -05:00
Kamil Trzciński 2d9e0f3ffb Revert "Merge branch '57414-show-pipeline-iid-in-pipelines-page' into 'master'"
This reverts merge request !26853
2019-06-14 13:17:18 +00:00
Fatih Acet d78a4465fa Merge branch 'sh-fix-resolve-button-not-available' into 'master'
Fix "Resolve conflicts" button not appearing for some users

Closes #47954

See merge request gitlab-org/gitlab-ce!29535
2019-06-12 17:51:32 +00:00
Lin Jen-Shin d8f4779c7f Merge branch 'ce-remove-merge-request-pipeline-checkes' into 'master'
CE backport for gitlab-org/gitlab-ee!12309: Remove merge request pipeline check in mergeable method

See merge request gitlab-org/gitlab-ce!29074
2019-06-12 09:41:54 +00:00
Nathan Friend 059b3e369d
Remove "target branch advanced" warning from FE code (CE)
Removes the "target branch advanced" warning from the frontend
as it is no longer needed due to the new merge trains feature.
2019-06-12 16:23:34 +08:00
Stan Hu 1405b9cd50 Fix "Resolve conflicts" button not appearing for some users
Previously the frontend assumed that the user had to be able to merge to
that project in order to resolve conflicts. However, this is overly
restrictive, as the user only has to be able to push to the source
branch. In fact, appending the text /conflicts to the merge request
would bring up the conflict resolution page.

This confusion happens when a project contains a protected branch that
only allows maintainers to push. Users with Developer access no longer
have permission to merge, but they still can create branches in that
project.

To fix this issue, we now loosen the permission check for the "Resolve
conflicts" button and only check for access to push to the source
branch. This is consistent with what the backend does in
MergeRequests::Conflicts::ListService#can_be_resolved_by?.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/47954
2019-06-11 23:18:30 -07:00
Nathan Friend 35ae9d8a74
Add merge train support to MR merge button (CE)
This commit updates the merge request widget's "Merge" button to
support merge trains.
2019-06-11 09:27:51 -05:00
Paul Slaughter c1bb78a0ce FE: Remove legacy approval feature in MR files 2019-06-04 16:57:30 +08:00
Nathan Friend 84e550fad9 Fix frontend tests related to autoMergeStrategy
A few minor frontend changes to complete the refactoring
from MWPS to the more generic autoMergeStrategy.
2019-06-03 13:15:31 +07:00
Shinya Maeda d4b4693663 Abstract auto merge processes
We have one auto merge strategy today - Merge When Pipeline
Succeeds.

In order to add more strategies for Merge Train feature,
we abstract the architecture to be more extensible.

Removed arguments

Fix spec
2019-06-03 13:15:29 +07:00
Mike Scott 852738a498 Add Pipeline IID to views
* Add Pipeline IID to MR's
* Add Pipeline IID to commit box
* Add Pipeline IID to builds page
* Add Pipeline IID to job sidebar
* Add Pipeline IID to header on view pipeline pages
* Add changelog entry
* Update tests
2019-05-30 09:32:20 +00:00
Mike Greiling 96725938c0 Merge branch 'fe-rename-vue-component-helper-ce' into 'master'
[CE Port] Rename vue_component_helper to text_helper

See merge request gitlab-org/gitlab-ce!28358
2019-05-20 20:06:34 +00:00
Sarah Groff Hennigh-Palermo 68fd2bdd74 Add backport changes
Adds backport changes for ee
2019-05-20 17:08:37 +00:00
Paul Slaughter 878e69299b
Rename vue_component_helper to text_helper
**Why?**
This file only contains a few text based helper functions.
It has nothing to do with Vue or Vue components.
2019-05-16 06:40:18 -05:00
Filipa Lacerda 61cb27b01d
Fixes empty block in MR widget
This commit prevents the pipeline block to be rendered
when no pipeline information is provided
2019-05-07 16:39:02 +02:00
Nathan Friend ca6e946f0f
Only show message when MR is open
This commit fixes the bug that was causing the "target branch has
"advanced" error message to display after an MR was closed.
2019-04-24 12:19:15 -03:00
Nathan Friend 500fd22675
Add sync: false to fix Karma tests 2019-04-16 13:40:34 -03:00
Filipa Lacerda cd509d991e Merge branch 'nfriend-update-merge-request-widget-for-post-merge-pipelines' into 'master'
Update merge request widget to accommodate post-merge pipelines

See merge request gitlab-org/gitlab-ce!25983
2019-04-16 14:21:50 +00:00
George Tsiolis 579fa8b8ec Rename CI related selectors 2019-04-16 12:57:07 +03:00