Commit Graph

18 Commits

Author SHA1 Message Date
Alexis Reigel 943827b39a
option to make variables protected by default 2018-11-29 15:04:59 +01:00
Winnie Hellmann 8ef5115795 Replace convertPermissionToBoolean with parseBoolean 2018-11-27 09:18:48 +01:00
Hiroyuki Sato b689b20f20 Fix typos occured to occurred 2018-11-16 00:34:24 +09:00
Marcel Amirault 14fc739c94 Renaming Secret Variables in the codebase 2018-10-30 08:49:26 +00:00
Mike Greiling dfb0824346 Prettify all the things (part 7) 2018-10-24 19:17:03 +00:00
Clement Ho db08a9d237 Use dropdown-menu instead of dropdown selector 2018-05-22 17:34:43 -05:00
Clement Ho 1c0b943fab Scope to .dropdown 2018-05-22 17:27:53 -05:00
Clement Ho 601c485cbc Auto close cloned dropdowns for ci variable list
The flow around Bootstrap v4 dropdown and glDropdown changed which resulted in new variable rows to having a blank dropdown open,

 - With BS3: opened dropdown -> clone and insert new row -> hide old dropdown -> hide new dropdown
 - With BS4: opened dropdown -> clone and insert new row -> hide old dropdown

We are fixing this by cleaning up the dirty row clone  class so we don't have to rely on magic events hiding both the old and new dropdowns
2018-05-22 17:12:55 -05:00
Clement Ho e64379ad47 Use hide class for ci variables list 2018-04-25 11:04:05 -05:00
Clement Ho 705d7f703b [skip ci] Use toggleClass instead of toggle 2018-04-12 14:13:50 -05:00
Matija Čupić 05103f080c
Make Variable key not secret 2018-03-22 12:08:16 +01:00
Matija Čupić 2b4e5c938b
Use secret_key and secret_value in CI variable frontend 2018-03-17 16:33:40 +01:00
Mike Greiling f248be7257
require jQuery to be explicitly imported 2018-03-09 15:18:09 -06:00
Clement Ho 975dc69ec6 Merge branch '42929-hide-new-variable-values' into 'master'
Hide CI secret variable values on save

Closes #42929

See merge request gitlab-org/gitlab-ce!17044
2018-02-15 22:16:37 +00:00
Eric Eastwood c6b2ff8a21 Hide CI secret variable values on save
See https://gitlab.com/gitlab-org/gitlab-ce/issues/42928
2018-02-14 14:48:26 -06:00
Eric Eastwood b60a39f260 Default CI variables to unprotected
See https://gitlab.com/gitlab-org/gitlab-ce/issues/42928
2018-02-09 12:18:43 -06:00
Eric Eastwood 3be32027b6 Use dynamic variable list in scheduled pipelines and group/project CI secret variables
See https://gitlab.com/gitlab-org/gitlab-ce/issues/39118

Conflicts:
	app/views/ci/variables/_form.html.haml
	app/views/ci/variables/_table.html.haml
	ee/app/views/ci/variables/_environment_scope.html.haml
	spec/javascripts/ci_variable_list/ci_variable_list_ee_spec.js
	spec/javascripts/fixtures/projects.rb
2018-02-05 13:09:29 -06:00
Eric Eastwood 332aa756d2 Refactor CI variable list code for usage with CI/CD settings page secret variables
Part of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/4110
2018-01-31 13:18:32 -06:00