12edecd002
Add headers to files in the tree list on merge requests
...
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54807
2019-01-08 09:31:23 +00:00
33cfeea176
Dryed code in commit_item by adding another computed prop
2019-01-07 11:04:59 +01:00
1484a7eb7d
Added User Popovers to Commit Items and Member Lists
2019-01-04 16:34:01 +01:00
ef304611ad
Fix commit SHA not showing in merge request compare dropdown
...
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/17011
in GitLab 11.1 refactored the merge request diff comparison
functionality but omitted the commit SHA due to a change in
the API (truncated_commit_sha -> short_commit_sha).
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55822
2018-12-31 09:18:29 -08:00
5a3e6fdff9
Fixing image lfs bug and also displaying text lfs
...
This commit, introduced in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23812 ,
fixes a problem creating a displaying image diff notes when the image
is stored in LFS. The main problem was that `Gitlab::Diff::File` was
returning an invalid valid in `text?` for this kind of files.
It also fixes a rendering problem with other LFS files, like text
ones. They LFS pointer shouldn't be shown when LFS is enabled
for the project, but they were.
2018-12-27 16:51:07 +01:00
70ba4ba285
Merge branch '51606-expanding-a-diff-while-having-an-open-comment-form-will-always-scroll-down-to-the-comment' into 'master'
...
Resolve "Expanding a diff while having an open comment form will always scroll down to the comment"
Closes #51606
See merge request gitlab-org/gitlab-ce!23849
2018-12-20 09:32:56 +00:00
9c18798275
Utilize :key to minimize extra rerenders
...
The diff notes automatically focus on mount, and when using the index
(as opposed to line_code) for the v-bind:key, the comment form gets
unnecessarily remounted, and therefore refocused.
2018-12-17 20:25:41 -05:00
2f4fe2b503
Merge branch 'inline-duplicated-discussions' into 'master'
...
Fixed duplicated inline diff discussions
Closes #55388
See merge request gitlab-org/gitlab-ce!23843
2018-12-17 12:51:50 +00:00
8d2e1b724b
Merge branch '54786-mr-empty-file-display' into 'master'
...
Display empty files properly on MR diffs
Closes #54786
See merge request gitlab-org/gitlab-ce!23671
2018-12-15 12:21:54 +00:00
e64c9c2112
Fixed duplicated inline diff discussions
...
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55388
2018-12-14 21:32:41 +00:00
9f9eb03f3d
Fix diff table rendering for empty files and improve tests
2018-12-13 23:52:31 -05:00
ed3034bbb7
Allow suggesting single line changes in diffs
2018-12-13 19:17:19 +00:00
ee2f3cac35
Fix diff changes empty state
...
The empty state now only gets shown when no files exist in the branch.
If the user is reviewing 2 versions with no files, we don't show the state.
Refactors the diff app spec to use Vue test utils.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48635
2018-12-13 10:57:45 +00:00
7a5c9f8aa8
Fixed parallel discussions throwing an error
2018-12-13 08:28:13 +00:00
4d2448e03a
Add tests and move empty file message into own component
2018-12-13 01:49:32 -05:00
4ae1591b97
Move empty file message to diff_content component
2018-12-12 23:07:49 -05:00
210e90dfce
Fixed notes not being applied to diff lines
...
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55248 , https://gitlab.com/gitlab-org/gitlab-ce/issues/55245
2018-12-12 19:29:48 +00:00
e6a3898e90
Fix Prettier formatting and add MR to changelog
2018-12-11 23:49:04 -05:00
05dcb2dd76
Display empty files properly on MR diffs
2018-12-11 23:49:04 -05:00
85daddbec9
Resolve "Navigating unresolved discussions on Merge Request page"
2018-12-08 07:19:03 +00:00
7c4e996c74
Merge branch 'winh-merge-request-diff-discussion-commit-id' into 'master'
...
Pass commit when posting diff discussions
See merge request gitlab-org/gitlab-ce!23371
2018-12-07 09:06:14 +00:00
2ed65be1c3
Fixed renamed and mode changed diff viewers
...
Renders mode changed and renamed file merge request diff
viewers on the frontend.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52607
2018-12-06 14:39:29 +00:00
e7439c3104
Pass commit when posting diff discussions
2018-12-05 22:36:51 +01:00
cfe484795d
Merge branch 'diff-expand-commit-file' into 'master'
...
Fixed expanding diff commit files
Closes #50662
See merge request gitlab-org/gitlab-ce!23591
2018-12-05 18:04:35 +00:00
d3a8fb6e79
Fixed expanding diff commit files
...
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/50662
2018-12-05 14:12:51 +00:00
6dfede5a6d
Fixed multiple discussions getting added to diff lines
...
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/8195
2018-12-05 11:42:41 +00:00
2cd710732e
Merge branch 'expand-diff-bug' into 'master'
...
Fixed diff files not expanding
Closes #54868
See merge request gitlab-org/gitlab-ce!23555
2018-12-05 09:11:31 +00:00
9afc3069b0
Fixed diff files not expanding
...
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54868
2018-12-04 17:51:57 +00:00
7aa8803083
Updated variable name to forceExpanded
2018-12-04 13:27:18 +00:00
b8ee8c2787
Fixed multiple diff line discussions not expanding
...
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53600
2018-12-04 10:58:02 +00:00
44a0121ad4
Resolve "Merge request refactor does not highlight selected line"
2018-11-30 08:48:47 +00:00
822fa649eb
Merge branch 'discussion-perf-fixes' into 'master'
...
Improve discussion rendering performance
Closes #51506
See merge request gitlab-org/gitlab-ce!22935
2018-11-28 09:45:36 +00:00
adf8ad9eee
Improve discussion rendering performance
...
Improve the renderign of new and existing discussions
by reducing the number of watchers on each object & array.
Previously every discussion change would trigger an update for every
discussion component.
Also tidied up some components to get them closer to our docs.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51506
2018-11-27 11:40:39 +00:00
0bf740fa32
Replace `=== true` with `parseBoolean()`
2018-11-27 09:18:48 +01:00
8ef5115795
Replace convertPermissionToBoolean with parseBoolean
2018-11-27 09:18:48 +01:00
d993f4b1ec
Merge branch 'mr-sticky-headers' into 'master'
...
Made diff file headers sticky
Closes #48816
See merge request gitlab-org/gitlab-ce!23249
2018-11-22 15:10:24 +00:00
ce91c326f9
Made diff file headers sticky
...
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48816
2018-11-22 12:24:45 +00:00
93c614ce92
Show toggle tree button on merge request commits
...
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53019
2018-11-22 12:04:18 +00:00
8826962d21
Update `gitlab` npm namespace
2018-11-21 23:41:38 +02:00
f252156784
Add `hover` on button tooltips
...
See https://gitlab.com/gitlab-org/gitlab-ui/issues/89
2018-11-21 23:11:41 +02:00
0642404b08
Remove the tooltip trigger suffix
2018-11-21 23:11:41 +02:00
02e7497166
Replace tooltip directive with gl-tooltip directive in badges, cycle analytics, and diffs
2018-11-21 23:11:41 +02:00
5b9495c5db
Prettify all the things
2018-11-20 09:30:01 -06:00
b1321dedaa
Merge branch 'gt-fix-typo-in-notebook-props' into 'master'
...
Fix typo in js (props, specs)
See merge request gitlab-org/gitlab-ce!23103
2018-11-19 21:12:07 +00:00
8b1f2823a2
Use @gitlab npm namespace
2018-11-16 19:29:11 +00:00
4a2b19706c
Rename diffs store variable
2018-11-15 18:16:27 +02:00
ccd1d6826b
Fix typos in comments for js
2018-11-15 14:50:40 +02:00
234563ba30
Made diff & note data consistent
...
This caused many pain points when working with it.
Part of the data was camel cased the other snake case.
Other parts where snake case & then getting converted in components,
this conversion has the potential for leaking memory.
This changes that & makes it consistent with what it returned from the
API, snake case.
2018-11-14 19:16:46 +00:00
8e265bc359
Fix collapsed files not fully fully expanding
...
This fixes files that are collapsed by default not expanding
when the expand all button is clicked.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53866
2018-11-13 13:42:04 +00:00
56834e6bb2
Merge branch 'osw-comment-on-any-line-on-diffs-w-feature-flag' into 'master'
...
Comment on any expanded diff line on MRs (with feature-flag)
Closes #13950
See merge request gitlab-org/gitlab-ce!22914
2018-11-12 15:36:48 +00:00
Phil Hughes
Tim Zallmann
Stan Hu
Francisco Javier López
Sam Bigelow
Fatih Acet
Nick Thomas
Sean Nichols
Oswaldo Ferreira
André Luís
Mike Greiling
Winnie Hellmann
Filipa Lacerda
George Tsiolis
Clement Ho
Douwe Maan