Commit Graph

63 Commits

Author SHA1 Message Date
GitLab Bot 78cfc7cf4a Add latest changes from gitlab-org/gitlab@master 2022-02-15 15:15:04 +00:00
GitLab Bot e7e44c0e4c Add latest changes from gitlab-org/gitlab@master 2022-02-15 09:17:01 +00:00
GitLab Bot 1947c080b3 Add latest changes from gitlab-org/gitlab@master 2021-11-19 03:14:18 +00:00
GitLab Bot c753fd0bf4 Add latest changes from gitlab-org/gitlab@master 2021-09-30 18:11:31 +00:00
GitLab Bot 122ed7ce8c Add latest changes from gitlab-org/gitlab@master 2021-08-19 00:11:16 +00:00
GitLab Bot ebc589e90c Add latest changes from gitlab-org/gitlab@master 2021-06-10 03:10:01 +00:00
GitLab Bot d6d1051383 Add latest changes from gitlab-org/gitlab@master 2021-04-22 21:09:53 +00:00
GitLab Bot da59ce8b21 Add latest changes from gitlab-org/gitlab@master 2021-04-12 18:12:15 +00:00
GitLab Bot 516fa645e6 Add latest changes from gitlab-org/gitlab@master 2021-01-31 09:09:05 +00:00
GitLab Bot c6c346e8c7 Add latest changes from gitlab-org/gitlab@master 2021-01-28 21:09:04 +00:00
GitLab Bot b3c8b65ec2 Add latest changes from gitlab-org/gitlab@master 2021-01-06 09:10:31 +00:00
GitLab Bot ed7568cc80 Add latest changes from gitlab-org/gitlab@master 2020-10-16 09:09:06 +00:00
GitLab Bot 1ca6880aac Add latest changes from gitlab-org/gitlab@master 2020-10-06 18:08:49 +00:00
GitLab Bot 0b4bb101ea Add latest changes from gitlab-org/gitlab@master 2020-10-01 18:10:20 +00:00
GitLab Bot 2d8454515e Add latest changes from gitlab-org/gitlab@master 2020-07-16 15:09:38 +00:00
GitLab Bot 8b0ef13236 Add latest changes from gitlab-org/gitlab@master 2020-06-03 18:08:28 +00:00
GitLab Bot abae8f34f3 Add latest changes from gitlab-org/gitlab@master 2020-03-31 21:08:05 +00:00
GitLab Bot db24ab2b72 Add latest changes from gitlab-org/gitlab@master 2020-01-28 12:08:44 +00:00
GitLab Bot 4eeb6b0d16 Add latest changes from gitlab-org/gitlab@master 2019-12-13 15:08:02 +00:00
GitLab Bot 29c01c6c91 Add latest changes from gitlab-org/gitlab@master 2019-11-14 03:06:25 +00:00
GitLab Bot d2ffc30fd5 Add latest changes from gitlab-org/gitlab@master 2019-10-16 12:06:32 +00:00
Vitali Tatarintev 6a6411938a Change `be_success` to `be_successful` in specs
Fixes deprecation warning:

```
DEPRECATION WARNING: The success? predicate is deprecated and
will be removed in Rails 6.0.
Please use successful? as provided by Rack::Response::Helpers.
```
2019-08-19 14:40:56 +02:00
gfyoung 93a44e135b Add some frozen string to spec/**/*.rb
Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-04-15 10:17:05 +00:00
Thong Kuah 4ec16912b8 Autocorrect with RSpec/ExampleWording cop
- rewords examples starting with 'should'
- rewords examples starting with 'it'

Note: I had to manually fixup "onlies" to "only"
2019-04-05 08:43:27 +00:00
Jasper Maes bebc526e3e Remove deprecated xhr from specs 2018-12-19 23:29:51 +01:00
blackst0ne b44a2c801a Update specs to rails5 format
Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`
2018-12-19 10:04:31 +11:00
Mark Chao a63bce1a4b Resolve "Rename the `Master` role to `Maintainer`" Backend 2018-07-11 14:36:08 +00:00
Rémy Coutable 7736b51812
Reduce CE/EE diff in spec/controllers/projects/project_members_controller_spec.rb
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-05-24 19:29:31 +02:00
blackst0ne 27c95364b5 Replace '.team << [user, role]' with 'add_role(user)' in specs 2017-12-22 19:18:28 +11:00
Rubén Dávila 429302b34c Bugfix: User can't change the access level of an access requester
The endpoint was returning 404 because it was only searching on the
current members of a Group or Project and not the access requesters.
2017-12-11 09:53:31 -05:00
Jacopo 2f40dac352 Refactor `have_http_status` into `have_gitlab_http_status` in the specs 2017-10-20 10:13:18 +02:00
Robert Speicher 72a7b30c9f Change all `:empty_project` to `:project` 2017-08-02 17:47:31 -04:00
Tim Zallmann 64e589c581 Resolve "Inconsistent location of members page between groups and projects" 2017-07-07 14:40:41 +00:00
Douwe Maan fe13f11041 Create and use project path helpers that only need a project, no namespace 2017-07-05 11:11:59 -05:00
Robert Speicher a6ec5121f0 Correct RSpec/SingleLineHook cop offenses 2017-06-14 13:18:56 -05:00
Nick Thomas 5c602e306c Limit non-administrators to adding 100 members at a time to groups and projects 2017-06-06 16:04:26 +01:00
Dmitriy Zaporozhets 395fca1493
Refactor members controller destroy action
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2017-04-17 17:44:30 +03:00
Dmitriy Zaporozhets 7de75920f7
Refactor controller code that creates project/group members
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2017-04-17 14:45:14 +03:00
Robert Speicher 4642ca6686 Use `empty_project` where possible in controller specs 2017-01-25 17:14:38 -05:00
Jose Ivan Vargas 57b5612aaa Removed the "Groups" option from the settings gear
Fixed more tests
2017-01-03 10:52:14 -06:00
Jose Ivan Vargas 68c730bb99 Fixed rspec tests for the project members also fixed the index
view (removed an extra tag )
2017-01-03 10:52:14 -06:00
Nick Thomas d211011698 Make access request specs explicitly enable or disable access requests as required 2016-11-11 15:45:47 +00:00
Valery Sizov 921677782f Implement CreateMembers service to make controller thin 2016-11-01 10:17:04 +02:00
Dmitriy Zaporozhets 3608f9284e Improve create project member test at project_members_controller_spec
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-10-24 13:14:00 +03:00
Linus G Thiel 036fac06d1 Gracefully handle adding of no users to projects and groups
- Disable {project, group} members submit button if no users

  If no users are selected, the submit button should be disabled.

- Alert user when no users were added to {project, group}.

  When no users were selected for adding, an alert message is
  flashed that no users were added.

- Also, this commit adds a feedback when users were actually added to a
  project, in symmetry with how group members are handled.

Closes #22967, #23270.
2016-10-24 13:14:00 +03:00
Valery Sizov 168197cd5a Fix project member access levels 2016-10-21 12:57:53 +03:00
Dmitriy Zaporozhets 2fabd1a123
Change the order of tested methods in project_members_controller_spec
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-10-19 22:14:57 +03:00
Dmitriy Zaporozhets 357c794a49
Refactor project_members_controller_spec
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-10-19 15:13:59 +03:00
Rémy Coutable c8b1311934 Fix a few things after the initial improvment to Members::DestroyService
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-03 16:57:48 +02:00
Rémy Coutable bd78f5733c Exclude requesters from Project#members, Group#members and User#members
And create new Project#requesters, Group#requesters scopes.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-07-01 17:44:46 +02:00