Commit Graph

65 Commits

Author SHA1 Message Date
Clement Ho ba37848d58 Merge branch 'fix-user-select-dropdown-escaping' into 'security-9-5'
Fixes the User Selection Display (9.5)

See merge request gitlab/gitlabhq!2177
2017-09-07 20:22:16 -04:00
Mark Fletcher 2ad3dcc5ca Fix invite by email address duplication 2017-08-25 15:51:24 +07:00
Tim Zallmann dab08be606 Resolve "Specific Async Script Loading by using a Page Variable" 2017-08-03 20:31:53 +00:00
Douwe Maan 6ee0436c89 Merge branch 'tc-namespace-license-checks--multiple-assignees' into 'master'
CE counterpart of: Namespace license checks for multiple assignees

See merge request !11825
2017-07-04 14:49:08 +00:00
Tim Zallmann d49d63a04e Resolve ""Add Members" drop-down doesn't separate Name/Username" 2017-06-22 20:37:08 +00:00
Toon Claes 4c2ca4c38d [noop] Remove unused code
To make the code back in line with EE.

[ci skip]
2017-06-20 14:19:45 +02:00
Clement Ho 7997bbbfef Backport MR from EE 2017-05-26 16:27:30 -05:00
Phil Hughes a49337727b Merge branch '31987-automatically-close-assignee-select-dropdown-after-selection-when-multiple-assignees-is-disabled' into 'master'
Automatically close user dropdown for CE

Closes #31987

See merge request !11189
2017-05-18 07:41:14 +00:00
Clement Ho fbe1e00e82 Remove unnecessary hidden() 2017-05-17 11:55:08 -05:00
Clement Ho de9e559d44 Fix unassigned checkmark 2017-05-17 15:26:52 +00:00
Clement Ho 5caa989872 Use to toggle the dropdown 2017-05-17 10:13:40 -05:00
Clement Ho 2c5e70bec6 Fix conflict on users_select 2017-05-12 13:04:07 -05:00
Luke "Jared" Bennett 05278b2fda Import export users select 2017-05-12 08:15:28 +00:00
Clement Ho 9740f6a77a Add additional EE check 2017-05-11 16:20:20 -05:00
Filipa Lacerda ff5bd7a9e8 Merge branch 'remove-needless-bind-polyfills' into 'master'
Remove needless bind and indexOf polyfills

See merge request !11187
2017-05-09 17:38:05 +00:00
Clement Ho dbbe15e691 Automatically close user dropdown for CE 2017-05-09 11:12:39 -05:00
Mike Greiling b095c40783 Prevent vue.esm.js from being bundled into the primary JS bundle 2017-05-09 13:43:08 +00:00
Mike Greiling 0163624985 remove bind polyfill from users_select.js 2017-05-08 17:40:23 -05:00
Clement Ho c4094b7ec4 Fix specs 2017-05-04 22:34:15 -05:00
Clement Ho 9c4ee8ee64 Fix eslint and rubocop 2017-05-04 13:55:13 -05:00
Clement Ho dbb50ed890 Restrict FE assignees to 1 2017-05-04 13:36:18 -05:00
Clement Ho 4b1d580a84 Fix FE conflicts 2017-05-04 11:43:45 -05:00
Valery Sizov 387c4b2c21 Backport of multiple_assignees_feature [ci skip] 2017-05-04 17:11:53 +03:00
Sam Rose adc59353fa Default to null user when asignee is unselected
Also implemented same behavior on the Issue Boards assignee block.
Fixed the default state for search/filter dropdown for issuables.
2017-05-02 17:38:40 -04:00
Sam Rose e12d754b04 Add option to select the null user as the default 2017-04-29 21:16:50 -04:00
Sam Rose 575d9027d9 Display check next to assigned user in dropdown 2017-04-28 13:02:57 -04:00
Phil Hughes dab6aab220 Assignee filter on group issues/merge requests only loads group users
Closes #29490
2017-04-24 16:15:24 +01:00
Kushal Pandya d586b6cced Add ES lint support to identify poorly written Promises 2017-04-20 11:11:51 +00:00
Mike Greiling 4bdbccfc06 Remove Vue from main bundle and disable production warnings 2017-04-07 19:36:09 +00:00
Mike Greiling d9dedc36c3 remove Vue from the global space 2017-03-20 22:12:01 -05:00
Simon Knox 67eefe7eac don't show loading spinners for server-rendered sidebar fields 2017-03-18 11:36:05 +11:00
Phil Hughes 236d6595ed Removed previous filter code 2017-03-08 14:53:18 +00:00
Simon Knox 4f143aa8f2 re-add Assign to Me link on new MR/Issue forms 2017-03-07 16:23:52 +11:00
Mike Greiling 0f31c5a92b replace implicit this == window with explicit binding 2017-02-17 16:58:32 -06:00
Phil Hughes 7e25379062 Added tests for modal filters 2017-02-03 18:03:40 +00:00
Phil Hughes e4d1e1437d Added all filters 2017-02-03 18:03:40 +00:00
Phil Hughes 4652b08f19 Hardcoded author, assignee & milestone dropdowns 2017-02-03 18:03:40 +00:00
Mike Greiling 04eff5fdb0 resolve all x-spacing and no-spaced-x eslint violations 2017-01-18 17:18:40 -06:00
Mike Greiling ccada28f30 resolve all padded-blocks eslint violations 2017-01-18 17:16:41 -06:00
Mike Greiling 9e4d04913a resolve all no-plusplus eslint violations 2017-01-18 17:15:27 -06:00
Mike Greiling 8e0e902b13 resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
Luke "Jared" Bennett 7cefaea876
explicitly disable eslint inline 2016-11-15 16:30:34 +00:00
Valery Sizov b7dff1b072 Fix: Todos Filter Shows All Users 2016-11-04 13:41:14 +02:00
Fatih Acet dd5e46ab69 Merge branch 'eslint' into 'master'
Add ESLint

## What does this MR do?

- create `package.json`
- add ESLint dependencies to `package.json`
- add JavaScript linting to CI
- add Rake task `lint:javascript`as alias for `eslint` (which itself is an alias for `npm run eslint`)

## Are there points in the code the reviewer needs to double check?

Probably not.

## Why was this MR needed?

My hovercraft was full of eels.

## What are the relevant issue numbers?

- https://gitlab.com/gitlab-org/gitlab-ce/issues/13224#note_12537431
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5006#note_13255658


See merge request !5445
2016-10-26 16:31:08 +00:00
winniehell 02f94cf038 disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
Phil Hughes 29645f06e7 Hides/shows the boards sidebar
Rather than constructing & then deconstructing, we know just hide & show
the sidebar. This is done so we dont' have a memory leak on the frontend
with objects getting created.
2016-10-20 08:54:33 +01:00
Phil Hughes f1350a5c82 Merge branch 'master' into issue-board-sidebar 2016-10-19 08:44:55 +01:00
Dmitriy Zaporozhets c736ffdfb0
Validate user id for users select autcomplete
Single user autcomplete should be used only for existing users with
digital ID provided. Now js code puts any input into generating user URL
which can lead to 500 error because routing like this does not exists:

GET "/autocomplete/users/whatever@example.com.json".

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-10-14 16:04:23 +03:00
Sean McGivern 11e93ad59d Merge branch 'feature/issues-board' into 'master'
Refactoring Issues Board

## What does this MR do?

This MR aims to minimize conflicts between the CE issues board feature with EE multiple boards feature.

## Are there points in the code the reviewer needs to double check?

## Why was this MR needed?

To avoid a lot of conflicts with EE multiple boards feature.

## Screenshots (if relevant)

## Does this MR meet the acceptance criteria?

- [ ] ~~[CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added~~
- [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- [x] API support added
- Tests
  - [X] Added for this feature/bug
  - [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ee/issues/929

https://gitlab.com/gitlab-org/gitlab-ee/issues/1084

See merge request !6727
2016-10-13 14:21:14 +00:00
Phil Hughes 25c82c6faf Updated JS to work with issue index & show 2016-10-12 17:43:20 +01:00