b7d8df503c
Enable Style/MutableConstant
2017-02-23 09:31:56 -06:00
3dadf306dd
Enable Style/DotPosition
2017-02-23 09:31:56 -06:00
6a1b3ef73f
Merge branch 'zj-drop-ruby-21-tests' into 'master'
...
Update Rubocop to Ruby 2.3
See merge request !8994
2017-02-13 10:22:38 +00:00
128b1eae09
Update Rubocop to ruby 2.3
2017-02-07 15:16:46 +01:00
149f67cc2e
Remove coverage entry from global CI/CD options
2017-02-04 23:04:17 +01:00
93e98058ea
Merge branch '20248-add-coverage-regex-in-job-yaml' into 'master'
...
Add ability to define a coverage regex in the .gitlab-ci.yml
Closes #20428
See merge request !7447
2017-02-02 17:01:52 +00:00
5ac590677f
Merge branch '25910-convert-manual-action-icons-to-svg-to-propperly-position-them' into 'master'
...
Convert pipeline action icons to svg to have them propperly positioned
Closes #25910
See merge request !8766
2017-01-31 11:42:06 +00:00
7db05c4da1
Removed unused method
2017-01-26 19:56:07 +00:00
050103f209
Make sure TraceReader uses Encoding.default_external
...
Encoding.default_external was chosen over
Encoding.default_internal because File.read is
returning Encoding.default_external, therefore
we should align with it. Alternatively, we could
force both of them to be Encoding.default_internal.
However, ideally this should be determined by different
projects. For example, some projects might want to use
an encoding different to what GitLab is using.
This might not happen soon though.
Closes #27052
2017-01-26 18:29:44 +08:00
4983fbaaf4
Remove unneeded 'borderless' from icons name
2017-01-25 15:44:45 +00:00
066155704d
added icons and fixed mini pipeline action dropdown icons
2017-01-25 15:44:44 +00:00
441a9beec3
Make some other refinements to validation logic
2017-01-25 01:07:45 -02:00
8fe708f4a2
Make more code improvements around the '/' stripping logic
2017-01-25 01:07:45 -02:00
be7106a145
Force coverage value to always be surrounded by '/'
2017-01-25 01:07:44 -02:00
6323cd7203
Comply to more requirements and requests made in the code review
2017-01-25 01:07:44 -02:00
f1e920ed86
Simplify coverage setting and comply to some requests in code review
2017-01-25 01:07:44 -02:00
bb12ee051f
Fix wrong description for Coverage entry (in ruby comments)
2017-01-25 01:07:44 -02:00
0713a7c3a9
Add specs to cover the implemented feature and fix a small bug
2017-01-25 01:07:44 -02:00
9f97cc6515
Add `coverage` to the Global config entry as well
2017-01-25 01:07:44 -02:00
d0afc500e3
Change expected `coverage` structure for CI configuration YAML file
...
Instead of using:
`coverage: /\(\d+.\d+%\) covered/`
This structure must be used now:
```
coverage:
output_filter: /\(\d+.\d+%\) covered/`
```
The surrounding '/' is optional.
2017-01-25 01:07:43 -02:00
646b9c54d0
Comply to requests made in the review and adjust to the Entry/Node changes
...
This commit:
* Turns `coverage_regex` into `coverage` entry in yml file
* Fixes smaller requests from code reviewers for the previous commit
* This commit is temporary (will be squashed afterwards)
This commit does not (further commits will do though):
* Add global `coverage` entry handling in yml file as suggested by Grzegorz
* Add specs
* Create changelog
* Create docs
2017-01-25 01:07:43 -02:00
6a3d29c73d
Add ability to define a coverage regex in the .gitlab-ci.yml
...
* Instead of using the proposed `coverage` key, this expects `coverage_regex`
2017-01-25 01:07:43 -02:00
7446c2f5cf
Merge branch 'feature/success-warning-icons-in-stages-builds' into 'master'
...
Use a warning icon for a stage with allowed to fail builds
Closes #21948
See merge request !8503
2017-01-23 14:32:06 +00:00
73fcfb296c
Add a default status const to common status concern
2017-01-18 11:34:55 +01:00
3bc0525ad9
Extract compound statuses method in status factory
2017-01-18 11:30:28 +01:00
9f1beed7a7
Link external commit status badge to a target URL
...
Using new detailed statuses factory for external commit statuses.
2017-01-17 14:30:33 +01:00
8faf0c7abe
Add detailed statuses for external commit statuses
2017-01-17 14:16:36 +01:00
227cbdd8ba
Use detailed status for failed but allowed builds
2017-01-12 13:23:18 +01:00
48c19e7395
Expose methods that match statuses in status factories
2017-01-12 13:04:51 +01:00
1d01ffb782
Make it possible to combine extended CI/CD statuses
...
This commit also makes it possible to configure exclusive groups.
There can be only one detailed status matched within an exclusive group,
which is important from the performance perspective.
2017-01-12 12:45:00 +01:00
9f1279184b
Add extended status for build failed but allowed to
2017-01-11 13:53:17 +01:00
8dbd1e7d00
Add concrete success warning status to stage factory
2017-01-11 13:53:17 +01:00
8b30dd9834
Extract abstract success with warnings CI/CD status
2017-01-11 13:53:17 +01:00
6ef6f9f205
Do not check for valid url for .gitlab-ci.yml
...
Until this commit, GitLab would check if the URL in your .gitlab-ci.yml
would be valid and adressable. However, this approach is rather limited.
To begin, the URL couldn't be http://example:$PORT/my-project , as the
PORT value would be interpolated after checking if the URL was valid,
which its not. Also this gem will limit the amount of protocols allowed.
This commit doesn't check, at all, if the URL is valid. This is now the
responsablilty of the user. In my opion this is right, as the user
ultimately benefits from a correct URL, but also, its impossible to
cover all cases.
2017-01-05 19:59:10 +01:00
1476bb2c54
Improve how we calculate detailed status group name
2016-12-16 20:03:44 +01:00
b18897ac40
Update status group name for success with warnings
2016-12-16 20:03:44 +01:00
1b313e8db8
Make CI/CD detailed status group concept explicit
2016-12-16 20:03:44 +01:00
84290a452d
Make it possible to mix `Gitlab::Routing` in
2016-12-13 14:51:23 +01:00
00970606d7
Extract abilities checking module from ability model
2016-12-13 14:44:43 +01:00
48d43608b8
Refine build stop/play extended status specs
2016-12-13 12:27:01 +01:00
2011f8f1c2
Use manual build icon in play/stop build statuses
2016-12-13 11:53:36 +01:00
ab37be2dda
Add specs for build stop extended detailed status
2016-12-12 14:59:46 +01:00
ffafd09731
Fix build stop extended status CSS class
2016-12-12 14:14:35 +01:00
d60820146f
Fix path to build status details in common helpers
2016-12-12 13:28:20 +01:00
d9a979c84f
Add action_class/action_title
2016-12-12 12:59:02 +01:00
980009e6e8
Fix auto loading of constants for Ci Statuses
2016-12-12 12:59:01 +01:00
f0cd73bfad
Fix some detailed statuses specs related to abilities
2016-12-12 12:59:01 +01:00
5059d0b834
Incorporate permission checks into new CI statuses
...
[ci skip]
2016-12-12 12:59:01 +01:00
e0ce97fb7d
Refactor ci status factories to DRY code a little
2016-12-12 12:59:01 +01:00
a83a80edb3
Check permission of details
2016-12-12 12:59:01 +01:00
Douwe Maan
Rémy Coutable
Z.J. van de Weg
Grzegorz Bizon
Douwe Maan
Kamil Trzciński
Filipa Lacerda
Lin Jen-Shin
dimitrieh
Leandro Camargo