Commit Graph

64 Commits

Author SHA1 Message Date
Thong Kuah 0d7bb4f687 Revert back to go but use arguments for some cases
It has been pointed out that `go` is used quite extensively so it's not
an unknown idiam here at GitLab. And we have arguments with `go` which
is a plus.
2018-10-16 21:50:44 +13:00
Thong Kuah c5bca03bf0 Use subject in controller spec
Swap out `go` method with subject which is the convention.

Re-organize 'PUT update' to remove un-necessary context nesting.

DRY up repeated blocks to `add_maintainer` and `sign_in`
2018-10-15 11:42:41 +13:00
Thong Kuah 292d2208e0 Add FE option for users to choose to create a fully RBAC-enabled cluster or not.
This is similar to the option in the Add Existing cluster form
2018-09-14 16:26:51 +12:00
Thong Kuah 6f2ad2b604 Enable Kubernetes RBAC for GitLab Managed Apps for existing clusters 2018-09-06 10:03:38 +00:00
Mark Chao a63bce1a4b Resolve "Rename the `Master` role to `Maintainer`" Backend 2018-07-11 14:36:08 +00:00
Dennis Tang ce0ce1cb19 consolidate back into one controller 2018-06-19 15:01:43 +00:00
Dennis Tang 98cf3a0b54 update tests 2018-06-05 21:47:22 -07:00
Dennis Tang fcb7b31ce0 fix tests for new cluster POST 2018-06-01 21:22:07 -07:00
Dennis Tang abad4ff00c remove focus on test 2018-05-31 16:36:08 +02:00
Dennis Tang 9d2ca0841f consolidate clusters controller specs 2018-05-31 13:48:04 +02:00
Rémy Coutable 981b8ab7bd
Reduce CE/EE diff in app/controllers/projects/clusters_controller.rb
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-05-24 19:29:29 +02:00
Mayra Cabrera ca59bfdc66 Rearrange DeploymentPlatform methods
- Change find_cluster_platform_kubernetes to ignore environment argument
- Fix broken specs

CE Port of: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5047/
2018-03-22 14:52:33 -06:00
Dylan Griffith 69adf79234 Fix clusters_controller_spec (#42643) 2018-02-23 10:31:19 +11:00
Dylan Griffith 3d3d09fa9d Schedule Ingress IP address fetch from K8s after clusters page load (#42643) 2018-02-20 13:49:35 +11:00
Winnie Hellmann 0ecd759d73 Replace "cluster" with "Kubernetes cluster" 2018-02-06 10:05:02 +01:00
Matija Čupić 4882c79301
Remove cluster scope from ClustersController#index 2017-12-11 15:06:45 +01:00
Matija Čupić 2eb41b5a42
Mock Kaminari paginates_per instead of setting it 2017-12-05 16:20:24 +01:00
Matija Čupić 4d75901c02
Use ClustersFinder for setting counts 2017-12-05 16:15:17 +01:00
Matija Čupić f81503a061
Fix overwritten project.cluster replacement 2017-12-05 15:29:03 +01:00
Matija Čupić 6a3372649a
Fix empty state partial check 2017-12-05 15:26:37 +01:00
Matija Čupić d9819cb0f0
Fix rpsec all matchers in ClustersController specs 2017-12-05 15:21:18 +01:00
Matija Čupić fbe130e174
Test for empty state partial instead of index view 2017-12-05 15:07:37 +01:00
Matija Čupić 85305061c9
Remove redundant view_clusters assignment 2017-12-05 15:07:07 +01:00
Kamil Trzcinski 2fc29237aa Merge remote-tracking branch 'origin/list-multiple-clusters' into cluster-page-with-list-clusters 2017-12-05 13:31:07 +01:00
Kamil Trzcinski 9429514e30 Merge branch '35616-move-k8-to-cluster-page' into cluster-page-with-list-clusters 2017-12-05 13:29:41 +01:00
Shinya Maeda 445a41091b Clean up clusters_controller_spec.rb 2017-12-05 18:26:12 +09:00
Matija Čupić f1357a1e15
Remove references of project.cluster from specs 2017-12-04 17:02:18 +01:00
Alessio Caiazza f8b29b06df
Fix static analysis 💚 2017-12-04 09:12:04 +01:00
Kamil Trzcinski b1994c366f Fix specs for forms 2017-12-03 22:55:32 +01:00
Kamil Trzcinski 5f296daa27 Fix specs 2017-12-03 22:03:21 +01:00
Kamil Trzcinski f1cce0cba8 Merge remote-tracking branch 'origin/list-multiple-clusters' into cluster-page-with-list-clusters 2017-12-03 22:00:25 +01:00
Kamil Trzcinski 5ea53d2e81 Fix specs 2017-12-03 21:52:21 +01:00
Kamil Trzcinski 2353655991 Yet another specs 2017-12-03 21:48:52 +01:00
Kamil Trzcinski 90c09efe7e Fix Rubocop 2017-12-03 20:06:10 +01:00
Kamil Trzcinski 1337a01492 Fix ClustersController specs 2017-12-03 15:43:33 +01:00
Kamil Trzcinski b2b4f262d5 First round of tests 2017-12-03 15:33:10 +01:00
Matija Čupić dc1ba68bfb
Remove stray pry binding in spec 2017-12-02 01:02:32 +01:00
Matija Čupić c2bf452c17
Refactor ClustersController pagination test 2017-12-01 18:01:59 +01:00
Matija Čupić b7f3536096
Add specs JSON PUT #delete for ClustersController 2017-12-01 16:41:56 +01:00
Matija Čupić 5fb8b2f757
Refactor disabled cluster testing to use trait 2017-12-01 16:27:53 +01:00
Matija Čupić f6057437dc
Rename spec local variable to avoid shadowing 2017-12-01 16:04:42 +01:00
Matija Čupić 42d87f9085
Refactor pagination check into separate context 2017-12-01 15:52:11 +01:00
Matija Čupić ea164796f2
Remove redundant to_params 2017-12-01 15:52:09 +01:00
Matija Čupić 6e46df331b
Update ClustersController to match new scope logic 2017-11-28 14:58:23 +01:00
Matija Čupić e1f9219a17
Add specs for scoping in ClustersController 2017-11-27 18:01:08 +01:00
Matija Čupić 374347f9ed
Add pagination specs for ClustersController 2017-11-27 18:00:45 +01:00
Matija Čupić f2727bab66
Add specs for cluster counters 2017-11-27 16:56:43 +01:00
Matija Čupić 98653ba6fa
Check cluster listing logic instead of redirects 2017-11-16 14:33:01 +01:00
Kamil Trzcinski df333a9380 Merge remote-tracking branch 'origin/master' into 35616-move-gke-form-1st-iteration 2017-11-06 22:38:44 +01:00
Shinya Maeda a99ad59e65 Remove 10.3 comments (Tracked by a tech debts issue). Refactor spec factory name. Use ArgumentError 2017-11-06 23:06:10 +09:00