Commit Graph

312 Commits

Author SHA1 Message Date
drew cimino 42d6d3187f preventing blocked users and their PipelineSchdules from creating new Pipelines
updated several specs and factories to accomodate new permissions
2019-06-04 20:25:26 -05:00
Winnie Hellmann 8c7c68a5eb Remove trailing empty lines 2019-05-10 14:12:19 +02:00
Winnie Hellmann 3ee2226b99 Remove unused fixture_file_name parameters
for f in $(find spec/javascripts/fixtures/ -name '*.rb')
do
  sed -E -e 's/(, ){0,1}(fixture_file_name|
  example\.description)(, ){0,1}//' < $f > $f.tmp; mv $f.tmp $f
done
2019-05-10 14:12:19 +02:00
Winnie Hellmann d4bde8621c Remove example block parameters
for f in $(find spec/javascripts/fixtures/ -name '*.rb')
do
  sed 's/do |example|/do/' < $f > $f.tmp; mv $f.tmp $f
done
2019-05-10 14:12:19 +02:00
Winnie Hellmann cf33353b70 Remove duplicate store_frontend_fixture() calls
for f in $(find spec/javascripts/fixtures/ -name '*.rb')
do
  grep -v store_frontend_fixture < $f > $f.tmp; mv $f.tmp $f
done
2019-05-10 14:12:19 +02:00
Winnie Hellmann 66cd2e97fb Merge balsamiq fixture into raw file fixtures 2019-05-10 14:12:19 +02:00
Winnie Hellmann dff8bd0c03 Merge PDF fixture into raw file fixtures 2019-05-10 14:12:19 +02:00
Winnie Hellmann 3e881f7aa5 Expose response variable for raw file fixtures 2019-05-10 14:12:19 +02:00
Winnie Hellmann 5990d42253 Ignore PDF and balsamiq fixture files
(cherry picked from commit 1b33828811897b6a3f8a38044cc0839b87098d1f)
2019-05-02 23:11:12 +02:00
Winnie Hellmann d152a74ce3 Move all static fixtures to static directory 2019-04-25 13:56:32 +02:00
Winnie Hellmann 2f704d8356 Delete static_fixtures.rb for static HAML fixtures 2019-04-11 07:39:14 +00:00
Fatih Acet 7650677d3d
Rewrite related MRs widget with Vue
This MR rewrites existing Related Merge Requests widget
with Vue with reusing shared Related Issues components
2019-04-05 21:20:28 +02:00
Annabel Dunstone Gray 01c40ae29f Merge branch 'dm-md-css' into 'master'
Untangle Markdown/Diffs/Notes CSS mess

See merge request gitlab-org/gitlab-ce!26493
2019-03-26 16:40:25 +00:00
Winnie Hellmann ad985a7a28 Merge branch 'winh-remove-sushi' into 'master'
Remove .raw from JavaScript fixture file names

Closes #59201

See merge request gitlab-org/gitlab-ce!26430

(cherry picked from commit 79a45f7f02)
2019-03-26 16:03:28 +00:00
Douwe Maan 838f7e56a4
Remove .wiki and @md-typography mixin in favor of .md and .md-file
Before, the styling for `img:not(.emoji)`` was repeated between
`.md:not(.use-csslab):not(.wiki)` (for comments and the Markdown
preview), `.documentation.wiki` (for help pages), and
`.issuable-details .description .wiki` (for MR and issue descriptions).

In these places, we now simply use `.md`. Wherever we use `.md` but
don't want this image styling (like wikis and blobs), `.md-file` is
added.
2019-03-26 14:29:33 +01:00
Filipa Lacerda 022968764c Revert "Merge branch 'winh-remove-sushi' into 'master'"
This reverts merge request !26430
2019-03-22 11:03:15 +00:00
Winnie Hellmann 3e9bb4ad31 Remove .raw from JavaScript fixture file names
There is nothing more to say but

"Commits that change 30 or more lines across at least three files
must describe these changes in the commit body"
2019-03-21 17:16:53 +01:00
Kushal Pandya 5dc56f83b3 Merge branch 'winh-dequarantine-labels-autocomplete' into 'master'
Move gfm_autocomplete_spec.rb out of quarantine

Closes #57995 and #56843

See merge request gitlab-org/gitlab-ce!25958
2019-03-20 08:49:06 +00:00
Winnie Hellmann 28961d6abb Do not delete files in spec/javascripts/fixtures/static/ 2019-03-19 16:55:41 +01:00
Winnie Hellmann 00db78214c Remove static HAML fixtures from frontend testing guide 2019-03-19 16:54:41 +01:00
Winnie Hellmann 2616c787ca Remove static JavaScript HAML fixtures
Replace all HAML fixtures with the generated HTML files.
2019-03-19 16:54:41 +01:00
Rémy Coutable b789bfaeef
Simplify the JavaScriptFixturesHelpers module
- Only storing fixtures in one place
- This place changes whether we are in CE or EE

We discovered with @winh that only fixtures located under
spec/javascripts/fixtures are used, even in EE so there's no need to
clean/create fixtures in ee/spec/javascripts/fixtures.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-03-19 08:46:22 +01:00
Rémy Coutable 66dffba45d
Don't create EE-specific files when creating Emojis fixture files
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-03-12 08:02:45 +01:00
Phil Hughes 9ff9047402 Merge branch 'winh-dequarantine-labels-autocomplete' into 'master'
Move gfm_autocomplete_spec.rb out of quarantine

Closes #57995 and #56843

See merge request gitlab-org/gitlab-ce!25542

(cherry picked from commit 2dcbc0fa56)
2019-03-11 11:20:27 +01:00
Rémy Coutable 42df6c854d
Fix for mismatch in EE on FIXTURE_PATHS to FIXTURE_PATH
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-03-07 17:02:39 +01:00
Dmitriy Zaporozhets 7aa3c9b30f Merge branch 'ce-extract-ee-specific-code-for-spec/support' into 'master'
[CE] Extract EE specific code for spec/support

See merge request gitlab-org/gitlab-ce!25569
2019-03-07 15:34:33 +00:00
Tim Zallmann d07919de90 Moved all emojis to the public folder
Created new emojis map in public folder

Renamed folder to emojis

Loading now the emojis from Localstorage or from Server

Moved all emojis to the public folder

Loading the emojis.json file now through AJAX

Loads now the map in the web element instead when building the emoji tag

Updated the custom Element Setup to modern method

Fixed Emoji Karma Specs for async loading

Loading now the emojis from Localstorage or from Server

Loads now the map in the web element instead when building the emoji tag

Fixed problem with FIXTURE_PATH for emojis fixtures

Fixes Linting Error in gemojione.rake

Fixed Emoji Karma Specs

Fix static type check in gemojione and check if already registered

Testing if the Emoji Support Check is failing Rspec

Change of CLass Name, returning true on check to test

Fixes failing Emoji RSpec Tests

Moved Emojis into public/-/emojis/1/

Fixed Linting Errors in gl_emoji

Fix to fixtures creation for emojis

Fixed path spec for new subdirectory -/emojis

Optimized emojis.json output

Fix for Emoji Spec failure due to unicode dataset

Better catch handling for emojis
2019-03-07 09:33:03 +00:00
Rémy Coutable f5e80ed6b2
Reduce differences in spec/support/helpers/javascript_fixtures_helpers.rb
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-03-07 08:13:37 +01:00
Winnie Hellmann 55f76ce8f6 Revert "Merge branch 'winh-dequarantine-labels-autocomplete' into 'master'"
This reverts merge request !25542
2019-03-05 11:02:00 +00:00
Winnie Hellmann 4be7be6dbc Add JSON fixture for labels autocomplete source 2019-02-27 09:08:41 +01:00
Winnie Hellmann 7e0507dc25 Make fixtures/u2f.rb deterministic 2019-02-21 17:55:42 +01:00
Winnie Hellmann dc9366dd31 Make fixtures/snippet.rb deterministic 2019-02-21 17:55:28 +01:00
Winnie Hellmann b5072fa323 Make fixtures/projects.rb deterministic 2019-02-21 17:55:14 +01:00
Winnie Hellmann 30dd5a65f7 Make fixtures/merge_requests.rb deterministic 2019-02-21 17:55:01 +01:00
Winnie Hellmann fd46e8eec1 Make fixtures/issues.rb deterministic 2019-02-21 17:54:42 +01:00
Winnie Hellmann bb439c24a8 Make fixtures/groups.rb deterministic 2019-02-21 17:54:28 +01:00
Winnie Hellmann 7ddb0c3cbd Make fixtures/deploy_keys.rb deterministic 2019-02-21 17:54:09 +01:00
Winnie Hellmann 01dc16d5b5 Make fixtures/commit.rb deterministic 2019-02-21 17:53:53 +01:00
Winnie Hellmann a54955c52b Make fixtures/blob.rb deterministic 2019-02-21 17:53:36 +01:00
Scott Escue 87c571f8a3
Addressing feedback from most recent reviews. 2019-01-10 00:00:39 -06:00
Scott Escue 6b067fe470
Updating OAuthRememberMe to use new common utility functions when manipulating query parameters on OAuth buttons. This ensures the 'remember_me' parameter is safely added and removed when other query parameters are present. 2019-01-10 00:00:39 -06:00
Scott Escue 4dcaa4df36
Addressing peer review feedback.
Replacing inline JS with ES 2015 functions included in pages/sessions/new. Also applying suggested server-side syntax improvements to OmniAuthCallbacksController.
2019-01-10 00:00:39 -06:00
Kamil Trzciński 0103d5be96 Add config_options|variables to BuildMetadata
These are data columns that store runtime configuration
of build needed to execute it on runner and within pipeline.

The definition of this data is that once used, and when no longer
needed (due to retry capability) they can be freely removed.

They use `jsonb` on PostgreSQL, and `text` on MySQL (due to lacking
support for json datatype on old enough version).
2019-01-04 16:38:17 +01:00
Jasper Maes bf73520079 convert specs in javascripts/ and support/ to new syntax 2018-12-21 10:10:26 +01:00
Winnie Hellmann 74f22d26a9 Add Vue mixin for delayed job timers 2018-11-07 10:00:25 +01:00
Luke Bennett 7cf19c0b81 Prioritize group settings, improve panel titles, disable submit without changes 2018-10-15 13:36:19 +00:00
Paul Slaughter f390184249 Resolve "Commit details are not displayed when reviewing an MR commit by commit" 2018-09-26 08:28:50 +00:00
Dennis Tang ec4ad656f0 Resolve "Improve project overview UI" 2018-09-06 07:27:39 +00:00
Roger Rüttimann 93b9bfd93a Allow whitelisting for "external collaborator by default" setting 2018-08-30 12:53:06 +00:00
Dennis Tang efec7e086d Resolve "Frontend for clarifying the usefulness of the search bar" 2018-08-07 09:59:01 +00:00