- Adds color and a tooltip to describe this new behavior
- Does not resolve if discussion is already resolved
- Adds an action `resolveDiscussion` to simplify `toggleResolveNote`
- Updates docs
https://gitlab.com/gitlab-org/gitlab-ce/issues/54405
When converting a comment to a discussion
if the "Cancel" button is used to exit the new discussion note,
the comment would revert back to its initial state
Before, diff file `higlighted_diff_lines`/`parallel_diff_lines` and
diff discussion `truncated_diff_lines` were inconsistent: `text` and
`rich_text` on the latter included the leading +/-/<space> character,
like on the backend, while the former had no `text` and its `rich_text`
had dropped this char.
This resulted in a bug when the suggestions feature expected these diff
line objects to be identical in format and thus interchangeable, which
was not the case.
Improve the renderign of new and existing discussions
by reducing the number of watchers on each object & array.
Previously every discussion change would trigger an update for every
discussion component.
Also tidied up some components to get them closer to our docs.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51506
After resolving a discussion on a merge request page the merge request
widget state would not get updated meaning users would need to refresh
the page to merge (if that option is enabled in the projects settings)
https://gitlab.com/gitlab-org/gitlab-ce/issues/42882
* master: (38 commits)
Update bitbucket.md to fix typo and small grammar touchups.
Update time_helper.rb to fix output for exact minutes.
Document update for GitLab Pages users.
Support manually stopping any environment from the UI
Fix link to frontend in handbook
Shorten CHANGELOG filename to avoid breaking ecryptfs users
Replace 48976-rails5-invalid-single-table-inheritance-type-group-is-not-a-subclass-of-gitlab-backgroundmigration-fixcrossprojectlabellinks-namespace.yml
Fix mountComponent helper path in docs
Fix#48537 - Update avatar only via the projects API
Add additional headline for Adding SSH keys to GitLab
Request to be a proofreader.
Fix specs
Fix search bar text input alignment
Fix API docs on unauthenticated projects return
Adds with_projects optional parameter to /groups/:id API endpoint
Docs: make it clear that you need a completely separate domain for Pages
Document that we don't want to wait in tests
Removes unused store in diffs mr refactor Removes double export for actions in diffs module in mr refactor
Remove useless return
Use latest gitlab-styles
...
* master: (29 commits)
Fix provider server URL used when listing repos to import
Fix inconsistent punctuation on MR form
Update dependency for svgs
Fix timestamp to include %M instead of %I for post-deploy migrations.
Use Gitaly 0.89.0
Resolve "Hover style for sidebar dropdowns is wrong"
fixed spec
Respect the protocol in `expose_url`
Fix removes source branch text being rendered in merged state
Fix code and wiki search results when filename is non-ASCII
Include the ee/ directory in backtraces
Use GitLab fork of zaproxy
Updates file extensions on Vue docs
fixed note polling not sending updated last fetched at date added spec for polling
Add changelog entry
Use `list.id` for `:key`
added mutation spec
Bump parser and unparser gems to remove warnings
fix polling not working correctly
Fixed issue notes being duplicated
...
* master: (112 commits)
Replace the 'project/service.feature' spinach test with an rspec analog
Removed two legacy config options
Fix rendering double note issue.
IssueNotes: Switch back to Write pane when note cancel or submit.
Upgrade Nokogiri because of CVE-2017-9050
Bump VERSION to 10.1.0-pre
Standardize access to CSRF token in JavaScript
Do not clone the repo when running the review-docs jobs
Don't memoize storage configuration on `FsShardsCheck`
Document that group Owners can always create subgroups
Auto DevOps docs cleanup
Display full pre-receive and post-receive hook output in GitLab UI
Adds EE tag detection to remove_old in gitlab backup.
Correctly detect multiple issue URLs after 'Closes...' in MR descriptions
new sharing permissions
IssueNotes: Resize comment form after note submit and discard.
[skip ci] Add changelog
Make resolve discussion icon gray
update spacing
Deleted another Fixture due to User Callout
...
Winnie Hellmann
Paul Slaughter
Heinrich Lee Yu
Phil Hughes
Takuya Noguchi
Constance Okoghenun
Douwe Maan
André Luís
Felipe Artur
George Tsiolis
Mike Greiling
Johann Hubert Sonntagbauer
Filipa Lacerda
André Luís
Simon Knox
Fatih Acet
Jose Ivan Vargas