b296ffa543
Add latest changes from gitlab-org/gitlab@master
2020-09-09 21:08:33 +00:00
2f47b6d8e1
Add latest changes from gitlab-org/gitlab@master
2020-06-26 09:08:59 +00:00
c59765a50a
Add latest changes from gitlab-org/gitlab@master
2020-06-24 18:09:03 +00:00
c8003cdfe1
Add latest changes from gitlab-org/gitlab@master
2020-06-06 15:08:10 +00:00
09093c1278
Add latest changes from gitlab-org/gitlab@master
2020-04-15 18:09:36 +00:00
df2eda3f14
Add latest changes from gitlab-org/gitlab@master
2020-02-20 18:08:51 +00:00
b69f406585
Add latest changes from gitlab-org/gitlab@master
2020-02-15 00:08:48 +00:00
6755df108b
Add latest changes from gitlab-org/gitlab@master
2020-01-21 00:08:46 +00:00
aa0f0e9921
Add latest changes from gitlab-org/gitlab@master
2020-01-16 18:08:46 +00:00
7f8330873c
Add latest changes from gitlab-org/gitlab@master
2019-12-18 21:07:37 +00:00
123c68a7cf
Add latest changes from gitlab-org/gitlab@master
2019-12-16 18:08:22 +00:00
8f764d21b0
Add latest changes from gitlab-org/gitlab@master
2019-12-05 09:07:27 +00:00
4204cf3085
Add latest changes from gitlab-org/gitlab@master
2019-12-03 15:06:20 +00:00
ee6b185429
Add latest changes from gitlab-org/gitlab@master
2019-11-07 00:06:18 +00:00
76923eae4b
Add latest changes from gitlab-org/gitlab@master
2019-10-22 09:06:14 +00:00
6b75320f52
Add latest changes from gitlab-org/gitlab@master
2019-10-17 12:07:33 +00:00
9c0e2d5b47
Add source and merge_request fields to pipeline event webhook
2019-09-11 19:33:45 +00:00
4e2bb4e5e7
Reduce Gitaly calls in PostReceive
...
This commit reduces I/O load and memory utilization during PostReceive
for the common case when no project hooks or services are set up.
We saw a Gitaly N+1 issue in `CommitDelta` when many tags or branches
are pushed. We can reduce this overhead in the common case because we
observe that most new projects do not have any Web hooks or services,
especially when they are first created. Previously, `BaseHooksService`
unconditionally iterated through the last 20 commits of each ref to
build the `push_data` structure. The `push_data` structured was used in
numerous places:
1. Building the push payload in `EventCreateService`
2. Creating a CI pipeline
3. Executing project Web or system hooks
4. Executing project services
5. As the return value of `BaseHooksService#execute`
6. `BranchHooksService#invalidated_file_types`
We only need to generate the full `push_data` for items 3, 4, and 6.
Item 1: `EventCreateService` only needs the last commit and doesn't
actually need the commit deltas.
Item 2: In addition, `Ci::CreatePipelineService` only needed a subset of
the parameters.
Item 5: The return value of `BaseHooksService#execute` also wasn't being
used anywhere.
Item 6: This is only used when pushing to the default branch, so if
many tags are pushed we can save significant I/O here.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65878
Fic
2019-08-12 22:28:49 -07:00
f540ffcef6
Add frozen_string_literal to spec/lib (part 1)
...
Using the sed script from
https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-07-26 13:25:07 +12:00
da4702493d
Fix label serialisation in issue and note hooks
...
We were not calling hook_attrs on the labels correctly. Specs were
passing because the issues under test did not have any labels!
2019-06-20 13:50:28 +01:00
ed8a00b9c4
Adding labels to note event payload.
2019-06-10 15:35:38 +05:30
7e05f3b78b
Use source ref for pipeline webhook
...
When user uses Pipelines for merge requests, the pipeline is a run on
a merge request ref instead of branch ref. However, we should send
source ref as a webhook in order to respect the original behavior.
2019-05-28 09:29:59 +07:00
1b8646804d
Update deployment chat message notification
...
Include link to user and commit title.
Rearrange text
2019-05-02 16:07:26 +00:00
f832b96ad7
Merge branch 'use-keyword-args-for-databuilder-push' into 'master'
...
Use keyword args for databuilder push
See merge request gitlab-org/gitlab-ce!24088
2019-04-29 14:43:56 +00:00
fe86890b9d
Add deployment events to chat notification services
...
This enables sending a chat message to Slack or Mattermost
upon a successful, failed, or canceled deployment
2019-04-26 21:08:41 +00:00
f48605c796
Use all keyword args for DataBuilder::Push.build()
2019-04-25 13:54:26 +02:00
f27cba0fee
Fix private user email being visible in tag webhooks
...
Fixes #54721
2019-01-31 16:51:18 +01:00
6c0758f69b
Prefer build() rather than create()
2019-01-31 16:51:17 +01:00
ff0b2cc61f
Re-enable MethodCallWithoutArgsParentheses Cop
...
Re-enables and autocorrects all instances of the
Style/MethodCallWithoutArgsParentheses rule
2019-01-29 21:05:30 +02:00
57a4ee88ae
Add variables on pipeline webhook
2018-10-01 17:22:41 +00:00
e2118d831f
Test for failure_reason in job webhook
2018-08-20 12:54:46 +02:00
f0eaf22553
Rails5 fix MySQL milliseconds problem in specs
2018-06-27 18:49:22 +02:00
92482e01b4
Bump Gitaly to 0.98.0
...
Hooks were run for wikis, but given the internal API wasn't responding
failures happended, as seen on:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18693
2018-05-07 14:10:04 +02:00
52967b107b
Merge branch 'jej/mattermost-notification-confidentiality-10-6' into 'security-10-6'
...
[10.6] Prevent notes on confidential issues from being sent to chat
See merge request gitlab/gitlabhq!2366
# Conflicts:
# app/helpers/services_helper.rb
2018-04-05 08:41:56 +02:00
6253d4456a
Backport changes from EE's GithubService integration
...
Adds detailed_status to pipeline hook data
Adds detailed_description option for Services
Integration edit page renders 404 if a service is disabled
2018-03-07 17:50:10 +00:00
8fe9995f11
Replace deprecated name_with_namespace with full_name in app and spec
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2018-03-05 16:15:26 +02:00
a31e0aff22
Resolve "Error 500 in non-UTF8 branch names"
2017-09-12 14:07:31 +00:00
c8b802471b
Enable the RSpec/HookArgument cop and auto-correct offenses
2017-08-10 19:29:42 -04:00
ddccd24c13
Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
e0ab5618a0
Wrong data type when testing webhooks
2017-07-20 15:12:06 +00:00
0430b76441
Enable Style/DotPosition Rubocop 👮
2017-06-21 13:48:12 +00:00
47b8516c15
Add username field to push webhook
...
Signed-off-by: David Turner <novalis@novalis.org>
2017-05-10 17:11:36 -04:00
29d5a7ab75
Merge branch '26500-informative-slack-notifications' into 'master'
...
Adding links to user & build stage in a Build message
Closes #26500
See merge request !8641
2017-02-17 13:04:01 +00:00
80a6d2fda2
Use `:empty_project` where possible throughout spec/lib
2017-01-25 12:25:42 -05:00
d5fa77d53d
Adding links to user & build in Chat Notifications
2017-01-25 21:48:57 +05:30
c90483406e
refactors tests because of gitlab-test repository changes
2016-10-11 16:33:06 +01:00
d5264e8804
Simplify the name for data builder, feedback:
...
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5620#note_13671791
2016-08-12 16:09:29 +08:00
ce4a669d03
Prefer described_class, feedback:
...
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5620#note_13810811
And other similar places.
2016-08-12 15:16:31 +08:00
99928aca75
Enhance a pipeline event tests to analyse number of returned builds
2016-08-11 17:23:35 +02:00
984367f957
Move those builders to their own namespace, feedback:
...
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5620#note_13540099
2016-08-04 23:44:27 +08:00
GitLab Bot
Bian Jiaping
Stan Hu
Thong Kuah
Sean McGivern
Sujay Patel
Shinya Maeda
Jason Goodman
Douglas Barbosa Alexandre
Jonathon Reinhart
Luke Duncalfe
Andrew Newdigate
Pierre Tardy
Maciej Sokolowski
Jasper Maes
Zeger-Jan van de Weg
Douwe Maan
James Edwards-Jones
Dmitriy Zaporozhets
Micael Bergeron
Robert Speicher
Rémy Coutable
Alexander Randa
Grzegorz Bizon
David Turner
Kamil Trzciński
Poornima M
tiagonbotelho
Lin Jen-Shin