Fixes deprecation warning:
```
DEPRECATION WARNING: The success? predicate is deprecated and
will be removed in Rails 6.0.
Please use successful? as provided by Rack::Response::Helpers.
```
These specs were flaky and only passing after a retry due to how
rspec-retry works.
1. The test with paths that don't exist was returning 200 on the first
try, then 404 on the second, not because the paths don't exist, but
because the MR IID didn't change, thus the MR couldn't be found.
I decided to remove the test entirely since we don't seem to return
404 for paths that don't exist.
2. The test with a user that cannot view the merge request was failing
the first time because the project owner wasn't removed with
`project.team.truncate`.
Changing the `let(:user)` to `create(:user)` and calling
`project.add_maintainer(user)` in the `before` block fix the test.
Signed-off-by: Rémy Coutable <remy@rymai.me>
Updates specs to use new rails5 format.
The old format:
`get :show, { some: params }, { some: headers }`
The new format:
`get :show, params: { some: params }, headers: { some: headers }`
GitLab Bot
Vitali Tatarintev
Peter Leitzen
gfyoung
Rémy Coutable
blackst0ne
Oswaldo Ferreira
Mark Chao
Felipe Artur
micael.bergeron
Jacopo
Bob Van Landuyt
Robert Speicher
Douwe Maan