Commit Graph

318 Commits

Author SHA1 Message Date
Kamil Trzciński 8391fa37f0 Merge branch '12818-expose-simple-cicd-status-endpoints-with-status-serializer-gitlab-ci-status-for-pipeline-job-and-merge-request' into 'master'
Expose CI/CD status API endpoints with Gitlab::Ci::Status facility on pipeline, job and merge request for favicon

See merge request !9561
2017-03-27 12:21:22 +00:00
Tomasz Maczukin 3878a774f1
Fix after_script processing for Runners APIv4 2017-03-23 16:10:06 +01:00
Shinya Maeda 448c695c2a Revert adding favicon to extended statuses. Change extended statues specs to use core status 2017-03-23 17:11:49 +09:00
Shinya Maeda 74f13e0ddf Fix unchanged structure. Add favicon for 'failed_allowed' and 'success_warning' because it'll be used. 2017-03-23 17:11:49 +09:00
Shinya Maeda 49f9ab9064 Add spec for spec/lib/gitlab/ci/status 2017-03-23 17:11:49 +09:00
Shinya Maeda 21e62c9ef9 Roolback unneccesary changes 2017-03-23 17:11:49 +09:00
Shinya Maeda 04b1741cd1 Remove def favicon from extended status 2017-03-23 17:11:48 +09:00
Shinya Maeda 6d6127f665 change favicon name 2017-03-23 17:11:48 +09:00
Shinya Maeda ba27f1b954 Expose only status. ci_cd_status to status. Support abstract class. 2017-03-23 17:11:48 +09:00
Shinya Maeda 0e06cfc059 Add api points for ci cd status. Add favicon. 2017-03-23 17:11:48 +09:00
Grzegorz Bizon 7319460c18 Verbosify blocked pipeline status description 2017-03-08 09:10:20 +01:00
Kamil Trzciński fb4a486605 Merge branch 'feature/runner-jobs-v4-api' into 'master'
Feature/runner jobs v4 api

Closes #28513

See merge request !9273
2017-03-07 13:53:26 +00:00
Tomasz Maczukin 32b09b8847
Add minor refactoring 2017-03-07 12:30:34 +01:00
Lin Jen-Shin fb167787f2 Merge remote-tracking branch 'upstream/master' into set-default-cache-key-for-jobs
* upstream/master: (289 commits)
  re-add Assign to Me link on new MR/Issue forms
  thinner bottom header border
  make header match old 16px padding of body contents
  Update font-awesome-rails to 4.7.0.1
  Relax font-awesome-rails dependency to ~> 4.7
  Restore keyboard shortcuts for "Activity" and "Charts"
  fix border radius bottom for header
  match padding for mr-widget sections
  Update changelog
  Fix project-last-commit alignment
  Docs: update GL Pages IP on GL.com
  Fix up @DouweM review
  Remove readme-only project view preference
  Add `uploads` to known models for Import/Export spec
  Add `has_many` associations for models that can have Upload records
  Handle relative and absolute Upload paths in the Uploaders
  Change the default CarrierWave root path for tests
  Fix Projects::UploadService spec
  Add a Project::UploadsController spec to ensure an Upload is created
  Add `RecordsUploads` module to record Upload records via callbacks
  ...
2017-03-07 16:55:03 +08:00
Grzegorz Bizon bb2460c1ea Improve specs for detailed statuses with manual actions 2017-03-06 14:08:55 +01:00
Grzegorz Bizon 66dd209661 Ignore job by default if it is a manual action
This makes it possible to maintain backwards compatibility with configs
created when manual actions were non-blocking.

From now manual actions are blocking if configured with `allow_failure:
false`, otherwise manual actions are optional, and their status is
ignored.
2017-03-06 12:01:33 +01:00
Grzegorz Bizon ac5bd3b73c Reinstitute a core `manual` status for manual actions 2017-03-06 10:04:04 +01:00
Grzegorz Bizon 14351f9767 Introduce core status for blocked manual actions 2017-03-06 10:04:04 +01:00
Grzegorz Bizon 79ea01bfaf Refactor code related to pipeline blocking actions 2017-03-06 10:04:04 +01:00
Kamil Trzcinski be039d22d7 Make manual actions blocking 2017-03-06 10:04:04 +01:00
Lin Jen-Shin 0fe0b044e4 No need to set cache:key if no path was specified
Feedback:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9666/diffs#note_24607518
2017-03-03 22:21:46 +08:00
Lin Jen-Shin a00520b15d Restore Unspecified and we could discuss later
Also feedback in:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9666/diffs#note_24608283
2017-03-03 16:55:01 +08:00
Tomasz Maczukin 5c1aa5fb65
Add some fixes and refactoring after review 2017-03-02 17:48:00 +01:00
Tomasz Maczukin 1bbf2c2cd1
Fix rubocop offenses 2017-03-02 17:45:46 +01:00
Tomasz Maczukin fb8210ad19
Update step data naming 2017-03-02 17:45:45 +01:00
Tomasz Maczukin bbf5bb7070
Fix rubocop offenses 2017-03-02 17:45:45 +01:00
Tomasz Maczukin 3eafffcef0
Refactor JobRequest response structure 2017-03-02 17:45:45 +01:00
Lin Jen-Shin dc3a41f405 Fix tests for added default cache key 2017-03-03 00:30:22 +08:00
Lin Jen-Shin 6e032d7ba0 Set default cache key for jobs, detail:
* Replace Unspecified with a field so that it's less surprising
* Define inspect for Node for easy debugging (and avoid building
  a very huge string potentially from built-in inspect)
* Set default cache key to 'default'
2017-03-02 22:12:15 +08:00
Sean McGivern 811e598f60 Enable and autocorrect the CustomErrorClass cop 2017-03-01 15:28:10 +00:00
Douwe Maan f88ff0cc0c Stylistic tweaks 2017-02-23 09:33:20 -06:00
Douwe Maan 56de781a2c Revert "Enable Style/DotPosition"
This reverts commit e00fb2bdc2090e9cabeb1eb35a2672a882cc96e9.

# Conflicts:
#	.rubocop.yml
#	.rubocop_todo.yml
#	lib/gitlab/ci/config/entry/global.rb
#	lib/gitlab/ci/config/entry/jobs.rb
#	spec/lib/gitlab/ci/config/entry/factory_spec.rb
#	spec/lib/gitlab/ci/config/entry/global_spec.rb
#	spec/lib/gitlab/ci/config/entry/job_spec.rb
#	spec/lib/gitlab/ci/status/build/factory_spec.rb
#	spec/lib/gitlab/incoming_email_spec.rb
2017-02-23 09:33:19 -06:00
Douwe Maan 1fe7501b49 Revert "Prefer leading style for Style/DotPosition"
This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.
2017-02-23 09:33:05 -06:00
Douwe Maan e2bbbb1a9a Fix new offenses 2017-02-23 09:32:42 -06:00
Douwe Maan 75f5fa997d Enable Rails/Delegate 2017-02-23 09:32:42 -06:00
Douwe Maan eacae00516 Enable Style/MultilineHashBraceLayout 2017-02-23 09:32:22 -06:00
Douwe Maan 206953a430 Prefer leading style for Style/DotPosition 2017-02-23 09:32:22 -06:00
Douwe Maan 5c7f9d69e3 Fix code for cops 2017-02-23 09:31:57 -06:00
Douwe Maan b7d8df503c Enable Style/MutableConstant 2017-02-23 09:31:56 -06:00
Douwe Maan 3dadf306dd Enable Style/DotPosition 2017-02-23 09:31:56 -06:00
Rémy Coutable 6a1b3ef73f Merge branch 'zj-drop-ruby-21-tests' into 'master'
Update Rubocop to Ruby 2.3

See merge request !8994
2017-02-13 10:22:38 +00:00
Z.J. van de Weg 128b1eae09 Update Rubocop to ruby 2.3 2017-02-07 15:16:46 +01:00
Grzegorz Bizon 149f67cc2e Remove coverage entry from global CI/CD options 2017-02-04 23:04:17 +01:00
Douwe Maan 93e98058ea Merge branch '20248-add-coverage-regex-in-job-yaml' into 'master'
Add ability to define a coverage regex in the .gitlab-ci.yml

Closes #20428

See merge request !7447
2017-02-02 17:01:52 +00:00
Kamil Trzciński 5ac590677f Merge branch '25910-convert-manual-action-icons-to-svg-to-propperly-position-them' into 'master'
Convert pipeline action icons to svg to have them propperly positioned

Closes #25910

See merge request !8766
2017-01-31 11:42:06 +00:00
Filipa Lacerda 7db05c4da1 Removed unused method 2017-01-26 19:56:07 +00:00
Lin Jen-Shin 050103f209 Make sure TraceReader uses Encoding.default_external
Encoding.default_external was chosen over
Encoding.default_internal because File.read is
returning Encoding.default_external, therefore
we should align with it. Alternatively, we could
force both of them to be Encoding.default_internal.

However, ideally this should be determined by different
projects. For example, some projects might want to use
an encoding different to what GitLab is using.

This might not happen soon though.

Closes #27052
2017-01-26 18:29:44 +08:00
Filipa Lacerda 4983fbaaf4 Remove unneeded 'borderless' from icons name 2017-01-25 15:44:45 +00:00
dimitrieh 066155704d added icons and fixed mini pipeline action dropdown icons 2017-01-25 15:44:44 +00:00
Leandro Camargo 441a9beec3 Make some other refinements to validation logic 2017-01-25 01:07:45 -02:00