a544e46bb0
Add a rubocop rule to check if a method 'redirect_to' is used without explicitly set 'status' in 'destroy' actions of controllers
2017-06-07 09:45:16 +11:00
49697bc8df
Refactor to more robust implementation
...
In order to avoid string manipulation or modify route params (to make them unambiguous for `url_for`), we are accepting a behavior change:
When being redirected to the canonical path for a group, if you requested a group show path starting with `/groups/…` then you’ll now be redirected to the group at root `/…`.
2017-05-19 09:13:27 -07:00
56fb7823f9
Merge branch '17361-redirect-renamed-paths' into 'master'
...
Resolve "Redirect to new project link after a rename"
Closes #17361 and #30317
See merge request !11136
2017-05-06 05:45:56 +00:00
b51f2a6080
Colorize labels in issue search field
2017-05-05 22:47:32 +00:00
f05469f99b
Resolve discussions
2017-05-05 12:12:50 -07:00
9e48f02ea8
Dry up routable lookups. Fixes #30317
...
Note: This changes the behavior of user lookups (see the spec change) so it acts the same way as groups and projects. Unauthenticated clients attempting to access a user page will be redirected to login whether the user exists and is publicly restricted, or does not exist at all.
2017-05-05 12:12:50 -07:00
7d02bcd2e0
Redirect from redirect routes to canonical routes
2017-05-05 12:11:57 -07:00
52d59a4e51
Load milestone tabs asynchronously
2017-04-26 12:23:29 +01:00
395fca1493
Refactor members controller destroy action
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2017-04-17 17:44:30 +03:00
7de75920f7
Refactor controller code that creates project/group members
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2017-04-17 14:45:14 +03:00
b996a82ff4
ProjectsFinder should handle more options
...
Extended ProjectFinder in order to handle the following options:
- current_user - which user use
- project_ids_relation: int[] - project ids to use
- params:
- trending: boolean
- non_public: boolean
- starred: boolean
- sort: string
- visibility_level: int
- tags: string[]
- personal: boolean
- search: string
- non_archived: boolean
GroupProjectsFinder now inherits from ProjectsFinder.
Changed the code in order to use the new available options.
2017-04-06 07:11:37 +02:00
7c5198219a
MR empty state
2017-04-05 12:43:03 +00:00
38a108cac9
Fix a few N+1 queries identified by Bullet
...
See !10263
2017-04-02 05:42:11 -07:00
6dd7695444
Labels support color names in backend
2017-03-29 11:45:15 +00:00
50a8f16e16
Add count badges to both dashboard and group milestones
2017-03-10 13:04:19 +01:00
5f85487c15
Show parent group members for nested group
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2017-02-10 17:34:12 +02:00
f13c650c16
Speed up group milestone index by passing group_id to IssuesFinder
2017-01-06 13:47:18 +01:00
3a2905f507
Sort group/project members alphabetically by default
2016-12-16 20:28:38 -02:00
59d43bea80
Fix sort functionality for group/project members
2016-12-16 20:28:38 -02:00
09388b2021
Adds sort dropdown for group members
2016-12-16 20:28:33 -02:00
83232be0e1
Add nested groups support on data level
...
* add parent_id field to namespaces table to store relation with nested groups
* create routes table to keep information about full path of every group and project
* project/group lookup by full path from routes table
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-12-08 11:47:16 +02:00
3789cfe056
Add a starting date to milestones
2016-11-23 13:41:04 +02:00
198fe1bfc2
Add toggle_subscription action to Groups::LabelsController
2016-11-17 15:10:13 -02:00
579090c3a0
Require projects before creating milestone
2016-11-10 13:54:37 -05:00
f5659ac4d1
Add parentheses around return redirect_to method
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-10-24 13:14:00 +03:00
c82278898d
Refactor groups/projects members controller
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-10-24 13:14:00 +03:00
036fac06d1
Gracefully handle adding of no users to projects and groups
...
- Disable {project, group} members submit button if no users
If no users are selected, the submit button should be disabled.
- Alert user when no users were added to {project, group}.
When no users were selected for adding, an alert message is
flashed that no users were added.
- Also, this commit adds a feedback when users were actually added to a
project, in symmetry with how group members are handled.
Closes #22967 , #23270 .
2016-10-24 13:14:00 +03:00
355389d065
Disable subscribing to group-level labels
2016-10-19 14:58:28 -02:00
36fee24c80
Limit what label fields we expose on Groups::LabelsController#index
2016-10-19 14:58:26 -02:00
f98e97fe78
Reduce duplication between the project and group label forms
2016-10-19 14:58:26 -02:00
b10e5764ac
List only labels that belongs to the group on the group issues page
2016-10-19 14:58:24 -02:00
bdb7bf4b51
List group labels on project labels page
2016-10-19 14:58:24 -02:00
52e0c3b565
Add CRUD for Group Labels
2016-10-19 14:57:15 -02:00
c8b1311934
Fix a few things after the initial improvment to Members::DestroyService
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-03 16:57:48 +02:00
3158f57dba
Improve Members::DestroyService
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-03 16:57:48 +02:00
924a6b7d33
New AccessRequestsFinder
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-09-28 08:46:59 +02:00
396f85e438
Add expiration date to group memberships
2016-08-18 21:09:17 +01:00
bd78f5733c
Exclude requesters from Project#members, Group#members and User#members
...
And create new Project#requesters, Group#requesters scopes.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-07-01 17:44:46 +02:00
654565c9dc
Raise a new Gitlab::Access::AccessDeniedError when permission is not enough to destroy a member
...
This is a try for a new approach to put the access checks at the service level.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-18 06:06:34 +02:00
6c5b2377f7
Use the new Members::DestroyService in group/project member controllers
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-18 05:46:45 +02:00
33c61bd461
Re-use notifications dropdown/modal for user profile
2016-06-17 00:17:20 -03:00
f82ab42d05
Re-use notifications dropdown on user profile
2016-06-16 23:34:21 -03:00
515205d3c1
UI and copywriting improvements
...
+ Move 'Edit Project/Group' out of membership-related partial
+ Show the access request buttons only to logged-in users
+ Put the request access buttons out of in a more visible button
+ Improve the copy in the #remove_member_message helper
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-14 13:18:14 +02:00
d71fbe0dbd
Factorize #request_access and #approve_access_request into a new AccessRequestActions controller concern
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-14 13:07:26 +02:00
d26f81239a
Add request access for groups
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-14 13:07:26 +02:00
253a017b01
Merge branch 'meinac/gitlab-ce-change_deprecated_render_usage'
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-05-18 12:48:23 -05:00
bee28e1785
Requires user to be signed in when changing notification settings
2016-04-11 20:50:26 -03:00
93a10f17e0
Reuse `User#notification_settings_for` when it's possible
2016-04-11 20:50:26 -03:00
127119f2c4
Simplify query to retrieve NotificationSetting on controllers
2016-04-08 16:59:06 -03:00
7afeace354
Merge branch 'master' into decouple-member-notification
2016-04-08 15:48:09 -03:00
blackst0ne
Michael Kozono
Sean McGivern
Winnie Hellmann
Phil Hughes
Dmitriy Zaporozhets
Jacopo
Luke "Jared" Bennett
Stan Hu
Dongqing Hu
Alex Braha Stoll
Adam Niedzielski
Douglas Barbosa Alexandre
Nur Rony
Valery Sizov
gfyoung
Linus G Thiel
Rémy Coutable
Sean McGivern
Felipe Artur