Imre Farkas
bd3a484032
Add config to disable impersonation
...
Adds gitlab.impersonation_enabled config option defaulting to true to
keep the current default behaviour.
Only the act of impersonation is modified, impersonation token
management is not affected.
2018-11-29 09:37:16 +01:00
gfyoung
73322a0e55
Enable frozen string in app/controllers/**/*.rb
...
Enables frozen string for the following:
* app/controllers/*.rb
* app/controllers/admin/**/*.rb
* app/controllers/boards/**/*.rb
* app/controllers/ci/**/*.rb
* app/controllers/concerns/**/*.rb
Partially addresses #47424 .
2018-09-18 21:22:45 -07:00
Yorick Peterse
2039c8280d
Disable existing offenses for the CodeReuse cops
...
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
2018-09-11 17:32:00 +02:00
Lin Jen-Shin
4ee08b77bc
Updates from `rubocop -a`
2018-07-09 21:13:08 +08:00
Lin Jen-Shin
b23428d664
Bring changes from EE
2018-06-25 21:11:00 +08:00
blackst0ne
3d3b46f344
[Rails5] Rename `sort` methods to `sort_by_attribute`
2018-04-04 09:19:47 +00:00
Douwe Maan
0c0c2ecd99
Merge branch 'master' into digitalmoksha/gitlab-ce-feature/verify_secondary_emails
...
# Conflicts:
# app/controllers/admin/users_controller.rb
# app/controllers/confirmations_controller.rb
# app/controllers/profiles/emails_controller.rb
# app/models/user.rb
# app/services/emails/base_service.rb
# app/services/emails/destroy_service.rb
# app/views/devise/mailer/confirmation_instructions.html.haml
# lib/api/users.rb
# spec/services/emails/destroy_service_spec.rb
2017-10-05 12:48:22 +02:00
James Lopez
1dcb711110
refactor emails service
2017-09-28 08:46:39 +02:00
James Lopez
67d06dee30
refactor users update service
2017-09-28 08:46:39 +02:00
James Lopez
9621dd0c9d
refactor services to match EE signature
2017-09-28 08:46:39 +02:00
Brett Walker
b2d5379161
fix calls to Emails::DestroyService
2017-09-23 15:24:53 +02:00
Annabel Dunstone Gray
9b177bb7c9
Revert "Merge branch 'revert-f2421b2b' into 'master'"
...
This reverts merge request !14148
2017-09-11 15:44:42 +00:00
Rubén Dávila
52a2423e37
Revert "Merge branch '35012-navigation-add-option-to-change-navigation-color-palette' into 'master'"
...
This reverts merge request !13619
2017-09-08 14:48:44 +00:00
Douwe Maan
523a1c69ab
Merge branch '23079-remove-default-scope-in-sortable' into 'master'
...
Removes default scope from sortable
Closes #23079
See merge request !13558
2017-09-07 16:15:32 +00:00
Tiago Botelho
cfd475a45e
Removes default scope from sortable
2017-09-07 13:01:59 +01:00
Rubén Dávila
6c49a62800
Restore some changes from !9199
2017-09-06 12:54:09 -05:00
Tiago Botelho
0ffa4772c2
Changes the password change workflow for admins.
2017-08-31 12:25:24 +01:00
James Lopez
efb3d5e70f
fix spec failures
2017-06-23 19:00:22 +02:00
James Lopez
b33c638483
update code based on feedback
2017-06-23 17:11:31 +02:00
James Lopez
b804db2648
refactor update user service not to do auth checks
2017-06-23 11:41:43 +02:00
James Lopez
e2e0b175ae
fix specs
2017-06-23 11:41:43 +02:00
James Lopez
4c75fe5dfe
add missing action to block
2017-06-23 11:41:42 +02:00
James Lopez
c9fd3dc42c
more refactoring based on feedback
2017-06-23 11:41:42 +02:00
James Lopez
785cbb79e2
refactor emails service
2017-06-23 11:41:42 +02:00
James Lopez
3bab585bec
update to use emails destroy service
2017-06-23 11:41:42 +02:00
James Lopez
bf3a3f3652
fix api and controller issues
2017-06-23 11:41:41 +02:00
James Lopez
36bc2e9016
fix specs
2017-06-23 11:41:41 +02:00
James Lopez
aa158dd731
finish off refactoring users controller
2017-06-23 11:41:41 +02:00
James Lopez
85b5a8cfa6
update users controller
2017-06-23 11:41:41 +02:00
blackst0ne
a544e46bb0
Add a rubocop rule to check if a method 'redirect_to' is used without explicitly set 'status' in 'destroy' actions of controllers
2017-06-07 09:45:16 +11:00
Nick Thomas
f09b7f5607
Support hard deletion in Admin::UsersController#destroy
2017-06-05 17:48:57 +01:00
George Andrinopoulos
7c74a0209b
Implement new service for creating user
2017-03-27 09:37:24 +00:00
http://jneen.net/
66f204e0f0
get the logic right :X
2017-03-09 12:02:56 -08:00
http://jneen.net/
b88314f4ad
consolidate the error handling for #impersonate
2017-03-09 11:50:11 -08:00
http://jneen.net/
dfe41c1556
protect internal users from impersonation
2017-03-09 11:49:52 -08:00
Annabel Dunstone Gray
0667d1aa7f
Drop theme ID from users table
2017-02-15 13:31:18 -06:00
Jose Ivan Vargas
426680def4
Backport of the frontend view, including tests
2017-02-06 16:17:46 -06:00
Rémy Coutable
d8d9d0c74c
Refactor authorized params in Admin::UsersController
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-01-11 16:52:30 -05:00
James Gregory
b21024684b
Merged the 'groups' and 'projects' tabs when viewing user profiles
2016-12-29 22:42:16 +00:00
Yar
f853058010
Allow to search for user by secondary email address in the admin interface
...
It is not possible to search for a user by his secondary email address in
the Users search bar in the admin interface(/admin/users). A use-case could
be that an admin wants to remove a specific secondary email address of an
user, because it interferes with another user. Issue #23761
This commit adds ability to search not only by main email, but also
by any secondary email in the admin interface.
2016-11-01 17:58:03 +03:00
Yar
6893bccd06
Rename :name search parameter to :search_query at /admin/users
...
The parameter is used to search users by several criretia was
called :name. This request renames it to :search_query which closer
to it actual perpose
2016-11-01 17:52:16 +03:00
Dmitriy Zaporozhets
253a017b01
Merge branch 'meinac/gitlab-ce-change_deprecated_render_usage'
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-05-18 12:48:23 -05:00
Sean McGivern
bec350528c
Force password change after admin reset
...
When an admin changes a user's password for them, force the user to
reset the password after logging in by expiring the new password
immediately.
2016-05-16 09:21:24 +01:00
Stan Hu
731b231357
Log to application.log when an admin starts and stops impersonating a user
...
Closes gitlab-org/gitlab-ee#536
2016-05-04 09:21:34 -07:00
Douwe Maan
d3462e711c
Fix issue with impersonation
2016-04-22 23:21:56 +02:00
Douwe Maan
21af7459ab
Merge branch '4009-external-users' into 'master'
...
External Users
The user has the rights of a public user execpt it can never create a project, group, or team. Also it cant view internal projects.
Partially fix for both #4009 and #13938 (except the LDAP sync or a pattern to detect external users)

See merge request !3171
2016-03-17 14:15:38 +00:00
Mehmet Emin İNAÇ
6a0ea605e8
Change deprecated usage of rendering without response body
...
`render nothing: true` has been deprecated.
For more information see [pr](https://github.com/rails/rails/pull/20336 )
2016-03-16 03:16:25 +02:00
Zeger-Jan van de Weg
b221d11a25
Add ability to delete a user with force
2016-03-15 21:09:25 +01:00
Zeger-Jan van de Weg
4bcc097750
A worker deletes a user, so the request doesn't time out
...
Fixes #13261
2016-03-15 21:09:25 +01:00
Zeger-Jan van de Weg
42fcd3881f
External Users
...
The user has the rights of a public user execpt it can never create a project,
group, or team. Also it cant view internal projects.
2016-03-13 19:08:04 +01:00