Commit Graph

83 Commits

Author SHA1 Message Date
Mike Greiling 603c748ca3 Remove trailing commas to satisfy rubocop 2018-11-08 23:28:30 +13:00
Thong Kuah 5a042ef2fb Only project clusters has Project Namespace field
Group clusters should not allow Project Namespace so don't show that
field input too
2018-11-08 23:28:30 +13:00
Thong Kuah 5303718402 Minor updates to spec for readability
Based on BE reviewer feedback
2018-11-08 23:26:04 +13:00
Mayra Cabrera 675bfd50a9 Adds feature flag for Group Clusters
As the frontend is still in progress and other related backend is still
in prgress we need a feature flag to turn off Group Clusters.
2018-11-08 23:26:04 +13:00
Thong Kuah 54e8ff0f21 Extend clusters_controller for group type clusters
- Add pages javascripts to intialize clusters for group pages

- Move specs asserting gcp specific validations from controller into
UpdateService spec

- Also teach Clusters::ApplicationController about groups
2018-11-08 23:14:06 +13:00
Brett Walker 13dbfa90d2 Fix transient error with boards_controller_spec 2018-11-03 10:33:19 -05:00
George Tsiolis 733ae94921 Fix typos in comments and specs 2018-11-01 08:59:20 +02:00
Brett Walker c11cb0b38f Fix problem with spec that showed up in EE merge 2018-10-29 20:39:24 -05:00
Brett Walker 7aeab58f48 Automatically navigate to last board visited 2018-10-26 12:49:16 +00:00
Tomasz Maczukin 42af229510
Simplify runner registration token resetting
This icommit adds several changes related to the same topic
- resetting a Runner registration token:

1. On Project settings page it adds a button for resetting the
   registration token and it removes the Runner token field
   that was confusing all GitLab users.

2. On Group settings page it adds the same button for resetting
   the registration token.

3. On Admin Runners settings page it moves the button to the same
   place as in Project and Group settings and it changes slightly
   the page layout to make it more similar to Group and Project
   setting pages.

4. It refactorizes a little the partial that prints runner
   registration description. Thanks to this Project, Group
   and Admin settings of the Runner are re-using the same
   code to generate the button.

5. Updates the translations of changed text.
2018-10-04 08:37:01 +02:00
Felipe Artur abb50ff471 Allow to delete group milestones 2018-08-06 17:31:47 -03:00
Mark Chao a63bce1a4b Resolve "Rename the `Master` role to `Maintainer`" Backend 2018-07-11 14:36:08 +00:00
Jan Provaznik 656d4ebf67 Add workhorse authorize method for project/group uploads
This method can be used by workhorse to get presigned
URLs used for direct upload of files.
2018-06-18 09:11:02 +02:00
Robert Speicher 6d165c740c Make all uses of `fixture_file_upload` use relative paths 2018-06-07 09:54:41 -05:00
Bob Van Landuyt 2f50b206f2 Hide archived projects from `shared_projects`
Since we don't show the archived projects, we shouldnot  load them and
pass them to the fronted to be filtered out again.
2018-06-04 17:43:13 +02:00
Kamil Trzciński 051f385e7e Refactor validations and make runner factory by default to be instance-wide runner 2018-05-31 10:56:07 +02:00
Dylan Griffith ab489d293d Improve runner_type validations for Ci::Runner 2018-05-31 10:46:19 +02:00
Toon Claes 1298fbe18d Fix small typos 2018-05-29 11:45:17 +02:00
Bob Van Landuyt 6072259230 Add `shared_projects` endpoint
This endpoint lists projects shared with a group visible to the
current user.

The `filter` and `sort` params are supported like on the `children` endpoint.
2018-05-29 11:45:17 +02:00
Dylan Griffith 91f358942e Allow to pause,resume,show,edit,destroy group runners (#10244) 2018-05-07 08:54:07 +02:00
Felipe Artur dd071c4b6e Bring one group board to CE 2018-03-03 12:56:17 -03:00
Jan Provaznik 1f4ee653fa Allow to include also descendant group labels
Because epic index page includes also epics from subgroups
it's necessary to also get descendant group labels for filtering.
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/4773#note_61236542
2018-03-02 11:44:18 +01:00
Jan Provaznik 911fd7c252 Support additional LabelsFinder parameters for group labels
In some situations (listing labels for epics) we want to
list only group ancestor labels, this is already supported
in LabelsFinder we just need to enable additional parameters.

Also `set_issuables_index` method now loads project labels only if
@project is set (which is not used for epic group labels).
2018-03-02 08:50:00 +01:00
Matija Čupić f7ed096455
Extract Variables controllers specs to shared_examples 2018-02-05 18:58:21 +01:00
Matija Čupić 45a14b4f58
Refactor Variable controllers specs 2018-02-05 18:58:21 +01:00
Matija Čupić 18232d7efb
Extract Variable into separate JSON Schema 2018-02-05 18:58:21 +01:00
Matija Čupić 558057010f
Extract variable parameters in VariablesController specs 2018-02-05 18:58:20 +01:00
Matija Čupić 04263b9f3b
Add GroupVariableSerializer for Ci::GroupVariable 2018-02-05 18:58:20 +01:00
Matija Čupić b48d8c8ad0
Return all variables after UPDATE 2018-02-05 18:58:19 +01:00
Matija Čupić 9eb3bb5cff
Change POST to PATCH requests in the controller specs 2018-02-05 18:58:19 +01:00
Matija Čupić 13f0e18d2f
Fix a typo in Groups::VariablesController spec 2018-02-05 18:58:19 +01:00
Matija Čupić a8887a0d9c
Use `resource` in Group Variables routing scheme 2018-02-05 18:58:19 +01:00
Matija Čupić 2592aec9e3
Use all parameters in VariablesController specs 2018-02-05 18:58:18 +01:00
Matija Čupić dcc23530bd
Remove redundant routes in Groups::VariablesController 2018-02-05 18:58:17 +01:00
Matija Čupić cc2bed9283
Port #save_multiple to Groups::VariablesController 2018-02-05 18:58:17 +01:00
Micaël Bergeron 2057a6acde port of 594e6a0a625^..f74c90f68c6 2018-02-01 12:14:46 -05:00
Bob Van Landuyt 26c4e47a0d Preload ancestors for subgroups matching filter
Otherwise we'd only preload the ancestors that would fit the
page. That way, when a search result was on the first page, but the
ancestor didn't fit the page anymore. We would not have the preloaded
ancestor when rendering the hierarchy.
2018-01-22 17:02:04 +01:00
blackst0ne 27c95364b5 Replace '.team << [user, role]' with 'add_role(user)' in specs 2017-12-22 19:18:28 +11:00
Rubén Dávila 429302b34c Bugfix: User can't change the access level of an access requester
The endpoint was returning 404 because it was only searching on the
current members of a Group or Project and not the access requesters.
2017-12-11 09:53:31 -05:00
Jarka Kadlecova f7c18ca314 Support uploads for groups 2017-12-07 12:27:52 +01:00
Bob Van Landuyt 5a335c4d95 Remove the selects when counting the last page
The last page of the first collection is only loaded into memory when
it is being viewed. If it isn't loaded into memory, the `#size` call
triggers a count query.

This `#count` would generate an invalid query if our custom preloaded
counts are included by adding a separate `as count_column` alias on
top of the count aliases. Removing the selects in this case will make
sure a valid `COUNT(*)` is generated.
2017-11-17 16:20:47 +01:00
Jacopo 2f40dac352 Refactor `have_http_status` into `have_gitlab_http_status` in the specs 2017-10-20 10:13:18 +02:00
Bob Van Landuyt 4d79159973 Make sure we always return an array of hierarchies
Even when we pass an array of only a single object
2017-10-13 15:15:45 +02:00
Bob Van Landuyt 2c25a7ae34 Nest the group_children_path inside the canonical group path 2017-10-12 11:36:55 +02:00
Robert Speicher 72a7b30c9f Change all `:empty_project` to `:project` 2017-08-02 17:47:31 -04:00
Felipe Artur b5f596c3ff Native group milestones 2017-07-07 15:08:49 +00:00
Shinya Maeda 8c434a52fc gb nice catches 2017-07-07 15:35:12 +09:00
Shinya Maeda 5b0954759c Basic BE change
Fix static-snalysis

Move the precedence of group secure variable before project secure variable. Allow project_id to be null.

Separate Ci::VariableProject and Ci::VariableGroup

Add the forgotton files

Add migration file to update type of ci_variables

Fix form_for fpr VariableProject

Fix test

Change the table structure according to the yorik advice

Add necessary migration files. Remove unnecessary migration spec.

Revert safe_model_attributes.yml

Fix models

Fix spec

Avoid self.variable. Use becomes for correct routing.

Use unique index on group_id and key

Add null: false for t.timestamps

Fix schema version

Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable

Rename the rest of them

Add the rest of files

Basic BE change

Fix static-snalysis

Move the precedence of group secure variable before project secure variable. Allow project_id to be null.

Separate Ci::VariableProject and Ci::VariableGroup

Add the forgotton files

Add migration file to update type of ci_variables

Fix form_for fpr VariableProject

Fix test

Change the table structure according to the yorik advice

Add necessary migration files. Remove unnecessary migration spec.

Revert safe_model_attributes.yml

Fix models

Fix spec

Avoid self.variable. Use becomes for correct routing.

Use unique index on group_id and key

Add null: false for t.timestamps

Fix schema version

Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable

Rename the rest of them

Add the rest of files

Implement CURD

Rename codes related to VariableGroup and VariableProject FE part

Remove unneccesary changes

Make Fe code up-to-date

Add protected flag to migration file

Protected group variables essential package

Update schema

Improve doc

Fix logic and spec for models

Fix logic and spec for controllers

 Fix logic and spec for views(pre feature)

Add feature spec

Fixed bugs. placeholder. reveal button. doc.

Add changelog

Remove unnecessary comment

godfat nice catches

Improve secret_variables_for arctecture

Fix spec

Fix StaticAnlysys & path_regex spec

Revert "Improve secret_variables_for arctecture"

This reverts commit c3216ca212322ecf6ca534cb12ce75811a4e77f1.

Use ayufan suggestion for secret_variables_for

Use find instead of find_by

Fix spec message for variable is invalid

Fix spec remove variable.group_id = group.id

godffat spec nitpicks

Use include Gitlab::Routing.url_helpers for presenter spec
2017-07-07 15:33:17 +09:00
Takuya Noguchi 5d4ec03687 Add tests for Groups::MilestonesController#index 2017-06-26 23:54:07 +09:00
Robert Speicher a6ec5121f0 Correct RSpec/SingleLineHook cop offenses 2017-06-14 13:18:56 -05:00