Commit Graph

693 Commits

Author SHA1 Message Date
Kamil Trzciński 0165cfaa07 Re-define default only except policy 2018-12-13 10:39:55 +00:00
Gilbert Roulot e6226e8cb3 Generalise test compare service
It adds a base class for CompareTestReportsService
containing common code with CompareLicenseManagementReportsService
which is present in GitLab Enterprise Edition.
2018-12-11 11:39:22 +01:00
Shinya Maeda e62bfc7817 Merge request pipelines 2018-12-05 15:57:52 +09:00
Shinya Maeda ad957a3f42 Define the default value for only/except policies
Currently, if a job does not have only/except policies, the policy is considered as an unspecified state, and therefore the job is executed regardless of how it's executed and which branch/tags are targetted.
Ideally, this should be specified as only: ['branches', 'tags'], as it indicates that unspecified policy jobs are meant to run on any git references.
2018-12-05 00:11:48 +09:00
Kamil Trzciński 64b1044e7a ci/config: generalize Config validation into Gitlab::Config:: module
This decouples Ci::Config to provide a common interface for handling
user configuration files.
2018-11-29 16:09:18 +01:00
Stan Hu 6c83c2d8b9 Merge branch 'lock-trace-writes' into 'master'
Lock writes to trace stream

Closes #51502

See merge request gitlab-org/gitlab-ce!23332
2018-11-27 20:56:40 +00:00
Kamil Trzciński 31a1ce2132 Lock writes to trace stream 2018-11-27 17:55:20 +01:00
Stan Hu deaf3af7e5 Merge branch 'fix-deadlock-chunked-io' into 'master'
Fix deadlock on ChunkedIO

See merge request gitlab-org/gitlab-ce!23329
2018-11-26 21:16:40 +00:00
Kamil Trzciński c150772edb Fix deadlock on ChunkedIO 2018-11-26 13:15:46 +01:00
Kamil Trzciński 56a01151d5 Allow to store null variables 2018-11-23 15:20:07 +01:00
Takuya Noguchi e902f462c2 Eliminate duplicated words
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
2018-11-22 01:01:23 +09:00
Sean McGivern 69f74582aa Merge branch 'improve-variables-support' into 'master'
Improve variables support

See merge request gitlab-org/gitlab-ce!23077
2018-11-19 15:57:53 +00:00
Kamil Trzciński c3bd3bfc6e Improve variables support
This ensures that variables accept only string,
alongside also improves kubernetes_namespace,
improving validation and default value being set.
2018-11-19 14:09:39 +01:00
Grzegorz Bizon 875bae16d0 Merge branch 'allow-to-use-glob-for-ci-changes-detection' into 'master'
Add glob for CI changes detection

See merge request gitlab-org/gitlab-ce!23128
2018-11-16 10:35:18 +00:00
Kirill Zaitsev 9bea3c0fbb Add glob for CI changes detection 2018-11-15 22:04:47 +02:00
George Tsiolis 566ba126f5 Fix typos in lib 2018-11-15 12:15:43 +02:00
Kamil Trzciński 036c9c58ba Limit parallel to 100
This prevents some of the abusive behaviors, of someone putting 100000 and creating out of memory condition easily
2018-11-08 11:58:54 +01:00
Grzegorz Bizon f323d6148b Merge branch 'max_retries_when' into 'master'
Allow to configure when to retry builds

Closes gitlab-runner#3515

See merge request gitlab-org/gitlab-ce!21758
2018-11-07 15:02:18 +00:00
Markus Doits 0c59fdaab6
fix merge conflict 2018-11-07 14:21:44 +01:00
Markus Doits 3aa85715dd
change forgotten constant in spec to match code 2018-11-07 13:05:24 +01:00
Markus Doits c68f527035
fix failing specs due to latest changes 2018-11-07 13:05:15 +01:00
Markus Doits 9818bb5618
refactoring after latest feedback 2018-11-07 13:04:43 +01:00
Markus Doits 7c5c1e9240
fix wrong retry error messages 2018-11-07 13:04:23 +01:00
Markus Doits b7ee04d456
refactor validations to a Entry::Retry class 2018-11-07 13:04:21 +01:00
Markus Doits 48f37a92be
add a test that checks that retry when values in documentation are valid 2018-11-07 13:04:03 +01:00
Markus Doits fdb5a51352
refactor for hopefully lower cognitive complexity
before:

- Method `validate_retry` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
- Method `validate_retry_max` has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
- Method `validate_retry_when` has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
2018-11-07 13:02:56 +01:00
Markus Doits ffcc200a68
fix allowed keys validator to use correct attribute as error base? 2018-11-07 13:01:57 +01:00
Markus Doits 0db50a808d
update job config validator to validate new retry syntax 2018-11-07 13:01:53 +01:00
Matija Čupić 126fbe580f
Return untouched hash if no job is parallelized 2018-11-07 13:01:33 +01:00
Grzegorz Bizon 6f6cd4f43d Merge branch '21480-parallel-job-keyword-mvc' into 'master'
Resolve "`parallel` job keyword MVC"

Closes #21480

See merge request gitlab-org/gitlab-ce!22631
2018-11-07 10:38:05 +00:00
Winnie Hellmann 390abbf054 Add placeholder for remaining time in delayed job tooltips 2018-11-07 10:00:25 +01:00
Matija Čupić 7366c319df
Add additional specs for Normalizer 2018-11-06 18:56:06 +01:00
Matija Čupić 4ba960c17d
Use instance based approach for Normalizer 2018-11-06 18:35:44 +01:00
Matija Čupić f48261a409
Refactor Normalizer specs 2018-11-06 18:23:45 +01:00
Kamil Trzciński e65162842c Fix invalid artifact path for codequality 2018-11-05 17:32:03 +01:00
Matija Čupić 4b2b154c4e
Refactor Gitlab::Ci::Config::Normalizer
Use Hash#each_with_object to manipulate job hashes.
2018-11-05 15:53:37 +01:00
Matija Čupić 5fd8933d97
Use instance based approach for Normalizer 2018-11-05 14:36:52 +01:00
Matija Čupić 8a6a312db8
Make Rubocop and Danger happy 2018-11-02 14:20:27 +01:00
Matija Čupić 73e17446ef
Move parallelized node index to job options 2018-11-01 16:18:27 +01:00
Matija Čupić 77715e47d6
Add Normalizer specs 2018-11-01 15:24:29 +01:00
Achilleas Pipinellis 7f47e13218 Merge branch 'gt-update-typos-in-comments-and-specs' into 'master'
Fix typos in comments and specs

See merge request gitlab-org/gitlab-ce!22683
2018-11-01 10:34:23 +00:00
George Tsiolis 733ae94921 Fix typos in comments and specs 2018-11-01 08:59:20 +02:00
Matija Čupić 56a08d233f
Parallelize jobs in Gitlab::Ci::YamlProcessor 2018-11-01 01:05:42 +01:00
Matija Čupić 94923328fd
Revert Seed based parallelization implementation
Revert "Add Build seed specs"

This reverts commit 03bc722ea1.

Revert "Add build specs"

This reverts commit c2d49565cf.

Revert "Refactor parallelization implementation"

This reverts commit 72430483de.

Revert "Implement POC for job parallelization"

This reverts commit 44b740f99d.
2018-10-30 15:06:00 +01:00
Marcel Amirault 14fc739c94 Renaming Secret Variables in the codebase 2018-10-30 08:49:26 +00:00
Matija Čupić 9ba72fe09a
Change minimum parallel value to 2 2018-10-27 19:06:46 +02:00
Matija Čupić 03bc722ea1
Add Build seed specs 2018-10-27 18:52:47 +02:00
Matija Čupić a12da215c9
Add YamlProcessor specs 2018-10-27 18:21:32 +02:00
Matija Čupić d9b56bc13b
Add parallel keyword to CI config 2018-10-26 22:02:18 +02:00
Grzegorz Bizon 708875ae9e Merge branch 'support-license-management-and-performance' into 'master'
Support licenses and performance

See merge request gitlab-org/gitlab-ce!22175
2018-10-23 12:07:05 +00:00