Vladimir Shushlin
ac744fd4fc
Remove disabled pages domains
...
Domain will be removed by verification worker after 1 week
of being disabled
2019-04-30 12:05:54 +00:00
Evan Read
c5305a02e3
Docs aren't reviewed using roulette
2019-04-30 10:38:46 +00:00
Francisco Javier López
6f0d8ebc45
Refactored LfsImportService and ImportService
...
In order to make `LfsImportService` more reusable, we
need to extract the logic inside `ImportService` and
encapsulate it into the service.
2019-04-30 08:21:21 +00:00
Sean McGivern
c10d009191
Merge branch 'sh-disable-batch-load-replace-methods' into 'master'
...
Disable method replacement in avatar loading
Closes #60903
See merge request gitlab-org/gitlab-ce!27866
2019-04-30 07:55:48 +00:00
Stan Hu
3c52ff8c78
Add a newline in spec for readability
2019-04-29 22:55:14 -07:00
Dylan Griffith
f84fae1386
Rename #timeouted -> #timed_out
2019-04-29 22:55:13 -07:00
Dylan Griffith
dbb284de5a
Minor refactor of prometheus_spec
2019-04-29 22:55:13 -07:00
Dylan Griffith
416f3971e6
Minor refactoring in check_uninstall_progress_service_spec
2019-04-29 22:55:13 -07:00
Dylan Griffith
0a4817dd77
In Prometheus use update! instead of update
...
In order to not miss any errors since we are not checking the return
value of update
2019-04-29 22:55:12 -07:00
Dylan Griffith
3cac5b05b2
Fix uninstall specs: helm not uninstallable
2019-04-29 22:55:12 -07:00
Thong Kuah
024ddcab17
Deactivate any prometheus_service upon destroy
...
Basically does the reverse of after_transition to :installed.
2019-04-29 22:55:12 -07:00
Dylan Griffith
eae0fc2bcd
Remove xit test for uninstall group cluster app
2019-04-29 22:55:12 -07:00
Thong Kuah
abb530a619
DELETE clusters/:id/:application endpoint
...
Add endpoint to delete/uninstall a cluster application
2019-04-29 22:55:12 -07:00
Thong Kuah
43c284b711
Teach Prometheus about #uninstall_command
...
Add specs
2019-04-29 22:55:12 -07:00
Thong Kuah
44eec56834
Expose can_uninstall in cluster_status.json
...
Only prometheus can be uninstalled atm, the rest will be dealt with
later.
Presumption is that new application types will have uninstallation
implmemented at the same time.
2019-04-29 22:55:11 -07:00
Thong Kuah
3c8df0c944
Destroy app on successful uninstallation
...
Rescue and put into :uninstall_errored if something goes wrong while
destroying, which can happen. I think it is safe to expose the full
error message from the destroy error.
Remove the :uninstalled state as no longer used.
2019-04-29 22:55:11 -07:00
Thong Kuah
938e90f472
Services to uninstall cluster application
...
+ to monitor progress of uninstallation pod
2019-04-29 22:55:11 -07:00
Thong Kuah
33a765c17a
Teach Helm::Api about #uninstall
2019-04-29 22:55:11 -07:00
Thong Kuah
43be4d54f3
Define state transitions for uninstalling apps
...
Added :uninstalled state as wasn't sure if we should be destroying the
cluster apps
2019-04-29 22:55:11 -07:00
Stan Hu
25818bd7ae
Disable method replacement in avatar loading
...
We've seen a significant performance penalty when using
`BatchLoader#__replace_with!`. This defines methods on the batch loader
that proxy to the 'real' object using send. The alternative is
`method_missing`, which is slower. However, we've noticed that
`method_missing` can be faster if:
1. The objects being loaded have a large interface.
2. We don't call too many methods on the loaded object.
Avatar uploads meet both criteria above, so let's use the newly-released
feature in https://github.com/exAspArk/batch-loader/pull/45 .
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60903
2019-04-29 21:29:25 -07:00
Shinya Maeda
96b28d8387
Fix ref_text of merge request pipelines
...
Source branch can be removed after the merge and
we have to make sure to avoid rendering links if it's the case.
2019-04-30 10:14:19 +07:00
Ash McKenzie
5d5b9d57de
Merge branch '60476-actionview-missingtemplate-missing-template-projects-issues-_merge_requests-with-locale-en-formats-html-varian' into 'master'
...
Delete leftover code for referenced_merge_requests endpoint
Closes #60476
See merge request gitlab-org/gitlab-ce!27335
2019-04-30 00:34:49 +00:00
Tim Zallmann
6050de1999
Merge branch '61036-fix-ingress-base-domain-text' into 'master'
...
Fix base domain help text update
Closes #61036
See merge request gitlab-org/gitlab-ce!27746
2019-04-29 18:21:04 +00:00
Rémy Coutable
394c05d4d5
Merge branch '59265-project-is-being-serialized-when-enqueueing-to-sidekiq' into 'master'
...
Resolve "Project is being serialized when enqueueing to sidekiq"
Closes #59265
See merge request gitlab-org/gitlab-ce!27825
2019-04-29 17:48:53 +00:00
Stan Hu
ca8e5aded8
Merge branch 'lock-pipeline-schedule-worker' into 'master'
...
Prevent concurrent execution of PipelineScheduleWorker
Closes gitlab-com/gl-infra/production#805
See merge request gitlab-org/gitlab-ce!27781
2019-04-29 17:18:34 +00:00
Sean McGivern
f84992f13c
Merge branch 'sh-add-full-backtrace-rspec' into 'master'
...
Add full backtrace for RSpec output
See merge request gitlab-org/gitlab-ce!27686
2019-04-29 16:29:37 +00:00
Sean McGivern
ac74d641ba
Merge branch 'fix-ci-commit-ref-name-and-slug' into 'master'
...
Make `CI_COMMIT_REF_NAME` and `SLUG` variable idempotent
Closes #60822
See merge request gitlab-org/gitlab-ce!27663
2019-04-29 16:14:59 +00:00
Douglas Barbosa Alexandre
f832b96ad7
Merge branch 'use-keyword-args-for-databuilder-push' into 'master'
...
Use keyword args for databuilder push
See merge request gitlab-org/gitlab-ce!24088
2019-04-29 14:43:56 +00:00
Sean McGivern
9bc3dfea4f
Stop serialising project when removing todos
...
`Todos::Destroy::EntityLeaveService#project_ids` was returning
ActiveRecord objects with IDs, not simply IDs. That means we were
serialising more than we needed to in Sidekiq.
We can simply rename this method to `#projects` as this class doesn't
use any of the superclass methods that would use `#project_ids`.
2019-04-29 15:31:29 +01:00
John T Skarbek
17e8e8d3f4
Merge remote-tracking branch 'origin/master'
2019-04-29 10:29:07 -04:00
Stan Hu
d80fcccfb1
Add full backtrace for RSpec output
...
Attempt to debug https://gitlab.com/gitlab-org/gitlab-ce/issues/60953
2019-04-29 07:16:47 -07:00
Stan Hu
fad99d934f
Add Rubocop rule to ban include ActionView::Context
2019-04-29 06:14:53 -07:00
GitLab Release Tools Bot
076d199d2a
Merge branch 'secure-disallow-read-user-scope-to-read-project-events' into 'master'
...
Disallow read user scope to read project events
See merge request gitlab/gitlabhq!3067
2019-04-29 12:40:33 +00:00
Shinya Maeda
ed3a2fc8d7
Fix CI_COMMIT_REF_NAME and SLUG variable
...
With Pipelines for Merge Requests feature, users cannout keep using
$CI_COMMIT_REF_NAME and _SLUG predefined variables for dynamic
environments. We fix this problem by explicitly looking at the source
ref.
2019-04-29 18:52:51 +07:00
khm
2f36efa087
Fix links to wiki pages with subdirectories
...
This commit contains the patch suggested by @fjsanpedro in the issue
covering broken links in wiki search results.
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/56234
2019-04-29 11:31:28 +00:00
Douwe Maan
addefa8edd
Merge branch 'bvl-initialize-design-repo-ce' into 'master'
...
Port changes for design management to CE
See merge request gitlab-org/gitlab-ce!27555
2019-04-29 10:39:49 +00:00
Douwe Maan
6885419a48
Merge branch '60821-deployment-jobs-broken-as-of-11-10-0' into 'master'
...
Resolve "Deployment jobs broken as of 11.10.0"
Closes #60821
See merge request gitlab-org/gitlab-ce!27687
2019-04-29 10:30:29 +00:00
Peter Leitzen
80fec5c329
Load environment metrics only for JSON endpoint
...
When showing the HTML version of the environment metrics we don't need
to fetch their metrics because we don't use them anymore on the HTML
version.
We use additional_metrics.json endpoint now.
2019-04-29 10:25:31 +00:00
Filipa Lacerda
7d29dbe49d
Merge branch '60855-mr-popover-is-not-attached-in-system-notes-jest-fix' into 'master'
...
Init MR Popovers on system note mounted
Closes #60855
See merge request gitlab-org/gitlab-ce!27747
2019-04-29 09:16:03 +00:00
Sean McGivern
e6f548fcd8
Merge branch 'sh-fix-profiler-ruby-5.1' into 'master'
...
Fix Profiler to work with Rails 5.1
Closes #61051
See merge request gitlab-org/gitlab-ce!27774
2019-04-29 07:38:49 +00:00
John Cai
fe31f63ce8
Add gitaly session id & catfile-cache feature flag
2019-04-29 07:21:36 +00:00
Bob Van Landuyt
33cf8edae1
Port changes for design management to CE
...
This ports the changes from
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10462/
to CE
2019-04-29 08:28:43 +02:00
Tiger
825d759634
Fix deployments for Kubernetes service templates
...
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/27687
2019-04-29 07:57:08 +10:00
Kamil Trzciński
6246979a86
Merge branch '60945-masked-variable-still-printed-in-log-output-on-gitlab-com' into 'master'
...
Resolve "Masked Variable still printed in log output on gitlab.com"
Closes #60945
See merge request gitlab-org/gitlab-ce!27768
2019-04-28 15:09:15 +00:00
Grzegorz Bizon
536d96a3e0
Merge branch '60383-setup-dashboard-endpoint' into 'master'
...
Create dashboards endpoint & setup dashboard post-processing
Closes #60383
See merge request gitlab-org/gitlab-ce!27405
2019-04-28 11:53:12 +00:00
Shinya Maeda
28f785404a
Prevent concurrent execution of PipelineScheduleWorker
...
Currently, PipelineScheduleWorker is fired in a short period on
our production server. We can stop this behavior by locking the
execution thread with in_lock method.
2019-04-28 12:59:23 +07:00
Vladimir Shushlin
db6989ddb0
Add Let's Encrypt application settings
...
Store Let's Encrypt account email in application settings
Also add explicit terms of service consent
2019-04-27 04:38:01 +00:00
Stan Hu
266ba11ed7
Fix Profiler to work with Ruby 5.1
...
Ruby 5.1 now requires keyword arguments to pass along parameters and
headers for ActionDispatch::Integration::RequestHelpers.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61051
2019-04-26 21:22:23 -07:00
Jason Goodman
fe86890b9d
Add deployment events to chat notification services
...
This enables sending a chat message to Slack or Mattermost
upon a successful, failed, or canceled deployment
2019-04-26 21:08:41 +00:00
Matija Čupić
07b5c50381
Remove variable masking feature flag
2019-04-26 15:20:47 -04:00