3b97ea0a0c
Merge branch 'frozen_string_literal_spec_services' into 'master'
...
Add frozen_string_literal to spec/services
See merge request gitlab-org/gitlab-ce!27267
2019-04-12 16:41:27 +00:00
dc00fa90e9
Squashed commits and modified visibility level output
...
Added changelog and rebased
2019-04-12 05:00:50 +00:00
85b29c1c2f
Add frozen_string_literal to spec/services
...
Probably useful as we often move these files to "new" files.
2019-04-12 10:14:54 +12:00
4ec16912b8
Autocorrect with RSpec/ExampleWording cop
...
- rewords examples starting with 'should'
- rewords examples starting with 'it'
Note: I had to manually fixup "onlies" to "only"
2019-04-05 08:43:27 +00:00
e540ae798b
Remove groups destroy race condition spec
...
This was removed in the below MR in EE only, as it was causing failures
related to Geo.
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/3999
2019-04-02 10:50:58 +01:00
7e9348f359
Enable/disable Auto DevOps at Group level
...
- Includes instance methods on Group model to detect when a group has
AutoDevOps explicitly/implicitly enabled/disabled.
- Includes migration to add a new column to namespaces table
- Add UI necessary modifications
- Add service and controller to update auto devops
related instances
- Updates project and groups auto devops badges
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52447
2019-03-12 10:15:33 +00:00
dea631545f
fix group without owner after transfer
2019-03-01 20:03:06 +01:00
1bc6dc28b3
Merge branch 'security-todos_not_redacted_for_guests' into 'master'
...
[master] Security todos not redacted for guests
See merge request gitlab/gitlabhq!2697
2019-01-02 09:32:40 +00:00
b1c3955385
Rename GroupHierarchy into ObjectHierarchy
...
- we now use the hierarchy class also for epics
- also rename supports_nested_groups? into supports_nested_objects?
- move it to a concern
2018-12-19 15:24:29 +01:00
1653f7b1c6
Delete confidential issue todos for guests
...
Fix leaking information of confidential issues on TODOs
when user is downgraded to guest access.
2018-12-14 10:38:52 -02:00
7f47e13218
Merge branch 'gt-update-typos-in-comments-and-specs' into 'master'
...
Fix typos in comments and specs
See merge request gitlab-org/gitlab-ce!22683
2018-11-01 10:34:23 +00:00
733ae94921
Fix typos in comments and specs
2018-11-01 08:59:20 +02:00
66e8ecffa0
Resolve "Create new group: Rename form fields and update UI"
2018-10-30 16:23:47 +00:00
3ea988e854
Fix Groups::UpdateService#execute not returning correct error code
...
This was causing problems in EE, where audit events were being
generated even if the project failed to save.
2018-10-18 01:43:49 -07:00
15d011d64d
Geo: sync disabled wikis. Stage 2
...
We started syncing all the wiki regardless of the fact it's disabled or
not. We couldn't do that in one stage because of needing of smoth update
and deprecating things. This is the second stage that finally removes
unused columns in the geo_node_status table.
2018-09-25 17:49:39 +03:00
eb640eded7
Correct Gitlab Capitalization in code files
2018-09-21 12:05:37 +00:00
2e719bda0a
don't trigger project deletion hooks twice when removing a group
2018-08-26 10:58:43 +02:00
5fbb6ddf23
Fix: Project deletion may not log audit events during group deletion
2018-08-16 13:34:22 +03:00
4d4b8f8bbe
Remove group todos when a users looses access
2018-08-02 16:16:58 +02:00
ddd2a25679
Replace 'Sidekiq::Testing.inline!' with 'perform_enqueued_jobs'
...
`perform_enqueued_jobs` is a Sidekiq method.
Using this method violates the Dependency inversion principle[0].
This commit replaces `perform_enqueued_jobs` with ActiveJob's abstract
method `perform_enqueued_jobs` in specs.
[0]: https://en.wikipedia.org/wiki/Dependency_inversion_principle
2018-07-23 15:34:54 +11:00
a63bce1a4b
Resolve "Rename the `Master` role to `Maintainer`" Backend
2018-07-11 14:36:08 +00:00
ec4423665c
Gitlab::Shell works on shard name, not path
...
Direct disk access is done through Gitaly now, so the legacy path was
deprecated. This path was used in Gitlab::Shell however. This required
the refactoring in this commit.
Added is the removal of direct path access on the project model, as that
lookup wasn't needed anymore is most cases.
Closes https://gitlab.com/gitlab-org/gitaly/issues/1111
2018-04-25 13:36:22 +02:00
ab286656b2
Resolve "Namespace factory is problematic"
2018-04-23 15:48:26 +00:00
ce69419a60
Remove permanent redirects
...
Removes permanent redirects, this means that redirects will only be
possible as long as the old route isn't taken by a new project/group.
2018-03-28 14:12:08 +02:00
6b0c6e69e1
Use hashed storage in the specs
2018-02-07 13:40:46 +00:00
a03d29da1d
Validate User username only on Namespace, and bubble up appropriately
2018-02-06 12:09:03 -06:00
68a419c879
31885 - Ability to transfer a single group to another group
2018-02-06 00:10:58 +00:00
62bb6235c2
Make Members with Owner and Master roles always able to create subgroups
2017-09-07 13:47:58 -05:00
1feeea9c6a
Refer to “Share with group lock” consistently
2017-09-06 12:07:21 -07:00
c2c6c4c69e
Specify nested_groups specs
2017-09-06 12:07:20 -07:00
6c57734677
Enforce share_with_group_lock rules
...
…in Groups::UpdateService instead of only in the browser.
2017-09-06 12:07:20 -07:00
529a07bd1e
Handle creating a nested group on MySQL correctly
...
Since we don't support nested groups on MySQL, raise an error
explaining that on import instead of trying anyway.
2017-08-25 12:35:47 +02:00
5904fea900
Add `:nested_groups` metadata to `Groups::NestedCreateService` specs
2017-08-24 13:45:02 -04:00
22ef4ba3a4
Migrate creation of nested groups into a service
2017-08-23 13:36:38 +02:00
800c9bf37d
Add `:nested_groups` metadata to two subgroup-related specs
...
Prevents these from failing on MySQL.
Closes #36811 and #36812 .
2017-08-22 12:57:08 -04:00
28501691da
Merge branch '35845-improve-subgroup-creation-permissions' into 'master'
...
Improves subgroup creation permissions
Closes #35845
See merge request !13418
2017-08-22 08:52:30 +00:00
fb9e059a41
Make sure repository's removal work for legacy and hashed storages
2017-08-22 06:33:20 +02:00
5bc9dedf40
Improves subgroup creation permissions
2017-08-21 15:40:22 +01:00
72a7b30c9f
Change all `:empty_project` to `:project`
2017-08-02 17:47:31 -04:00
850a22547c
Merge branch 'zj-delete-mm-team' into 'master'
...
Remove Mattermost team with GitLab group
Closes #30023
See merge request !11362
2017-07-28 09:58:20 +00:00
d7062dd042
Remove Mattermost team with GitLab group
...
When destroying a group, now an API call is made to the Mattermost
server to request the deletion of the project. Actual team deletion on
the Mattermost side happens async, so the runtime shouldn't increase by
more than a second.
2017-07-28 09:09:55 +02:00
cddc5cacfb
Use described_class when possible
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
ddccd24c13
Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
fa93156528
Defer project destroys within a namespace in Groups::DestroyService#async_execute
...
Group#destroy would actually hard-delete all associated projects even
though the acts_as_paranoia gem is used, preventing Projects::DestroyService
from doing any work.
We first noticed this while trying to log all projects deletion to the Geo
log.
2017-06-29 09:23:31 -07:00
a6ec5121f0
Correct RSpec/SingleLineHook cop offenses
2017-06-14 13:18:56 -05:00
d4861ec72d
add spec and changelog
2017-04-19 10:15:52 +02:00
91f43587a8
Merge branch 'jej-group-name-disclosure' into 'security'
...
Prevent private group disclosure via parent_id
See merge request !2077
2017-03-29 19:18:38 -07:00
db8a8afc61
Add a new `stub_mattermost_setting` stub helper to properly stub Mattermost settings
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-03-28 14:12:32 +02:00
ca9a79f620
Use `:empty_project` where possible in service specs
2017-03-27 20:44:09 -04:00
ddfd09c09c
Merge branch 'master' into zj-create-mattermost-team
2017-03-02 10:22:56 +01:00
Michael Kozono
Sara Ahbabou
Thong Kuah
Sean McGivern
Mayra Cabrera
Peter Marko
John Jarvis
Jarka Košanová
Felipe Artur
Achilleas Pipinellis
George Tsiolis
Martin Wortschack
Stan Hu
Valery Sizov
Marcel Amirault
Gabriel Mazetto
blackst0ne
Mark Chao
Zeger-Jan van de Weg
Lin Jen-Shin
Bob Van Landuyt
Nick Thomas
Douwe Maan
Ruben Davila
Robert Speicher
Douwe Maan
Tiago Botelho
Rémy Coutable
James Lopez