Commit Graph

313 Commits

Author SHA1 Message Date
Ash McKenzie 5d5b9d57de Merge branch '60476-actionview-missingtemplate-missing-template-projects-issues-_merge_requests-with-locale-en-formats-html-varian' into 'master'
Delete leftover code for referenced_merge_requests endpoint

Closes #60476

See merge request gitlab-org/gitlab-ce!27335
2019-04-30 00:34:49 +00:00
GitLab Release Tools Bot 69285c21c3 Merge branch 'security-issue_2830' into 'master'
Prevent leaking information when issue is moved

Closes #2830

See merge request gitlab/gitlabhq!3050
2019-04-25 10:39:12 +00:00
Tanya Pazitny db00c6c6d8 Fix link issues with labels
* On the project labels page, the label itself should not be clickable.
* On the group labels page, the links for Issues and Merge Requests should be shown.
2019-04-18 15:51:56 +00:00
Toon Claes f6417b82aa Include link to raw job log in plain-text emails
People who prefer plain text email also might prefer the raw job log
files. So include the link directly to there.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56849
2019-04-17 13:24:56 +02:00
Fatih Acet cf02657234
Delete leftover code for referenced_merge_requests
We rewrote Related MRs widget using Vue.
The previous implementation was using Haml templates
and calling referenced_merge_requests endpoint which is
now deprecated. This MR deletes leftover stuff them.
2019-04-15 09:02:50 +02:00
drew cimino fdc602e40e use cleaner expectation matchers from Capybara 2019-04-12 17:10:42 +01:00
drew cimino 34243489af Don't render artifact download links on the project tags page for builds with expired artifacts 2019-04-12 16:53:21 +01:00
Felipe Artur ff06452e05 Prevent leaking information when issue is moved
Prevent leaking namespace and project names on moved issue links
2019-04-09 15:53:56 -03:00
Oswaldo Ferreira ca884980ee [CE] Support multiple assignees for merge requests
Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161
(code out of ee/ folder).
2019-04-08 18:40:00 -03:00
Thong Kuah 4ec16912b8 Autocorrect with RSpec/ExampleWording cop
- rewords examples starting with 'should'
- rewords examples starting with 'it'

Note: I had to manually fixup "onlies" to "only"
2019-04-05 08:43:27 +00:00
Mike Greiling 8598fb3411
Hide kubernetes cluster warning when a cluster exists 2019-04-04 16:30:29 -05:00
Elias Werberich de6bab915c
Disable inaccessible navigation links upon archiving a project 2019-03-31 16:09:51 +02:00
Reuben Pereira cc2ed858a4 Add feature specs for settings page
Add spec for form fields
Style settings sections
2019-03-14 23:50:21 +00:00
Mayra Cabrera 7e9348f359 Enable/disable Auto DevOps at Group level
- Includes instance methods on Group model to detect when a group has
AutoDevOps explicitly/implicitly enabled/disabled.
- Includes migration to add a new column to namespaces table
- Add UI necessary modifications
- Add service and controller to update auto devops
related instances
- Updates project and groups auto devops badges

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52447
2019-03-12 10:15:33 +00:00
Peter Marko 4e2781febd expose group id on home panel 2019-03-11 14:19:47 +01:00
Fatih Acet ab391b779e Merge branch 'fix/38010-sidebar-loads-and-collapses' into 'master'
Updated ContextualSidebar to render collapsed on smaller screens

Closes #38010

See merge request gitlab-org/gitlab-ce!24555
2019-03-06 00:35:30 +00:00
Andrew Fontaine ba98e91c06 Add Component to Confirm Environment Rollback
Ensure a vue.js component to confirm the re-deployment/rollback of an
environment pops up when rollback/re-deploy has been clicked so the user
must confirm their actions before accidentally rolling back or
re-deploying an environment.

Only on the `environment-table` view.
2019-03-05 18:33:10 +00:00
Grzegorz Bizon d317aaf70f Merge branch '45305-ci-status-icon-mismatch-on-merge-requests-page-and-the-mr-itself' into 'master'
Resolve "CI status icon mismatch on Merge Requests page and the MR itself"

Closes #45305

See merge request gitlab-org/gitlab-ce!25407
2019-03-05 08:43:29 +00:00
Luke Bennett 6b3966407b
Add tests for nav sidebar collapsed on render
Adds rspec view tests that expect the nav sidebar
to have a class that will cause the nav sidebar
to be rendered collapsed with or without js.

Tests the nav sidebar on the admin, group,
instance statistics, user profile and project
sidebars.
2019-03-05 00:58:21 +11:00
Reuben Pereira 43e713eb41 Refactor model and spec
- Move some specs into contexts
- Let get_slugs method take a parameter and return a specific slug.
- Add rescues when using Addressable::URI.
2019-03-01 14:51:54 +00:00
Robert Speicher a05aba61c7
Freeze date in merge request status view spec
Previously, when this spec ran on the 28th of February, "one month ago"
isn't actually a month ago, it's "28 days ago".

Now we freeze the date to one that works as intended, since the point of
the test is only that it shows a relative date in the tooltip, not
necessarily that it's an exact, specific date.
2019-02-28 17:21:01 -08:00
Scott Hampton 8c60c671b0 Hide CI status when pipelines disabled
Pipeline status was showing failed on projects when CI was disabled.

This checks to see if the feature is enabled before showing the status.
2019-02-25 11:03:28 +00:00
Phil Hughes 45b3513f12 Merge branch '56873-only-load-syntax-highlighting-css-when-selected' into 'master'
Resolve "Only load syntax highlighting css when selected"

Closes #57739 and #56873

See merge request gitlab-org/gitlab-ce!25232
2019-02-22 09:21:03 +00:00
Simon Knox a1e0f387bf Move highlight themes to subfolder 2019-02-22 12:07:14 +11:00
Andrew Fontaine 37b9173bd5 Make "moved" Link to Moved Issue
The text "moved" now links to the issue the closed issue was moved to.
2019-02-21 09:34:00 -05:00
Scott Hampton 52c910eeca Remove deprecated ci status helper function
After changing all places that used the function, we can now remove it.
2019-02-20 12:20:09 -07:00
Scott Hampton 54a5d513e5 Fixing CI icon mismatch
MR list, and related MRs and branches were using a deprecated helper.

Created a new icon haml file to help move these forward.
2019-02-19 13:27:53 -07:00
Simon Knox 5996fd145f Only load selected syntax highlight CSS
Compile highlight CSS separately
Move highlight-specific mixins out of mixins.scss
Rename solarized themes to match theme name as this was a smaller
change than changing all instances to snake_case
2019-02-15 21:10:19 +11:00
Constance Okoghenun 20ce370f4b Improved readability of issues related MR status spec 2019-02-08 19:10:58 +01:00
Jan Provaznik 81b875f0d0 Added tests for merge_request_status partial 2019-02-08 16:27:56 +01:00
Mayra Cabrera d9af3752fc Addresses UX and BE comments:
- Changes help text on clusters form to make it more explicit.
- Removes unnecessary warnings on auto devops form
- Simplifies cluster methods logic
2019-02-06 21:51:48 -06:00
Kamil Trzciński d4c7214799
[master] Pipelines section is available to unauthorized users 2019-01-31 16:52:50 +01:00
Francisco Javier López 740f07b1ec
Fixed bug when external wiki is enabled
When the external wiki is enabled, the internal wiki link is replaced
by the external wiki url. But the internal wiki is still accessible.
In this change the external wiki will have its own tab in the sidebar
and only if the services are disabled the tab (and access rights)
will not be displayed.
2019-01-31 16:51:53 +01:00
Kushal Pandya 15002205b1 Merge branch '53104-redesign-group-overview-ui-mvc' into 'master'
Resolve "Redesign group overview UI: MVC"

Closes #53104

See merge request gitlab-org/gitlab-ce!23866
2019-01-30 09:14:52 +00:00
Andrew Fontaine 01a713d64c Indicate on Status if Issue was Moved
Add the text `(moved)` to the `Closed` status indicator on a closed
issue if the reason the issue was closed was due to moving it.

This only applies to closed issues. Issues that were closed and moved
then later re-opened only show `Open`. This makes it more immidately
clear why the issue was closed.
2019-01-25 14:59:41 -05:00
Dennis Tang 056f6dd08f Refresh group overview to match project overview
- Avatar, group name, and group description now left-aligned
- Notification setting and "New project" CTA right-aligned
  with group avatar and name
- Leave group / request access now a link next to the 'Group'
  label below the group name
- Notification setting label removed in favor of icons
  - Tooltip added to indicate notification setting
- Search option moved inside table header next to "Sort by"
2019-01-25 10:26:35 +00:00
Peter Leitzen 77eff52afa
Remove `error_tracking` feature flag
We introduced the feature flag `error_tracking` to test the Sentry MVC
safely.

After the successful test, we remove it again.
2019-01-15 21:33:40 +01:00
Jasper Maes 4361c92b6a Update gitlab-styles to 2.5.1 2019-01-11 23:59:35 +01:00
Shinya Maeda 9b823af4fd Remove releases_page feature flag
We introduced releases_page feature flag.
Given this feature is deemed stable, we should remove
this flag before 19th.
2019-01-11 13:26:09 +09:00
Douglas Barbosa Alexandre d403d7ac6c Fix MR sidebar to correctly warning if assignee can't merge 2019-01-08 21:50:36 +00:00
Tristan Read 7380ed309a
Add view and feature test for error tracking settings 2019-01-07 19:09:49 +01:00
Mike Greiling 06cef29a62 Merge branch '44984-use-serializer-for-issuable-sidebar' into 'master'
Resolve "Create a serializer to render issuables sidebar"

Closes #44984

See merge request gitlab-org/gitlab-ce!23379
2018-12-21 23:30:50 +00:00
Heinrich Lee Yu 51ac77af9a Add date range to milestone changed emails
Also refactored issues and MRs to use the same email template file
2018-12-21 18:00:14 +08:00
Heinrich Lee Yu 9f9765485e Refactor sidebar to use data from serializer 2018-12-19 17:58:53 +08:00
Filipa Lacerda 9004e18e6e Adds releases index route
Renders empty index page
Adds Releases entry to the navigation bar behind a feature flag
Renders 404 when feature flag for releases is not enabled
2018-12-18 11:01:55 +01:00
Dennis Tang 75496059a1 Further design iteration on project overview
Continues the iteration on the project overview UI:

- moved star, fork and new clone button
(copy SSH/HTTPS URLs) to top right,
  made them smaller
- avatar is now larger (64px)
- 'Request access' is now a link instead
  of a button
- overview comes before the description +
  changed styling and added icons
- description font-size is now 16px (large-paragraph)
- quick links to files are moved downwards
  below the commit/pipeline info
- margins changed to group content into
  4 groups to clean up the interface
- visibility info reduced to icon-only and
  moved to the right of the title
2018-12-07 14:11:42 +00:00
Rémy Coutable 1209332a08
Replace admin sidebar feature spec with view spec
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-12-04 17:35:40 +01:00
Robert Speicher c0fcf120b7
Convert "New menu" feature spec to a view spec
A feature spec to test this simple behavior takes about 2 minutes to run
in CI. Everything it's testing is conditionals and `href` attributes,
which can easily be done in a view spec that runs in about 8 seconds.
2018-11-26 11:19:15 -06:00
Jeremy Watson 28840d3f5c Copy changes for abuse clarity 2018-11-07 11:24:36 +00:00
Douwe Maan 7d4b717c92 Merge branch 'fast_project_blob_path' into 'master'
Improve performance of tree rendering in repositories with a lot of items

See merge request gitlab-org/gitlab-ce!16511
2018-11-05 11:12:02 +00:00