Commit Graph

211 Commits

Author SHA1 Message Date
Ash McKenzie 5d5b9d57de Merge branch '60476-actionview-missingtemplate-missing-template-projects-issues-_merge_requests-with-locale-en-formats-html-varian' into 'master'
Delete leftover code for referenced_merge_requests endpoint

Closes #60476

See merge request gitlab-org/gitlab-ce!27335
2019-04-30 00:34:49 +00:00
GitLab Release Tools Bot 69285c21c3 Merge branch 'security-issue_2830' into 'master'
Prevent leaking information when issue is moved

Closes #2830

See merge request gitlab/gitlabhq!3050
2019-04-25 10:39:12 +00:00
Fatih Acet cf02657234
Delete leftover code for referenced_merge_requests
We rewrote Related MRs widget using Vue.
The previous implementation was using Haml templates
and calling referenced_merge_requests endpoint which is
now deprecated. This MR deletes leftover stuff them.
2019-04-15 09:02:50 +02:00
drew cimino fdc602e40e use cleaner expectation matchers from Capybara 2019-04-12 17:10:42 +01:00
drew cimino 34243489af Don't render artifact download links on the project tags page for builds with expired artifacts 2019-04-12 16:53:21 +01:00
Felipe Artur ff06452e05 Prevent leaking information when issue is moved
Prevent leaking namespace and project names on moved issue links
2019-04-09 15:53:56 -03:00
Oswaldo Ferreira ca884980ee [CE] Support multiple assignees for merge requests
Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161
(code out of ee/ folder).
2019-04-08 18:40:00 -03:00
Thong Kuah 4ec16912b8 Autocorrect with RSpec/ExampleWording cop
- rewords examples starting with 'should'
- rewords examples starting with 'it'

Note: I had to manually fixup "onlies" to "only"
2019-04-05 08:43:27 +00:00
Mike Greiling 8598fb3411
Hide kubernetes cluster warning when a cluster exists 2019-04-04 16:30:29 -05:00
Reuben Pereira cc2ed858a4 Add feature specs for settings page
Add spec for form fields
Style settings sections
2019-03-14 23:50:21 +00:00
Mayra Cabrera 7e9348f359 Enable/disable Auto DevOps at Group level
- Includes instance methods on Group model to detect when a group has
AutoDevOps explicitly/implicitly enabled/disabled.
- Includes migration to add a new column to namespaces table
- Add UI necessary modifications
- Add service and controller to update auto devops
related instances
- Updates project and groups auto devops badges

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52447
2019-03-12 10:15:33 +00:00
Andrew Fontaine ba98e91c06 Add Component to Confirm Environment Rollback
Ensure a vue.js component to confirm the re-deployment/rollback of an
environment pops up when rollback/re-deploy has been clicked so the user
must confirm their actions before accidentally rolling back or
re-deploying an environment.

Only on the `environment-table` view.
2019-03-05 18:33:10 +00:00
Reuben Pereira 43e713eb41 Refactor model and spec
- Move some specs into contexts
- Let get_slugs method take a parameter and return a specific slug.
- Add rescues when using Addressable::URI.
2019-03-01 14:51:54 +00:00
Robert Speicher a05aba61c7
Freeze date in merge request status view spec
Previously, when this spec ran on the 28th of February, "one month ago"
isn't actually a month ago, it's "28 days ago".

Now we freeze the date to one that works as intended, since the point of
the test is only that it shows a relative date in the tooltip, not
necessarily that it's an exact, specific date.
2019-02-28 17:21:01 -08:00
Scott Hampton 8c60c671b0 Hide CI status when pipelines disabled
Pipeline status was showing failed on projects when CI was disabled.

This checks to see if the feature is enabled before showing the status.
2019-02-25 11:03:28 +00:00
Andrew Fontaine 37b9173bd5 Make "moved" Link to Moved Issue
The text "moved" now links to the issue the closed issue was moved to.
2019-02-21 09:34:00 -05:00
Constance Okoghenun 20ce370f4b Improved readability of issues related MR status spec 2019-02-08 19:10:58 +01:00
Jan Provaznik 81b875f0d0 Added tests for merge_request_status partial 2019-02-08 16:27:56 +01:00
Mayra Cabrera d9af3752fc Addresses UX and BE comments:
- Changes help text on clusters form to make it more explicit.
- Removes unnecessary warnings on auto devops form
- Simplifies cluster methods logic
2019-02-06 21:51:48 -06:00
Kamil Trzciński d4c7214799
[master] Pipelines section is available to unauthorized users 2019-01-31 16:52:50 +01:00
Kushal Pandya 15002205b1 Merge branch '53104-redesign-group-overview-ui-mvc' into 'master'
Resolve "Redesign group overview UI: MVC"

Closes #53104

See merge request gitlab-org/gitlab-ce!23866
2019-01-30 09:14:52 +00:00
Andrew Fontaine 01a713d64c Indicate on Status if Issue was Moved
Add the text `(moved)` to the `Closed` status indicator on a closed
issue if the reason the issue was closed was due to moving it.

This only applies to closed issues. Issues that were closed and moved
then later re-opened only show `Open`. This makes it more immidately
clear why the issue was closed.
2019-01-25 14:59:41 -05:00
Dennis Tang 056f6dd08f Refresh group overview to match project overview
- Avatar, group name, and group description now left-aligned
- Notification setting and "New project" CTA right-aligned
  with group avatar and name
- Leave group / request access now a link next to the 'Group'
  label below the group name
- Notification setting label removed in favor of icons
  - Tooltip added to indicate notification setting
- Search option moved inside table header next to "Sort by"
2019-01-25 10:26:35 +00:00
Peter Leitzen 77eff52afa
Remove `error_tracking` feature flag
We introduced the feature flag `error_tracking` to test the Sentry MVC
safely.

After the successful test, we remove it again.
2019-01-15 21:33:40 +01:00
Jasper Maes 4361c92b6a Update gitlab-styles to 2.5.1 2019-01-11 23:59:35 +01:00
Douglas Barbosa Alexandre d403d7ac6c Fix MR sidebar to correctly warning if assignee can't merge 2019-01-08 21:50:36 +00:00
Tristan Read 7380ed309a
Add view and feature test for error tracking settings 2019-01-07 19:09:49 +01:00
Heinrich Lee Yu 9f9765485e Refactor sidebar to use data from serializer 2018-12-19 17:58:53 +08:00
Dennis Tang 75496059a1 Further design iteration on project overview
Continues the iteration on the project overview UI:

- moved star, fork and new clone button
(copy SSH/HTTPS URLs) to top right,
  made them smaller
- avatar is now larger (64px)
- 'Request access' is now a link instead
  of a button
- overview comes before the description +
  changed styling and added icons
- description font-size is now 16px (large-paragraph)
- quick links to files are moved downwards
  below the commit/pipeline info
- margins changed to group content into
  4 groups to clean up the interface
- visibility info reduced to icon-only and
  moved to the right of the title
2018-12-07 14:11:42 +00:00
Jeremy Watson 28840d3f5c Copy changes for abuse clarity 2018-11-07 11:24:36 +00:00
Douwe Maan 7d4b717c92 Merge branch 'fast_project_blob_path' into 'master'
Improve performance of tree rendering in repositories with a lot of items

See merge request gitlab-org/gitlab-ce!16511
2018-11-05 11:12:02 +00:00
Drew Blessing 409f2f4dd2 Improve performance of tree rendering in repositories with lots of items
Rails is slow to generate paths dynamically especially when called
hundreds/thousands of times. Also, rendering many partials hundreds
of times can be slower. This change reduces the number of partials
rendered and introduces two fast path methods to speed up path
generation.
2018-10-31 15:50:30 -05:00
Mark Chao 39ae9a59a5 Make Highlight accept language param
This replaces the repository param.
This allows more flexiblity as sometimes we have highlight content
not related to repository. Sometimes we know ahead of time the language
of the content. Lastly language determination seems better fit as a
logic in the Blob class.
`repository` param is only used to determine the language, which seems
to be the responsiblity of Blob.
2018-10-30 15:44:55 +08:00
Filipa Lacerda 9128e7849d Uses Vue app to render part of job show page 2018-10-03 15:29:07 +00:00
Bob Van Landuyt b93f1d3cf8 Merge branch 'security-6881-project-group-approvers-leaks-private-group-info-ce' into 'master'
[master] CE: Project group approvers leaks private group info

See merge request gitlab/gitlabhq!2488
2018-10-01 16:45:01 +00:00
Filipa Lacerda 32ccde8ccd Use Vue component for job artifacts, Commit and Trigger Variables 2018-09-25 08:07:47 +00:00
Tiago Botelho 81d949f656 Applies the CE backport of EE#657 2018-09-24 12:02:01 +01:00
Dennis Tang ec4ad656f0 Resolve "Improve project overview UI" 2018-09-06 07:27:39 +00:00
Stan Hu 5138d659b5 Speed up diff comparisons by limiting number of commit messages rendered
When a diff has a significant number of commits, the previous behavior would
attempt to render the Markdown on all the commit messages but only display
1000 of them. To avoid additional work, we only need to render the Markdown
on the set that is displayed.
2018-08-22 06:28:31 -07:00
Bob Van Landuyt f1d3ea63cf Show the status of a user in interactions
The status is shown for
- The author of a commit when viewing a commit
- Notes on a commit (regular/diff)
- The user that triggered a pipeline when viewing a pipeline
- The author of a merge request when viewing a merge request
- The author of notes on a merge request (regular/diff)
- The author of an issue when viewing an issue
- The author of notes on an issue
- The author of a snippet when viewing a snippet
- The author of notes on a snippet
- A user's profile page
- The list of members of a group/user
2018-07-30 15:01:26 +02:00
Tuğçe Nur Taş 742cf27778 Features/show project id on home panel 2018-07-18 06:58:21 +00:00
Mark Chao a63bce1a4b Resolve "Rename the `Master` role to `Maintainer`" Backend 2018-07-11 14:36:08 +00:00
Lin Jen-Shin 4ee08b77bc Updates from `rubocop -a` 2018-07-09 21:13:08 +08:00
Mike Greiling c604c43782
fix broken specs 2018-06-06 05:29:52 -05:00
Tiago Botelho bddbcaefc2 Backports every CE related change from ee-44542 to CE 2018-05-04 17:33:26 +02:00
Jose Ivan Vargas e40bc1b190 Create autodevops settings sections 2018-04-20 12:48:04 -05:00
Bob Van Landuyt eae2ed3366 Spec improvements for speed, reliability and readability 2018-04-12 18:05:50 +02:00
Bob Van Landuyt 083b0a9b03 Hide file/directory creation buttons 2018-04-11 10:51:16 +02:00
Bob Van Landuyt 12dd2b0cc0 Share collaboration check between view and presenter 2018-04-11 10:51:15 +02:00
Douwe Maan bdd7600de7 Add ability checks in views where they were previously missing 2018-04-10 15:46:20 +02:00