gitlab-ce

Commit Graph

Author	SHA1	Message	Date
Stan Hu	fd392cd725	Avoid process deadlock in popen by consuming input pipes A process that spews a lot of output to stderr or stdout could stall out due to the pipe buffer being full. As described in https://bugs.ruby-lang.org/issues/9082, we can use the trick used in Ruby's capture3 function to read the pipes in separate threads. Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/6895	2018-07-12 16:21:30 -07:00
James Edwards-Jones	95640413e6	Gitlab::Git::Popen can lazily hand output to a block This allows input to start processing immediately without waiting for the process to complete. This also allows long or infinite inputs to be partially processed, which will termiate the process when reading stops with SIGPIPE.	2017-11-06 10:20:13 +00:00
Andrew Newdigate	f530261773	Popen with a timeout	2017-10-16 09:11:31 +00:00

Author

SHA1

Message

Date

Stan Hu

fd392cd725

Avoid process deadlock in popen by consuming input pipes

A process that spews a lot of output to stderr or stdout could stall out
due to the pipe buffer being full. As described in https://bugs.ruby-lang.org/issues/9082,
we can use the trick used in Ruby's capture3 function to read the pipes in separate
threads.

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/6895

2018-07-12 16:21:30 -07:00

James Edwards-Jones

95640413e6

Gitlab::Git::Popen can lazily hand output to a block

This allows input to start processing immediately without waiting for the process to complete.
This also allows long or infinite inputs to be partially processed,
which will termiate the process when reading stops with SIGPIPE.

2017-11-06 10:20:13 +00:00

Andrew Newdigate

f530261773

Popen with a timeout

2017-10-16 09:11:31 +00:00

3 Commits