The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.
To fix this:
1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
`Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
like that in several places.
3. Change the initializers to use that new form.
- gl_emoji for falling back to image/css-sprite when the browser
doesn't support an emoji
- Markdown rendering (Banzai filter)
- Autocomplete
- Award emoji menu
- Perceived perf
- Immediate response because we now build client-side
- Update `digests.json` generation in gemojione rake task to be more
useful and include `unicodeVersion`
MR: !9437
See issues
- #26371
- #27250
- #22474
Added is_production to define sentry environment
Removed as much jQuery as possible
Added public_sentry_dsn application_settings helper method
Use URI module instead of regex for public dsn
Removed raven-vue and load raven on if sentry is enabled
Add load_script spec
added raven_config spec
added class_spec_helper and tests
added sentry_helper spec
added feature spec
In any case if just want the value which is always ‘gitlab’
require 'benchmark/ips'
Project.first # To load database things
GitlabIssueTrackerService.first # To load database things
Benchmark.ips do |x|
x.config(:time => 5, :warmup => 2)
x.report("current") do
Project.new.default_issue_tracker.to_param
end
x.report("") do
'gitlab'
end
x.compare!
end
Calculating -------------------------------------
current 4.000 i/100ms
30.938k i/100ms
-------------------------------------------------
current 47.298 (±10.6%) i/s - 232.000
4.366M (±20.9%) i/s - 17.202M
Comparison:
: 4366456.0 i/s
current: 47.3 i/s - 92318.26x slower
Douwe Maan
Rémy Coutable
Tim Zallmann
Kushal Pandya
Mike Greiling
Jose Ivan Vargas
Mario de la Ossa
Sean McGivern
Luke "Jared" Bennett
Sam Rose
Alfredo Sumaran
Simon Knox
Eric Eastwood
Valery Sizov
Luke Bennett
Clement Ho
Munken
Nick Thomas
Connor Shea
Paco Guzman
Fatih Acet
Jacob Schatz
Arinde Eniola
Stan Hu