This makes it possible to maintain backwards compatibility with configs
created when manual actions were non-blocking.
From now manual actions are blocking if configured with `allow_failure:
false`, otherwise manual actions are optional, and their status is
ignored.
* upstream/master: (247 commits)
Switched CONTRIBUTING.md style guide recommendation for method chaining
Fix new offenses
Stylistic tweaks
Fix OAuth/SAML user blocking behavior
Revert "Enable Style/DotPosition"
Revert "Prefer leading style for Style/DotPosition"
Revert "Enable Style/BarePercentLiterals"
Manually correct autocorrect
Move up delegate calls
Exclude migrations from Style/MutableConstant
ActiveSupport delegation is preferred over Forwardable
Update haml_lint to work with newest rubocop
Add explanations to cops
Update rubocop and rubocop-rspec and regenerate .rubocop_todo.yml
Update rubocop and rubocop-rspec and regenerate .rubocop_todo.yml
Order cops alphabetically
Don’t exclude some file in lib from rubocop
Fix new offenses
Enable Rails/Delegate
Enable Style/WordArray
...
The conflict happens when we try to update a build,
but fail to do so due to fact that we update the same build concurrently for two different runners.
Instead of using:
`coverage: /\(\d+.\d+%\) covered/`
This structure must be used now:
```
coverage:
output_filter: /\(\d+.\d+%\) covered/`
```
The surrounding '/' is optional.
This commit:
* Turns `coverage_regex` into `coverage` entry in yml file
* Fixes smaller requests from code reviewers for the previous commit
* This commit is temporary (will be squashed afterwards)
This commit does not (further commits will do though):
* Add global `coverage` entry handling in yml file as suggested by Grzegorz
* Add specs
* Create changelog
* Create docs
* We realized that headers were not set whenever we give 204
because `render_api_error!` doesn't preserve the headers.
* We also realized that `update_runner_info` would be called in
POST /builds/register every time therefore runner is updated
every time, ticking the queue, making this last_update didn't
work very well, and the test would be failing due to that.
Give forbidden if project for the build was deleted
I guess we don't need a change log entry because this is just for an internal corner case fix.
Closes#25309
See merge request !8091
Lin Jen-Shin
Kamil Trzciński
Yorick Peterse
Tomasz Maczukin
Grzegorz Bizon
Sean McGivern
Robert Schilling
Douwe Maan
Rémy Coutable
Douwe Maan
Leandro Camargo
Sean McGivern
Jared Deckard
Grzegorz Bizon
Kim "BKC" Carlbäcker