Commit Graph

94 Commits

Author SHA1 Message Date
Sean McGivern 4ebbfe5d3e Remove serialised diff and commit columns
The st_commits and st_diffs columns on merge_request_diffs historically held the
YAML-serialised data for a merge request diff, in a variety of formats.

Since 9.5, these have been migrated in the background to two new tables:
merge_request_diff_commits and merge_request_diff_files. That has the advantage
that we can actually query the data (for instance, to find out how many commits
we've stored), and that it can't be in a variety of formats, but must match the
new schema.

This is the final step of that journey, where we drop those columns and remove
all references to them. This is a breaking change to the importer, because we
can no longer import diffs created in the old format, and we cannot guarantee
the export will be in the new format unless it was generated after this commit.
2017-11-28 16:13:40 +00:00
Alejandro Rodríguez c21ae07e33 Refactor Gitlab::Git::Commit to include a repository 2017-08-07 22:34:34 -04:00
Sean McGivern aff5c9f3e5 Add table for merge request commits
This is an ID-less table with just three columns: an association to the merge
request diff the commit belongs to, the relative order of the commit within the
merge request diff, and the commit SHA itself.

Previously we stored much more information about the commits, so that we could
display them even when they were deleted from the repo. Since 8.0, we ensure
that those commits are kept around for as long as the target repo itself is, so
we don't need to duplicate that data in the database.
2017-07-06 17:36:10 +01:00
Grzegorz Bizon 0430b76441 Enable Style/DotPosition Rubocop 👮 2017-06-21 13:48:12 +00:00
Rémy Coutable d40e1f547e Enable the Style/TrailingCommaInLiteral cop
Use the EnforcedStyleForMultiline: no_comma option.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-10 18:25:45 +02:00
Ruben Davila 7f24b87b3b Some small updates for Spanish translations. 2017-05-04 19:27:17 -05:00
Ruben Davila 7fd42698aa Merge branch 'master' into 28433-internationalise-cycle-analytics-page
Conflicts:
	lib/gitlab/cycle_analytics/review_stage.rb
	lib/gitlab/cycle_analytics/staging_stage.rb
	lib/gitlab/cycle_analytics/test_stage.rb
2017-05-04 18:51:18 -05:00
Douwe Maan 897f98cc9d Fix wording of Cycle Analytics stage legends 2017-05-04 18:12:49 -05:00
Ruben Davila dbd1bdaeed More updates for translations plus some refactoring. 2017-05-03 21:08:43 -05:00
Ruben Davila ee65de48d8 More translations updates. 2017-05-03 12:40:21 -05:00
Ruben Davila e4526e061c Add more translation for Spanish. 2017-04-26 20:04:33 -05:00
Jacob Schatz 12cd4c8360 Merge branch 'add-additional-checks-to-ca-data' into 'master'
Small improvements for Cycle Analytics

See merge request !9153
2017-02-18 18:52:43 +00:00
Alfredo Sumaran d3ff2fa59b Restore exposure of legend property for events 2017-02-10 16:17:44 -05:00
Alfredo Sumaran 7b20784715 Revert "Merge branch 'add-additional-checks-to-ca-data' into 'master' "
This reverts commit b7c5ca499d, reversing
changes made to 9745c98bb7.
2017-02-10 15:21:45 -05:00
Alfredo Sumaran ee698e9595 Restore exposure of legend property for events 2017-02-10 03:41:39 -05:00
James Lopez 1b7c186723 move query limit to base event fetcher 2017-02-06 16:23:55 +01:00
Grzegorz Bizon 6b3f52b46c Fix cycle analytics code after improving serializers 2017-01-27 14:37:14 +01:00
James Lopez 1d775d9712 fix spec 2017-01-17 11:32:55 +01:00
James Lopez 150a448596 refactored a bunch of stuff based on feedback 2017-01-17 11:32:55 +01:00
James Lopez 1b220df56d fix bug retrieving medians 2017-01-17 11:32:55 +01:00
James Lopez 30c6703f0a fix specs 2017-01-17 11:32:55 +01:00
James Lopez 982d5a0506 refactored metrics fetcher - merged into stage and events 2017-01-17 11:32:55 +01:00
James Lopez 834bcacbae fix refactor of production event fetcher 2017-01-17 11:32:55 +01:00
James Lopez bbb9f84082 a few more fixes 2017-01-17 11:32:55 +01:00
James Lopez 056b0f1993 fix missing refactor in metrics fetcher 2017-01-17 11:32:55 +01:00
James Lopez 099aa124eb fix plan stage issue and some spec failures 2017-01-17 11:32:55 +01:00
James Lopez 3f681f4cef fix specs, refactor missing bits from events stuff 2017-01-17 11:32:55 +01:00
James Lopez b214be493d big refactor based on MR feedback 2017-01-17 11:32:55 +01:00
James Lopez 58dddcdfed few fixes after merge 2017-01-17 11:32:55 +01:00
James Lopez 69ecd951a9 refactor fetcher and fixed specs 2017-01-17 11:32:55 +01:00
James Lopez b805666984 refactor cycle analytics - updated based on MR feedback 2017-01-17 11:32:55 +01:00
James Lopez a67311cb4c Fix other spec failures 2017-01-17 11:32:55 +01:00
James Lopez 02e1e48192 more refactoring and fixing old specs 2017-01-17 11:32:54 +01:00
James Lopez fc6f8f2056 added new summary serializers and refactor all of the summary stuff into separate logical classes 2017-01-17 11:32:54 +01:00
James Lopez dc6ea14b0d fixed stage entity and added missing stage specs 2017-01-17 11:32:54 +01:00
James Lopez a998276223 added analytics stage serializer and moved some info to the stage classes from the controller 2017-01-17 11:32:54 +01:00
James Lopez 3268e37791 WIP - started refactoring cycle analytics median stuff into stages 2017-01-17 11:32:54 +01:00
James Lopez b938aa5cc8 Fix and relevant spec for plan stage breaking with nil commits 2016-11-23 09:10:04 +01:00
James Lopez 9b69168858 refactored a couple of things based on feedback 2016-11-21 14:09:26 +01:00
James Lopez 0fd397bba1 Added permissions per stage to cycle analytics endpoint 2016-11-21 10:49:05 +01:00
James Lopez f5b792e22e refactored updater and updated specs 2016-11-18 13:00:38 +01:00
James Lopez cb353d655b added new build updater, specs and refactored allowed_ids 2016-11-18 12:05:29 +01:00
James Lopez cd222357ad refactor events 2016-11-18 10:13:42 +01:00
James Lopez 24c2aa39ad fix blank state error 2016-11-17 20:54:02 +01:00
James Lopez 98773ef974 preload ids or objects for users, merge request and issues 2016-11-17 20:42:18 +01:00
James Lopez d5b673da79 more refactoring and added some auth checks 2016-11-17 18:00:37 +01:00
James Lopez 9c995725ea fix typo in error message 2016-11-17 15:05:13 +01:00
James Lopez e22b5cca02 remove class no longer required 2016-11-17 15:00:56 +01:00
James Lopez 37a3505019 fix integration spec 2016-11-17 15:00:01 +01:00
James Lopez af80fcb477 fix specs 2016-11-17 14:14:23 +01:00