Commit Graph

106 Commits

Author SHA1 Message Date
Filipa Lacerda c5f5ce8807 Fix broken tests
Rename Build to Job

Replace "Builds" by "Jobs" and fix broken specs

Replace "Builds" by "Jobs"

Fix broken spinach test

Fix broken test

Remove `˙` at the beginning of the file

Fix broken spinach test

Fix broken tests

Changes after review
2017-02-03 09:43:04 +00:00
Fatih Acet 6669bfd3d1 Merge branch '25507-handle-errors-environment-list' into 'master'
Resolve "Error handling in environments list"

Closes #25507

See merge request !8461
2017-01-19 20:46:04 +00:00
Fatih Acet 1c81452a99 Merge branch '26601-dropdown-makes-request-close' into 'master'
Fixes builds dropdown making request when clicked to be closed

Closes #26601

See merge request !8545
2017-01-19 20:33:35 +00:00
Mike Greiling ccada28f30 resolve all padded-blocks eslint violations 2017-01-18 17:16:41 -06:00
Filipa Lacerda 683ea89e04 Use bootstrap dropdown events to only make the request when the dropdown is being opened
Fixes builds dropdown making request when clicked to be closed

Adds MR ID to CHANGELOG

Improve documentation

Use bootstrap dropdown events to only make the request when the dropdown is being opened
2017-01-13 10:31:18 -05:00
Filipa Lacerda 463fddeafc Adds tests
Adds changelog entry

Finishes tests

Fix eslint errors

Fix teaspoon test timing out
2017-01-12 14:38:26 -05:00
Mike Greiling 10d483eaaa Merge branch 'fix-u2f-fixtures' into 26226-generate-all-haml-fixtures-within-teaspoon-fixtures-task
* fix-u2f-fixtures:
  generate u2f frontend fixtures dynamically
  force utf-8 encoding for prior to fixture parsing to prevent nokogiri issues
  exclude script type=text/template from dom scrubbing
2017-01-05 14:10:43 -06:00
Mike Greiling df5223de61 generate u2f frontend fixtures dynamically 2017-01-05 14:03:32 -06:00
Mike Greiling d904335dc7 make projects.json easier to read 2017-01-03 10:56:39 -06:00
Mike Greiling 7ae2fe132c fix dynamic u2f fixtures 2017-01-03 10:56:39 -06:00
Mike Greiling 2373082eb0 create catch-all fixture generator for all static fixtures 2017-01-03 10:56:39 -06:00
Alfredo Sumaran 2ed90c454d Merge branch '18786-go-to-a-project-order' into 'master'
Go to a project order

Closes #18786

See merge request !7737
2016-12-27 20:41:04 +00:00
Sam Rose 804198ab7f Maintain milestone filter option when updating filter
Setup teaspoon tests for Issuable
2016-12-21 07:34:58 -05:00
Filipa Lacerda 11040589c8 Adds tests for the MiniPipelineGraph class 2016-12-20 11:10:20 +00:00
Mitchell Hentges 66ff2dede1 Make CI badge hitboxes better match container 2016-12-19 10:13:25 -08:00
Jacopo 75060b93a6 Go to a project order
The order of "Go to a project" dropdown is based on last_activity_at
2016-12-15 22:34:39 +01:00
winniehell b7f297ed8a Replace static fixture for abuse_reports_spec (!7644) 2016-12-15 12:12:33 +01:00
winniehell f21e13ae19 Replace static fixture for awards_handler_spec (!7661) 2016-12-12 23:17:25 +01:00
Filipa Lacerda 52e0c4ba91 Fix tests
Fix broken tests
2016-12-12 12:44:46 +00:00
Filipa Lacerda 401a2ec0b1 Adds tests to prevent future errors.
Fix undefined variable in es5
2016-12-12 12:44:45 +00:00
Fatih Acet 1413c94a8e Merge branch '15081-wrong-login-tab-ldap-frontend' into 'master'
Fixed Wrong Tab Selected When Loggin Fails And Multiple Login Tabs Exists

## What does this MR do?
Fixes issue: 15081 Wrong Tab Selected When Loggin Fails And Multiple Login Tabs Exists
This is done by saving into a cookie when the active tab changes and by always selecting that tab when the page is loaded.
## Are there points in the code the reviewer needs to double check?
No
## Why was this MR needed?
In order to fix the issue: 15081
## Screenshots (if relevant)

## Does this MR meet the acceptance criteria?

- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?


Closes #15081

See merge request !7314
2016-12-09 09:17:41 +00:00
Sean McGivern 564b166236 Merge branch 'fix-all-dashboard' into 'master'
Don't whitelist events for all filter

Closes #24826

See merge request !7673
2016-12-08 15:28:45 +00:00
Oxan van Leeuwen bb447383c5 Add issue events filter and make sure "All" really shows everything
Currently, the EventFilter whitelists event types for the "All" filter.
This has gotten outdated, which causes the confusing behaviour of the
"All" tab not really showing all events. To make matters worse, by
default no tab at all is selected, which does show all events, so
selecting the "All" tab actually hides some events.

Fix this by:
- Making sure All always includes all activity, by abolishing the
  whitelist and just returning all events instead.
- Make the All tab selected by default.
- Add Issue events tab to include the specific events around opening
  and closing issues, since there was no specific filter to see them
  yet.

Fixes #24826
2016-12-04 23:07:22 +01:00
Alfredo Sumaran 2f91c0eef4 Merge branch 'cleanup-common_utils.js' into 'master'
Clean up common_utils.js

## What does this MR do?

- Remove unused functions from `common_utils.js`.
- Move functions which are used from only one file to that file.

## Why was this MR needed?

Because some utils weren't that common (anymore).

See merge request !7318
2016-12-02 16:03:18 +00:00
Jacopo 8235f83015 Fixed Wrong Tab Selected When Loggin Fails And Multiple Login Tabs Exists
When ldap is enabled and use "Standard" authentication method, if authentication fails
the correct tab remain selected.
This is done by saving into localStorage when the active tab changes and by always selecting that tab when
the page is loaded.
2016-12-02 10:19:31 +01:00
Alfredo Sumaran 9945302708 Merge branch 'comments-fixture' into 'master'
Replace static fixture for notes_spec

## What does this MR do?

Replace `comments.html.haml` and `issue_note.html.haml` used in `notes_spec.js` by dynamically created fixture.

## What are the relevant issue numbers?

#24753

See merge request !7683
2016-12-02 00:44:24 +00:00
winniehell f90b6200e4 Clean up common_utils.js (!7318) 2016-12-01 23:16:09 +01:00
Fatih Acet 629624f30f Merge branch '24814-pipeline-tabs' into 'master'
Pipelines tabs

## What does this MR do?
Changes the URL when the builds tab is clicked making it possible to be shared.

1. Adds a standard way to handle linked tabs:
    *   This behaviour is already present in the merge requests, commit and user `show` page. 
    *    This MR introduces a reusable way to accomplish this behaviour for pages with static content.

2. Adds test:
    *   For the linked tabs reusable class
    *  For the pipelines tabs

## Why was this MR needed?
To allow having a sharable URL that represented the opened tab

![tabs](/uploads/91e663c12c6e9ac46a17aa3a9489dc72/tabs.gif)

## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?
Closes #24814

See merge request !7709
2016-12-01 21:20:59 +00:00
Fatih Acet 1646b81e2a Merge branch 'right-sidebar-fixture' into 'master'
Replace static fixture for right_sidebar_spec

## What does this MR do?

Replace `right_sidebar.html.haml` for `right_sidebar_spec.js` by already existing dynamically generated fixture.

## What are the relevant issue numbers?

#24753

See merge request !7687
2016-12-01 21:03:18 +00:00
Alfredo Sumaran 1919ae9615 Merge branch 'shortcuts-issuable-fixture' into 'master'
Replace static fixture for shortcuts_issuable_spec

## What does this MR do?

Replace `issuable.html.haml` for `shortcuts_issuable_spec.js` by already existing dynamically generated fixture.

## What are the relevant issue numbers?

#24753

See merge request !7685
2016-12-01 16:30:34 +00:00
winniehell c4244ba4c2 Replace static fixture for notes_spec (!7683) 2016-12-01 15:04:07 +01:00
Filipa Lacerda 640062abdb Adds tests for tabs in the rspec for pipelines
Adds tests for the Linked Tabs class

Removes event listener

Adds builds
2016-11-30 17:06:46 +00:00
winniehell bc1b305dcf Replace static fixture for right_sidebar_spec (!7687) 2016-11-28 20:34:45 +01:00
Alfredo Sumaran 2f35ee4577 Merge branch 'zen-mode-fixture' into 'master'
Replace static fixture for zen_mode_spec

## What does this MR do?

Replace `zen_mode.html.haml` for `zen_mode_spec.js` by already existing dynamically generated fixture.

## What are the relevant issue numbers?

#24753

See merge request !7686
2016-11-28 17:52:02 +00:00
Alfredo Sumaran c54827961a Merge branch 'dynamic-build-fixture' into 'master'
Create dynamic fixture for build_spec

## What does this MR do?

Replace `spec/javascripts/fixtures/build.html.haml` by a dynamically created fixture (using `rake teaspoon:fixtures`).

## Why was this MR needed?

The existing fixture was not representing the real page. 

## What are the relevant issue numbers?

#24614 would have been avoided

following !6059

See merge request !7589
2016-11-28 16:43:46 +00:00
winniehell 82429b6978 Explicitly name namespace and projects for frontend fixtures 2016-11-25 11:03:35 +01:00
winniehell 0bf14cb0b5 Create dynamic fixture for build_spec (!7589) 2016-11-25 11:03:31 +01:00
Luis Alonso Chavez Armendariz 5e26745e31 Fix title case to sentence case 2016-11-23 16:34:58 -07:00
winniehell 4b4fd743c3 Replace static fixture for zen_mode_spec (!7686) 2016-11-23 01:29:32 +01:00
winniehell 31a4894a09 Replace static fixture for shortcuts_issuable_spec (!7685) 2016-11-23 01:13:36 +01:00
Grzegorz Bizon de24902852 Improve name of build log state data attribute 2016-11-22 14:48:14 +01:00
Fatih Acet b9c2fb8810 Merge branch '22539-display-folders' into 'master'
Resolve "Display "folders" for environments"

## What does this MR do?
Adds the ability to show the grouped environments inside "folders".
Adds several reusable vue components in order to accomplish the recursive tree data structure presented.

For the individual components, Jasmine tests were added.
For the ones that depend of an API response, rspec tests are used.


## Screenshots (if relevant)
![Screen_Shot_2016-11-16_at_02.00.13](/uploads/1278012c8639b999b53f080728d283e1/Screen_Shot_2016-11-16_at_02.00.13.png)
![Screen_Shot_2016-11-16_at_02.00.25](/uploads/a3d65416ddb553e1b8f0f4c8897a75dc/Screen_Shot_2016-11-16_at_02.00.25.png)
![Screen_Shot_2016-10-17_at_16.08.50](/uploads/af63efe1d2cbd5fc069408622ef4b607/Screen_Shot_2016-10-17_at_16.08.50.png)


![environments](/uploads/b5a1801766d82ab176fc60f96b6968cb/environments.gif)
## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [x] Added for this feature/bug
  - [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?
Closes #22539

See merge request !7015
2016-11-19 17:46:10 +00:00
Kamil Trzcinski 8d0018444d Merge remote-tracking branch 'origin/master' into 22539-display-folders 2016-11-18 20:20:30 +01:00
winniehell 49e726ec33 Add failing test for #24614 2016-11-18 19:11:18 +01:00
Filipa Lacerda 9c3f9d8464 Adds new line to eof 2016-11-16 16:49:13 +00:00
Filipa Lacerda ed07264532 Adds props validation
Improves documentation

Adds tests

Fix prop validation for objects

Finish tests for environment item

Adds tests for toggle folder function

Environment tests

Adds tests
2016-11-16 11:58:21 +00:00
Filipa Lacerda 30c6a7d3ac Adds tests
Adds tests.
Changes instance into a constructor

Adds tests for environments component

Adds tests assertations

Adds external URL test

Adds tests for Rollback component

Adds tests for stop component

Adds tests for actions component
Fix environment item

Init environment item tests
2016-11-16 11:58:13 +00:00
Luke "Jared" Bennett 7cefaea876
explicitly disable eslint inline 2016-11-15 16:30:34 +00:00
Jared Deckard dd45c5e11e
Add javascript unit tests for Build
Move comments to the correct location

Remove array extension usage

Move build options to fixture to match view
2016-11-04 15:07:51 +00:00
Bryce Johnson d939fbed09 Change show-gl-field-errors to gl-show-field-errors 2016-11-02 11:35:21 +01:00