Commit Graph

70 Commits

Author SHA1 Message Date
winh 97e81870c3 Add missing import statements 2017-09-18 12:51:57 +02:00
Phil Hughes cdb305ce68 Fix diff comment button not showing after deleting a comment 2017-09-05 10:20:40 +00:00
Simon Knox 9b9c86787a fix Jump to next discussion
Notes tab was renamed to show, was previously overridden in merge_request_tabs.js
2017-07-27 20:46:53 +10:00
Filipa Lacerda aaa78199c2 Update vue-resource 2017-07-12 14:47:09 +00:00
Bryce Johnson 81e9c28425 Render add-diff-note button with server.
This commit moves the rendering of the button back to the server, and
shows/hides it using opacity rather than display. It also removes the
transform applied to the button on hover (scale). Previously, both of these
factors automatically triggered a reflow, which creates a performance
bottleneck on pages with larger DOM size.

MR: !12103
2017-06-29 12:50:45 -04:00
Douwe Maan dbb78b36e1 Fix title of discussion jump button at top of page 2017-05-26 17:27:16 -05:00
Bryce Johnson 3c668fa04f Consolidate user avatar Vue logic 2017-05-18 16:37:48 -04:00
Eric Eastwood 16da7f2365 Fix linking to resolved note in diff
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/32125
2017-05-12 17:48:29 -05:00
Fatih Acet 0151325dac Merge request widget redesign 2017-05-09 04:15:34 +00:00
Kushal Pandya d586b6cced Add ES lint support to identify poorly written Promises 2017-04-20 11:11:51 +00:00
Alfredo Sumaran e8561287dc Remove IIFEs from diff_notes_bundle.js 2017-04-17 01:35:56 -05:00
Sam Rose ef443a99ee Update ResolveBtn when CommentStore changes state 2017-04-13 17:22:17 -04:00
Douwe Maan bb8cc94668
Don't use original_discussion_id 2017-04-05 17:44:14 +01:00
Mike Greiling 5f7c0bd7b7 remove Cookies class from global space 2017-03-22 03:07:27 -05:00
Mike Greiling d9dedc36c3 remove Vue from the global space 2017-03-20 22:12:01 -05:00
Phil Hughes adeafa40b8 Fixes diff comment avatar tooltip escaping issues
We are safe to use `data-html` because we never actually use HTML here, only the pure markdown

Closes #29572
2017-03-16 15:58:49 +00:00
Bob Van Landuyt 091b846ebe Renamed `.js.es6` to `.js` 2017-03-13 08:27:52 +01:00
Bob Van Landuyt 0267b83898 Delegate a single discussion to a new issue
Delegate a discussion in a merge request into a new issue.
The discussion wil be marked as resolved and a system note will be
added linking to the newly created issue.
2017-03-13 08:27:51 +01:00
Phil Hughes 1466b7eecc Added discussion comments avatars to diff 2017-03-08 16:07:26 +00:00
winniehell 572f9782d5 Remove .es6 from file extensions (!9241) 2017-03-05 21:22:40 +01:00
Annabel Dunstone Gray 19cb7b0a3d Remove navbar height offsets 2017-02-10 15:09:08 -06:00
Phil Hughes f9c58d9388 Refactored diff notes Vue app
It now relies on its Vue bundle rather than the window. Fixes some reactivity issues that was happening in EE
2017-02-09 15:54:19 +00:00
Mike Greiling 96931b1748 resolve all indent eslint violations 2017-01-18 17:16:41 -06:00
Mike Greiling e7b5945c59 resolve all semi and no-extra-semi eslint violations 2017-01-18 17:15:27 -06:00
Mike Greiling 9e4d04913a resolve all no-plusplus eslint violations 2017-01-18 17:15:27 -06:00
Sam Rose 33251af3ab Defer tooltip update on Resolve Comment button after DOM cycle 2016-12-28 12:05:03 -05:00
Mike Greiling 8e0e902b13 resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
Mike Greiling 23f5865e18 expand remaining non-explicit eslint-disable blocks and factor out globals when no-undef encountered 2016-12-13 21:07:31 -06:00
Phil Hughes 948b4828ce Issue board spec fixes 2016-11-10 17:53:34 +03:00
Phil Hughes 4fba69dc90 Fixed up resolve discussions 2016-11-10 17:53:34 +03:00
Fatih Acet 99b421da2c Migrate Vue v1 to v2. 2016-11-10 17:53:34 +03:00
winniehell 02f94cf038 disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
Phil Hughes 5461a5d10a Pass the full project path for resolve buttons
This fixes an issue that would stop the resolve buttons working when GitLab is installed with a relative URL

Closes #21704
2016-09-21 10:07:24 +01:00
Douwe Maan ac89bb0fad Fix jumping between discussions on changes tab 2016-08-18 18:14:47 -05:00
Douwe Maan 409bc05428 Fix bug causing “Jump to discussion” button not to show 2016-08-18 16:56:13 -05:00
Connor Shea 36fd507b4b
Function should return a boolean. 2016-08-17 12:42:16 -06:00
Connor Shea 26c49cc156
Forgot another one. 2016-08-17 12:30:59 -06:00
Connor Shea c648756a36
Fix more incomplete if/else statements. 2016-08-17 12:18:53 -06:00
Connor Shea f3acf9fd24
Remove non-standard VueJS files from vendor. 2016-08-17 10:01:26 -06:00
Connor Shea c8df2c5f06
Add return statements for if statements that were missing them. 2016-08-17 08:38:23 -06:00
Connor Shea 32e31d626f
Resolve feedback. 2016-08-15 11:25:28 -06:00
Douwe Maan 33edde50ab Don’t show “Resolve discussion” for non-author/members 2016-08-12 15:10:05 -05:00
Connor Shea 6073b281aa
Fix a bug and a test. 2016-08-10 09:13:55 -06:00
Connor Shea d7d69b2839
If the next discussion is closed, toggle it open. 2016-08-09 11:53:29 -06:00
Douwe Maan ffbba55bc8 Implement Jump behavior for Changes tab 2016-08-04 18:01:32 -07:00
Phil Hughes 69c7fc5f72 Jumps between discussions on the changes tab
Ordered the jump to discussion by order in the DOM
2016-08-04 11:02:04 +01:00
Phil Hughes 433f1c42c3 Comment & resolve button no longer looks for can-resolve attribute
Fixed some bugs when removing notes
2016-08-04 09:52:17 +01:00
Phil Hughes ee62a2fd5a Moved update headline HTML into discussion model 2016-08-01 11:31:35 +01:00
Phil Hughes f65d8eb326 Updated method name to be more descriptive 2016-08-01 10:15:15 +01:00
Phil Hughes 9accca43c3 Unminified versions of vue & vue-resource 2016-08-01 10:09:30 +01:00