c6edae3887
Load commit in batches for pipelines#index
...
Uses `list_commits_by_oid` on the CommitService, to request the needed
commits for pipelines. These commits are needed to display the user that
created the commit and the commit title.
This includes fixes for tests failing that depended on the commit
being `nil`. However, now these are batch loaded, this doesn't happen
anymore and the commits are an instance of BatchLoader.
2017-12-19 10:05:40 +01:00
ab16a6fb34
Optimise getting the pipeline status of commits
...
This adds an optimised way of getting the latest pipeline status for a
list of Commit objects (or just a single one).
2017-11-16 16:01:14 +01:00
902b5347dc
Prepare Repository#merge for migration to Gitaly
2017-09-15 16:39:20 +02:00
934eef7290
Improve description of a Commit#cherry_pick_message UT
2017-08-22 22:20:22 +02:00
7a8a8e0764
Fix rubocop errors in spec/models/commit_spec.rb
2017-08-21 22:13:41 +02:00
e6220c018e
Add UT for cherry-pick of an existing merge that is not found
2017-08-21 21:05:11 +02:00
9ec358af7b
Reverse order of commits in MR cherry-pick message
...
Also improved the UT for better documenting this change.
2017-08-21 20:47:18 +02:00
b4622c772e
Remove redundant statement part in a test suite
2017-08-18 08:30:14 +02:00
c0f921606c
Correct the cherry-pick message for merge commits
...
The list of commits must be generated from the merge request,
not from a diff of the branches.
2017-08-17 22:38:47 +02:00
919c0c7ba7
Extended UTs for the new cherry-pick message format
2017-08-16 13:18:07 +02:00
3ce6f03f14
Incorporate Gitaly's CommitService.FindCommit RPC
2017-08-07 23:33:43 -04:00
c21ae07e33
Refactor Gitlab::Git::Commit to include a repository
2017-08-07 22:34:34 -04:00
72a7b30c9f
Change all `:empty_project` to `:project`
2017-08-02 17:47:31 -04:00
abb878326c
Rename many path_with_namespace -> full_path
2017-08-01 07:26:58 +02:00
ddccd24c13
Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
aada5273fa
Use RequestStoreWrap for Commit#author
...
We also try to use instance variable to cache the result if
RequestStore is not available, so we could keep the same logic,
using the same cache key. Also introduce a way to specify method
specific cache key
2017-07-18 01:18:20 +08:00
a6ec5121f0
Correct RSpec/SingleLineHook cop offenses
2017-06-14 13:18:56 -05:00
b173ae6b48
Fix linting, route, and specs
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-06-09 17:21:39 +02:00
54c04f53fd
Fix spec failures and add a feature flag for the performance bar
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-06-09 17:21:39 +02:00
8ce11fc388
Merge branch '12614-fix-long-message' into 'master'
...
Fix long urls in the title of commit
Closes #12614
See merge request !10938
2017-06-08 10:32:45 +00:00
99feed6e00
Add support for deltas_only under Gitaly
...
Closes gitaly#199
2017-05-13 18:27:06 +02:00
fdba744986
Fix long urls in the title of commit
2017-05-12 11:45:26 +00:00
27fb64d6a3
Remove deltas_only from DiffCollection
2017-05-11 16:01:10 +02:00
34cd109797
Re-enable Gitaly commit_raw_diff feature
2017-05-07 23:37:42 +02:00
0a29bde4a1
Rename latest_pipeline to last_pipeline
...
As it might be confusing that it's not the same as
Pipeline#latest
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11038#note_28677090
2017-05-03 01:40:49 +08:00
d6cc8feb6c
Setup and run a Gitaly server for testing if GitalyClient is enabled
2017-04-11 16:00:44 -03:00
5409a3c5b7
Merge branch 'feature/use-gitaly-for-commit-show' into 'master'
...
Use Gitaly for CommitController#show
See merge request !9629
2017-03-17 17:41:44 +00:00
ec970763e9
Adds pipeline mini-graph to system information box in Commit View
2017-03-16 00:44:31 +00:00
c0a4f527db
Use Gitaly for CommitController#show
2017-03-15 12:52:11 +02:00
fcb37542e7
Use `:empty_project` where possible in model specs
2017-01-26 17:44:59 -05:00
dd3ddcd72b
Allows to search within project by commit's hash
...
Was proposed in #24833
2017-01-24 14:56:00 +03:00
e59623e738
Mark MR as WIP when pushing WIP commits
2017-01-19 12:30:34 +01:00
d9000184e5
Add explicit status test, feedback:
...
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_20058993
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_20059060
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_20059357
2016-12-15 18:52:36 +08:00
cc6f578d5f
Use described_class and update description
...
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_20059124
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_20059187
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_20059322
2016-12-15 18:16:22 +08:00
7cced60069
Introduce latest_status and add a few tests
...
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_20003268
2016-12-14 23:37:49 +08:00
367024f170
Merge remote-tracking branch 'upstream/master' into show-commit-status-from-latest-pipeline
...
* upstream/master: (557 commits)
Fix wrong error message expectation in API::Commits spec
Move admin settings spinach feature to rspec
Encode when migrating ProcessCommitWorker jobs
Prevent overflow with vertical scroll when we have space to show content
Make rubocop happy
API: Ability to cherry-pick a commit
Be smarter when finding a sudoed user in API::Helpers
Backport hooks on group policies for the EE-specific implementation
API: Ability to get group's project in simple representation
Add AddLowerPathIndexToRoutes to setup_postgresql.rake
For single line git commit messages, the close quote should be on the same line as the open quote
added border-radius and padding to labels
Allow all alphanumeric characters in file names (!8002 )
Add failing test for #20190
Don't allow blank MR titles in API
Replace static fixture for awards_handler_spec (!7661 )
Crontab typo '* */6' -> '0 */6' (4x/day not 1x-per-min-for-1h 4x/day)
Fix test
Tweak style and add back wording
Clean up commit copy to clipboard and make consistent
...
2016-12-14 19:24:31 +08:00
f23b1cb453
Merge branch 'jej-23867-use-mr-finder-instead-of-access-check' into 'security'
...
Replace MR access checks with use of MergeRequestsFinder
Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867
⚠️ - Potentially untested
💣 - No test coverage
🚥 - Test coverage of some sort exists (a test failed when error raised)
🚦 - Test coverage of return value (a test failed when nil used)
✅ - Permissions check tested
- [x] 💣 app/finders/notes_finder.rb:17
- [x] ⚠️ app/views/layouts/nav/_project.html.haml:80 [`.count`]
- [x] 💣 app/controllers/concerns/creates_commit.rb:84
- [x] 🚥 app/controllers/projects/commits_controller.rb:24
- [x] 🚥 app/controllers/projects/compare_controller.rb:56
- [x] 🚦 app/controllers/projects/discussions_controller.rb:29
- [x] ✅ app/controllers/projects/todos_controller.rb:27
- [x] 🚦 app/models/commit.rb:268
- [x] ✅ lib/gitlab/search_results.rb:71
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)`
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`.
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use of unchecked `merged_merge_request?`
See merge request !2033
2016-12-08 21:42:07 -03:00
f272ee6eba
Add shorthand support to gitlab markdown references
2016-12-02 19:18:17 -02:00
6b4d33566f
Pass commit data to ProcessCommitWorker
...
By passing commit data to this worker we remove the need for querying
the Git repository for every job. This in turn reduces the time spent
processing each job.
The migration included migrates jobs from the old format to the new
format. For this to work properly it requires downtime as otherwise
workers may start producing errors until they're using a newer version
of the worker code.
2016-12-01 13:36:06 +01:00
3a99e36e44
Avoid using random in the tests, feedback:
...
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_18860042
2016-11-24 16:27:57 +08:00
5ea2628921
Fix test description to mention latest pipeline,
...
feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_18819886
2016-11-23 18:25:32 +08:00
721f2d3788
Still use compound pipeline status, but group by
...
ref and sha so that it would show latest pipeline
if ref and sha are both specified, otherwise still
the same as before.
2016-11-21 22:19:16 +08:00
18a71c4760
Show commit status from latest pipeline
...
Rather than compound status from all pipelines.
Closes #20560
2016-11-08 00:04:18 +08:00
f3c3d8e63b
There's no such method
2016-11-04 00:00:03 +08:00
1ae557c106
Merge status_for and status, feedback:
...
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7034#note_17742297
2016-11-03 23:39:37 +08:00
3e6a527e68
Add tests for Commit#status and Commit#status_for, feedback:
...
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7034#note_17543036
2016-10-28 03:47:49 +08:00
c90483406e
refactors tests because of gitlab-test repository changes
2016-10-11 16:33:06 +01:00
e4c517a635
Expand commit message width in repo view
2016-08-02 11:40:44 -05:00
d27e36f35a
Add specs for caching commit author
2016-07-27 16:42:38 -07:00
939436480c
Ensure relative paths for video are rewritten as we do for images
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-07-26 10:22:17 +02:00
Zeger-Jan van de Weg
Yorick Peterse
Jacob Vosmaer
Saverio Miroddi
Alejandro Rodríguez
Robert Speicher
Gabriel Mazetto
Rémy Coutable
Lin Jen-Shin
Dmitriy Zaporozhets
Ahmad Sherif
Alexander Randa
Robert Speicher
Filipa Lacerda
YarNayar
jurre
Douwe Maan
Oswaldo Ferreira
tiagonbotelho
Clement Ho
Stan Hu