Commit Graph

112 Commits

Author SHA1 Message Date
Grzegorz Bizon 57451f52cd Memoize CI config node validator to prevent leaks 2016-08-09 11:29:32 +02:00
Grzegorz Bizon a42cce1b96 Improve code, remove unused validator, improve names 2016-07-29 14:09:35 +02:00
Grzegorz Bizon f83bccfe4f Add minor readability, style improvements in CI config 2016-07-20 14:02:09 +02:00
Grzegorz Bizon 6d466733a2 Validate allowed keys only in new CI config 2016-07-18 16:26:38 +02:00
Grzegorz Bizon 7cef4f1908 Improve valid keys validation for CI config nodes 2016-07-18 15:38:06 +02:00
Grzegorz Bizon 24b686ebb6 Move job artifacts configuration new CI config code 2016-07-18 15:21:53 +02:00
Grzegorz Bizon 1bf9e34713 Move except and only job nodes to new CI config 2016-07-18 12:37:42 +02:00
Grzegorz Bizon 17084d42aa Simplify abstract class for CI config entry nodes 2016-07-15 22:49:18 +02:00
Grzegorz Bizon 4bb60b0789 Simplify CI config and remove logical validation 2016-07-15 21:39:26 +02:00
Grzegorz Bizon 41bcbdd8c2 Add metadata to new CI config and expose job name 2016-07-15 21:07:51 +02:00
Grzegorz Bizon 5923741fe6 Remove references to global entry in new CI config 2016-07-14 15:45:29 +02:00
Grzegorz Bizon 3e16b015b9 Revert logical validation in CI job stage entry 2016-07-14 15:45:07 +02:00
Grzegorz Bizon f7c80e9f31 Revert references to global node in CI job entry 2016-07-14 15:07:38 +02:00
Grzegorz Bizon 56ae9f6ba9 Improve CI job entry validations in new config 2016-07-14 13:14:09 +02:00
Grzegorz Bizon 036e297ca3 Expose CI job commands and use in legacy processor 2016-07-13 15:04:12 +02:00
Grzegorz Bizon 6920390aad Add before script and commands to CI job entry 2016-07-13 14:38:10 +02:00
Grzegorz Bizon de4c9a2738 Improve CI stage configuration entry validations 2016-07-13 12:22:33 +02:00
Grzegorz Bizon b228787f5a Do not raise when getting value of invalid CI node 2016-07-12 14:58:48 +02:00
Grzegorz Bizon 06641a3fee Simplify undefined node definition in CI config 2016-07-12 14:28:50 +02:00
Grzegorz Bizon d41d330147 Add CI config node that is unspecified null entry 2016-07-12 13:03:19 +02:00
Grzegorz Bizon 80587064eb Require parent when using node factory in CI config 2016-07-10 20:59:18 +02:00
Grzegorz Bizon 8f7c98ee2a Rename CI config job script entry node to commands 2016-07-10 20:26:37 +02:00
Grzegorz Bizon 500b61e14f Move after script CI job confg to new processor 2016-07-10 14:41:14 +02:00
Grzegorz Bizon 489e9be4e8 Add CI job script node in new config processor 2016-07-10 14:35:53 +02:00
Grzegorz Bizon 3c5b1da2a1 Add before_script node to CI job entry config 2016-07-10 13:54:39 +02:00
Grzegorz Bizon 2480701436 Extend CI job entries fabrication and validation 2016-07-09 18:43:26 +02:00
Grzegorz Bizon 9edced40dd Use node factory to assemble global CI config entry 2016-07-09 16:51:26 +02:00
Grzegorz Bizon ccbdb4022a Integrate CI job stage entry into CI configuration 2016-07-09 14:56:41 +02:00
Grzegorz Bizon d9142f2c97 Add CI config known stage validation for job stage 2016-07-08 13:31:41 +02:00
Grzegorz Bizon 1ac62de2c1 Extract CI entry node validator and improve naming 2016-07-08 12:51:47 +02:00
Grzegorz Bizon 8baee987be Extract internal attributes validator for CI entry 2016-07-08 11:27:36 +02:00
Grzegorz Bizon 3da57c800b Require reference to CI config for some entries 2016-07-07 15:15:44 +02:00
Grzegorz Bizon a7ac2f7494 Simplify CI config entry node factory, use attribs 2016-07-07 15:00:35 +02:00
Grzegorz Bizon 9410aecca8 Add scaffold of CI config for the job stage entry 2016-07-07 13:40:01 +02:00
Grzegorz Bizon fea7762485 Delegate methods to default CI entry if undefined 2016-07-07 12:55:10 +02:00
Grzegorz Bizon b0ae0d730f Use only node factory to create CI config entries 2016-07-07 10:23:47 +02:00
Grzegorz Bizon 4491bf28e1 Move CI job config validations to new classes 2016-07-06 14:08:19 +02:00
Grzegorz Bizon b1b0c18b8c Add hidden job in new CI config that is irrelevant 2016-07-06 12:58:43 +02:00
Grzegorz Bizon dbab56a951 Create composite job entries in new CI config 2016-07-05 14:48:17 +02:00
Grzegorz Bizon 6ae80732bb Add ability to define nodes in new CI config entry 2016-07-05 14:17:09 +02:00
Grzegorz Bizon e00ae9a877 Add new CI config entry for single job in pipeline 2016-07-05 14:05:07 +02:00
Grzegorz Bizon 5b7f211cbb Add new CI config entry that holds jobs definition 2016-07-05 13:35:50 +02:00
Grzegorz Bizon cf53d79873 Extract jobs config to separate key in config hash 2016-07-05 13:07:03 +02:00
Rémy Coutable 06c7d6f3a8 Merge branch 'refactor/ci-config-move-global-entries' into 'master'
Move global ci entries handling from legacy to new config

## What does this MR do?

This MR moves responsibility of handling global CI config entries (like `image`, `services`), from legacy `GitlabCiYamlProcessor` to new CI Config

## Why was this MR needed?

This is the next iteration of CI configuration refactoring

## What are the relevant issue numbers?

#15060

## Does this MR meet the acceptance criteria?

- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)

See merge request !4820
2016-07-05 08:37:16 +00:00
Grzegorz Bizon bfad4c61f1 Add minor improvements in readability in CI config 2016-07-04 18:36:06 +02:00
Grzegorz Bizon 9e211091a8 Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
Grzegorz Bizon b4f03e8b1e Improve description of CI types node and in specs 2016-06-30 12:59:17 +02:00
Grzegorz Bizon f4421817de Add global cache config entry to new CI config 2016-06-29 09:48:52 +02:00
Grzegorz Bizon 92312786f1 Add CI config entry location info to error message
This CI config entry location in configuration Hash.
2016-06-29 09:17:42 +02:00
Grzegorz Bizon 7c511c2f55 Make it possible to set parent in CI config node 2016-06-29 09:05:14 +02:00