Winnie Hellmann
514ee63826
Move some tests from Karma to Jest
2019-03-23 17:53:46 +01:00
Filipa Lacerda
700ae637d2
Moves utility function into CE
2019-03-01 11:27:39 +00:00
Filipa Lacerda
1c30b12b86
Merge branch 'sh-fix-double-xhr-pipelines' into 'master'
...
Remove duplicate XHR request when requesting new pipeline page
Closes #58095
See merge request gitlab-org/gitlab-ce!25506
2019-02-25 09:39:18 +00:00
Stan Hu
ec5bbd27f5
Remove duplicate XHR request when requesting new pipeline page
...
When a user clicked on another page in the pipeline page, the following
would happen:
1. PipelinesService.getPipelines() would be called to fetch the new page
2. In the success handler, Poll.restart() would be called
3. This would invoke Poll.makeRequest(), which would fire off a new
request.
To fix this, we introduce a enable(), which will:
1. Update the request data accordingly
2. Clear the old timeout if necessary and start a new timer
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58095
2019-02-23 21:27:53 -08:00
Winnie Hellmann
532d43d52c
Remove convertPermissionToBoolean() from common_utils.js
2019-02-21 11:05:16 +01:00
Winnie Hellmann
69f9ec77c2
Move ajax_cache_spec.js to Jest
2019-02-21 09:39:59 +01:00
Constance Okoghenun
123da43182
CE Port of fix for roadmap forward timeline scroll
...
EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9530
2019-02-13 20:37:08 +01:00
Nick Thomas
041316636b
Merge branch 'fix-repo-settings-file-upload-error' into 'master'
...
Fix bug causing repository mirror settings UI to break
Closes #55134
See merge request gitlab-org/gitlab-ce!23712
2019-02-07 12:27:08 +00:00
Adriel Santiago
b3bd24053e
Use svg icon for deployment series
...
Use the rocket GitLab SVG to show deployment data
2019-02-05 08:15:57 -05:00
Phil Hughes
97041bb6c4
Merge branch 'fe-grammar-util' into 'master'
...
FE grammar util
See merge request gitlab-org/gitlab-ce!24893
2019-02-05 10:33:47 +00:00
Paul Slaughter
9cfb253ed4
Add grammar util
...
This contains the function `toNounSeriesText` which can be used to build
i18n noun series fragments (i.e. "A, B, and C").
2019-02-04 11:17:33 -06:00
Adriel Santiago
c974f4a82e
Handle window and container resize events
...
Resizes metrics graph on window and sidebard width changes
2019-02-04 08:04:45 -05:00
Kushal Pandya
93e58bf9b5
Support for ignore rules in 'convertObjectPropsToCamelCase' helper
...
Does following enhancements to `convertObjectPropsToCamelCase` helper;
- Adds support for `dropKeys` within options param
to discard properties.
- Adds support for `allowKeys` within options param
to skip converting property names.
2019-01-31 17:02:46 +05:30
Lukas Eipert
91df6d9ef4
Make favicon tests more fault resistent
...
It seems like every new version of Chrome renders the favicon canvas
differently. This reduces the problems with it by creating a more fault
tolerant check, which compares the color values in the pixels and is
okay if they are within a certain threshold.
2019-01-21 20:48:55 +01:00
Winnie Hellmann
159c18221d
Make parseBoolean idempotent
2019-01-15 06:04:37 +00:00
Scott Escue
87c571f8a3
Addressing feedback from most recent reviews.
2019-01-10 00:00:39 -06:00
Scott Escue
2cbc475e53
Fixing static analysis issues
2019-01-10 00:00:39 -06:00
Scott Escue
a3541a8d8d
Removing the URL manipulation functions added to 'common_utils.js' in favor of the functions that already existed in 'url_utility.js'. Refactoring 'removeParams' function in 'url_utility.js' to allow url to be passed and to preserve the original host and/or path provided in the url.
2019-01-10 00:00:39 -06:00
Scott Escue
4dcaa4df36
Addressing peer review feedback.
...
Replacing inline JS with ES 2015 functions included in pages/sessions/new. Also applying suggested server-side syntax improvements to OmniAuthCallbacksController.
2019-01-10 00:00:39 -06:00
Fatih Acet
5106f88a48
Merge branch 'kp-7325-add-lib-helpers' into 'master'
...
CE Backport: Add library helpers to use in Roadmap
See merge request gitlab-org/gitlab-ce!24232
2019-01-08 15:06:20 +00:00
Kushal Pandya
2bb73dab72
Add `newDate` helper, update `getTimeframeWindowFrom`
...
Adds `newDate` helper to copy date object without keeping reference.
Adds negative length support in `getTimeframeWindowFrom` to go
back in time.
2019-01-08 19:41:57 +05:30
Kushal Pandya
214d741ba5
Add support for `offset` values in `isInViewport`
2019-01-08 18:37:21 +05:30
Phil Hughes
12edecd002
Add headers to files in the tree list on merge requests
...
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54807
2019-01-08 09:31:23 +00:00
Luke Bennett
6b466e3873
Fix bug causing repo mirror settings UI to break
...
Fixes an exception relating to the new project
cleanup settings in 11.6 that causes the mirror
repo settings UI to become unusable.
2019-01-08 06:25:23 +00:00
Sam Bigelow
066a99b6e9
Add markdown buttons to file editor
...
Currently, we have markdown files in many places (e.g. comments, new
issues, etc.). This Merge Request detects if the file being edited is a
markdown file and adds markdown buttons and their functionality to the
single file editor (Not the web IDE)
2019-01-02 08:24:32 -08:00
Tim Zallmann
ddd4cc649f
Resolve "Extended user centric tooltips"
2018-12-08 03:12:23 +00:00
Paul Slaughter
38431c8f99
CE Port of "Web Terminal FE"
2018-12-07 16:29:32 +00:00
Nick Thomas
9395d198f9
Use BFG object maps to clean projects
2018-12-06 18:58:00 +00:00
Thomas Holder
fe76827f17
Resolve "mergeUrlParams wrong with fragment url"
2018-11-30 09:49:22 +00:00
Winnie Hellmann
47fad3353f
Add parseBoolean helper function
2018-11-27 09:18:48 +01:00
Mike Greiling
5b9495c5db
Prettify all the things
2018-11-20 09:30:01 -06:00
Johann Hubert Sonntagbauer
65de10ec6d
Refine cursor positioning in Markdown Editor for wrap tags.
2018-11-20 06:57:00 +00:00
Constance Okoghenun
baa37edd93
Resolve "Issue board card design"
2018-11-07 17:20:17 +00:00
Achilleas Pipinellis
7f47e13218
Merge branch 'gt-update-typos-in-comments-and-specs' into 'master'
...
Fix typos in comments and specs
See merge request gitlab-org/gitlab-ce!22683
2018-11-01 10:34:23 +00:00
George Tsiolis
733ae94921
Fix typos in comments and specs
2018-11-01 08:59:20 +02:00
Mike Greiling
3d13d369f9
Fix eslint violations
2018-10-31 14:33:12 -05:00
Mike Greiling
160157a92b
Prettify remaining files with differences in CE and EE
2018-10-31 14:33:12 -05:00
Phil Hughes
2bbfca8240
Merge branch '52115-Link-button-in-markdown-editor-should-recognize-URLs' into 'master'
...
Link button in markdown editor recognize URLs
Closes #52115
See merge request gitlab-org/gitlab-ce!22547
2018-10-26 07:56:32 +00:00
Winnie Hellmann
50222d4dc6
Add calculateRemainingMilliseconds() helper function
2018-10-25 18:46:45 +02:00
Winnie Hellmann
048ec28761
Move datetime_utility_spec.js to correct location
2018-10-25 18:40:59 +02:00
Kushal Pandya
135ef0465d
Add pikaday parsing methods
...
Adds methods from `app/assets/javascripts/lib/utils/datefix.js`
and deletes the files
2018-10-25 15:09:50 +05:30
Johann Hubert Sonntagbauer
861772846b
Link button in markdown editor recognize URLs
2018-10-24 19:25:52 +02:00
Mike Greiling
f666026d71
Prettify all spec files
2018-10-17 11:18:17 -05:00
Johann Hubert Sonntagbauer
6f5723a169
enable jasmine/new-line-before-expect
2018-10-17 06:57:29 +02:00
Johann Hubert Sonntagbauer
0fd203ba24
enable jasmine/no-promise-without-done-fail
2018-10-16 21:31:16 +02:00
Mike Greiling
da4f77957c
Merge branch '51712-prefer-jasmine-matcher' into 'master'
...
4. enable jasmine/prefer-jasmine-matcher
See merge request gitlab-org/gitlab-ce!22236
2018-10-11 21:55:03 +00:00
Johann Hubert Sonntagbauer
db4c1f665f
enable jasmine/prefer-jasmine-matcher
2018-10-09 20:30:03 +02:00
Johann Hubert Sonntagbauer
2a76e04091
enable jasmine/new-line-between-declarations
2018-10-09 19:01:49 +02:00
Jan Beckmann
ceafbbd317
Resolve "Add "Link" shortcut/icon in markdown editor to make it easier to add references"
2018-10-02 13:59:42 +00:00
Mike Greiling
1f177a385d
Upgrade eslint-plugin-jasmine and resolve violations
2018-09-20 02:40:18 -05:00