Commit Graph

61 Commits

Author SHA1 Message Date
Winnie Hellmann 532d43d52c Remove convertPermissionToBoolean() from common_utils.js 2019-02-21 11:05:16 +01:00
Constance Okoghenun 123da43182 CE Port of fix for roadmap forward timeline scroll
EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9530
2019-02-13 20:37:08 +01:00
Adriel Santiago c974f4a82e
Handle window and container resize events
Resizes metrics graph on window and sidebard width changes
2019-02-04 08:04:45 -05:00
Kushal Pandya 93e58bf9b5 Support for ignore rules in 'convertObjectPropsToCamelCase' helper
Does following enhancements to `convertObjectPropsToCamelCase` helper;
- Adds support for `dropKeys` within  options param
to discard properties.
- Adds support for `allowKeys` within options param
to skip converting property names.
2019-01-31 17:02:46 +05:30
Lukas Eipert 91df6d9ef4
Make favicon tests more fault resistent
It seems like every new version of Chrome renders the favicon canvas
differently. This reduces the problems with it by creating a more fault
tolerant check, which compares the color values in the pixels and is
okay if they are within a certain threshold.
2019-01-21 20:48:55 +01:00
Winnie Hellmann 159c18221d Make parseBoolean idempotent 2019-01-15 06:04:37 +00:00
Kushal Pandya 214d741ba5 Add support for `offset` values in `isInViewport` 2019-01-08 18:37:21 +05:30
Winnie Hellmann 47fad3353f Add parseBoolean helper function 2018-11-27 09:18:48 +01:00
Mike Greiling 5b9495c5db
Prettify all the things 2018-11-20 09:30:01 -06:00
Mike Greiling 3d13d369f9
Fix eslint violations 2018-10-31 14:33:12 -05:00
Mike Greiling 160157a92b
Prettify remaining files with differences in CE and EE 2018-10-31 14:33:12 -05:00
Johann Hubert Sonntagbauer 6f5723a169 enable jasmine/new-line-before-expect 2018-10-17 06:57:29 +02:00
Johann Hubert Sonntagbauer 0fd203ba24 enable jasmine/no-promise-without-done-fail 2018-10-16 21:31:16 +02:00
Mike Greiling da4f77957c Merge branch '51712-prefer-jasmine-matcher' into 'master'
4. enable jasmine/prefer-jasmine-matcher

See merge request gitlab-org/gitlab-ce!22236
2018-10-11 21:55:03 +00:00
Johann Hubert Sonntagbauer db4c1f665f enable jasmine/prefer-jasmine-matcher 2018-10-09 20:30:03 +02:00
Johann Hubert Sonntagbauer 2a76e04091 enable jasmine/new-line-between-declarations 2018-10-09 19:01:49 +02:00
Tim Zallmann 44cb8a7407 Merge branch 'boards-querystring-backport' into 'master'
don't add trailing = when in urlParamsToArray function

See merge request gitlab-org/gitlab-ce!21179
2018-09-07 10:20:27 +00:00
🌴🌴 Filipa Lacerda - OOO back on September 17th 🌴🌴 55582b4359 Adds Vuex store for the job log page 2018-09-03 07:49:52 +00:00
Simon Knox 8a5121eb8e don't add trailing = when in urlParamsToArray function 2018-08-29 06:28:06 +10:00
Kushal Pandya b487881494 Add `roundOffFloat` helper method 2018-07-24 12:58:08 +05:30
Felipe Artur 3e66795ef1 Changes tab VUE refactoring 2018-06-21 12:22:40 +00:00
gfyoung bce890820f Enable no-restricted-globals in JS files 2018-06-15 15:58:27 +00:00
Alexis Reigel 9e14f437b6
create favicon overlay on the client
the initial reason for this change was that graphicsmagick does not
support writing to ico files. this fact lead to a chain of changes:

1. use png instead of ico (browser support is good enough)
2. render the overlays on the client using the canvas API. this way we
   only need to store the original favion and generate the overlay versions
   dynamically.
   this change also enables (next step) to simplify the handling of the
   stock favicons as well, as we don't need to generate all the versions
   upfront.
2018-06-05 16:20:21 +02:00
Alexis Reigel 5202c3f0c8
fix resetFavicon so that it actually resets 2018-06-05 16:20:21 +02:00
Kushal Pandya e4ec50b70b Add support for query params for labels endpoint 2018-03-02 23:29:39 +05:30
Kushal Pandya 3976368808 Add `convertObjectPropsToCamelCase` helper method 2018-02-07 21:32:38 +05:30
Phil Hughes 4377b4795f
remove useless ajaxPost method 2018-02-01 09:14:53 +00:00
Phil Hughes a3356bce09
fixed eslint 🙈 2018-01-31 15:48:12 +00:00
Phil Hughes 5d88e736ac
Merge branch 'master' into ph-axios-2 2018-01-31 15:45:02 +00:00
Clement Ho 2f1a55fa4e Use axios instead of jquery ajax for setCiStatusFavicon 2018-01-31 15:24:54 +00:00
Phil Hughes 641f1d2c4b
Converted common_utils to axios 2018-01-31 10:14:55 +00:00
Filipa Lacerda 4563156256 Improve environments performance 2017-11-23 12:04:03 +00:00
Filipa Lacerda be4abe7719 Stops page reload when changing tabs or pages - uses API requests instead 2017-11-14 15:35:29 +00:00
Clement Ho 22a120a24d Improve sprite icon spec 2017-10-17 16:19:40 +00:00
Clement Ho 13b299f4ff Add ability to pass class name to spriteIcon helper 2017-10-12 12:43:00 -05:00
Phil Hughes d729aa7383
spec fix 2017-09-29 09:40:21 +01:00
Phil Hughes 333cb069af
Fixed anchored content not being scrolled into view
Correctly scrolls anchored content into view when the user loads the
page. This is most obvious when the user loads a link note in a
merge request & the page does not scroll down to the note.

Closes #38326
2017-09-29 09:24:56 +01:00
Tim Zallmann 55f772bb98 Resolve "Better SVG Usage in the Frontend" 2017-09-22 08:39:47 +00:00
Filipa Lacerda 96e6fc70b4 Import modules instead of using the ones in global namespace
Removes set favicon related methods from global scope
Improves test related with favicon

Removes convertPermissionToBoolean from global scope.
Adds tests for convertPermissionToBoolean - were non existant

Removes setParamInURL from gl.utils

Removes parseIntPagination from gl.utils namespace

Remove normalizeCRLFHeaders from gl.utils namespace

Removes normalizeHeaders from gl.utils namespace

Use gl.utils for filtered search

Fix bad import

Fix broken test by cleaning window.history namespace

Adds changelog
2017-09-09 09:54:27 +01:00
Filipa Lacerda 6a1b84c7b4 Use modules in common utils 2017-09-09 09:54:24 +01:00
Mike Greiling d4cb1ec9e9 fix unnecessarily long gl.utils.backOff test 2017-08-18 03:01:23 -05:00
Filipa Lacerda b2b527a690 Update tests to test what the component renders and what the clicks calls 2017-07-07 22:23:13 +01:00
Alfredo Sumaran a65f07a256 Address feedback 2017-06-07 10:05:17 -05:00
Lin Jen-Shin c94db0c290 Use - as the prefix so we don't conflict with namespaces
The decision was made around:
https://gitlab.com/gitlab-org/gitlab-ce/issues/26407#note_30624641
2017-05-26 23:06:20 +08:00
Lin Jen-Shin 70eb0c6a88 Merge remote-tracking branch 'upstream/master' into rename-builds-controller
* upstream/master: (307 commits)
  Address feedback
  Add small update for the i18n guide.
  update webpack to v2.6.1 patch release to fix "Can't find variable: Promise" error
  update webpack-bundle-analyzer past v2.4.1 to support NamedChunksPlugin
  name all webpack chunks to improve long term cacheability
  add NameAllModulesPlugin to cover shortcomings of NamedModulesPlugin
  upgrade to latest webpack version
  Only use DROP INDEX CONCURRENTLY on postgreql 9.2+
  Provide default for calculating label text color (!11681)
  Add failing test for #32728
  Bugfix: Always use the default language when generating emails.
  Remove unecessary commit pattern check
  Add regexp_for_value helper method
  Remove shared example and improve sub_group_issuables_spec.rb
  Remove 'should' from scenario in has_subgroup_title_spec.rb
  Cartfile git and binary methods cannot take a GitHub repo
  Fix terminals support for Kubernetes service
  Add review comments to compare_spec.rb
  Fix transient error clicking dropdown items in compare_spec.rb
  Use non-global jQuery reference within raven bundle
  ...
2017-05-26 18:25:32 +08:00
Lin Jen-Shin 71777a4a18 Rename BuildsController to JobsController
Rename other URL generators

admin_builds_path -> admin_jobs_path

Fix tests and more renaming

Fix more tests

Also change build_id to job_id in the controller
2017-05-17 20:17:30 +08:00
Mike Greiling 283f968ef2 update frontend specs to use ES module syntax 2017-05-16 16:01:51 -05:00
Phil Hughes 477be05661 Fixed issue boards not filtering when URL params are encoded
Closes #32084
2017-05-12 09:27:21 +01:00
Kushal Pandya 645593e5af Add instant comments support 2017-05-05 10:57:29 +00:00
Kushal Pandya d586b6cced Add ES lint support to identify poorly written Promises 2017-04-20 11:11:51 +00:00