This enables FindCommit caching to the following actions:
* BlobController#show
* RefsController#logs_tree
It also improves caching in CommitsController since some
duplicate requests were occuring inside the before_action
definitions.
In order to have an accurate date about the last activity of a User
we need to update the last_activity_on field when the User is visiting
some basic pages of GitLab like pages related to Dashboards, Projects,
Issues and Merge Requests
By visiting `projects/:id` you will be redirected to project page with
path in it.
projects/123 => foo/bar
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
[master] Resolve "Personal access token with only `read_user` scope can be used to authenticate any web request"
See merge request gitlab/gitlabhq!2583
System hooks were not being triggered when projects were archived or
unarchived. Reuse the Projects::UpdateService to automatically
trigger system hooks and increase code reuse.
Rails 5.0 requires to explicitly permit attributes when building a URL
using current `params` object.
The `safe_params` helper allows developers to just call `safe_params.merge(...)`
instead of manually adding `permit` to every call.
https://github.com/rails/rails/pull/20868
By extracting a new `filter_items` method, we can override that in the
IssuesFinder and MergeRequestsFinder separately, so we don't need checks that
the model is the correct one, because we can just use the class we're in to know
that.
We can do the same for the VALID_PARAMS constant, by making it a class method.
This ensures that we have more visibility in the number of SQL queries
that are executed in web requests. The current threshold is hardcoded to
100 as we will rarely (maybe once or twice) change it.
In production and development we use Sentry if enabled, in the test
environment we raise an error. This feature is also only enabled in
production/staging when running on GitLab.com as it's not very useful to
other users.
Fixes project visibility guidelines
See merge request gitlab/gitlabhq!2226
(cherry picked from commit 877c42c0aaf3298d6001614c9706bc366ae4014c)
e4fd1c26 Ensure project wiki visibility guidelines are met
* new merge request can be created by sending an email to the specific
email address (similar to creating issues by email)
* for the first iteration, source branch must be specified in the mail
subject, other merge request parameters can not be set yet
* user should enable "Receive notifications about your own activity" in
user settings to receive a notification about created merge request
Part of #32878
Imre Farkas
Stan Hu
Andreas Brandl
Małgorzata Ksionek
Rubén Dávila
Dmitriy Zaporozhets
Tiago Botelho
Cindy Pallares
George Tsiolis
Tuomo Ala-Vannesluoma
gfyoung
James Lopez
Yorick Peterse
James Lopez
Winnie Hellmann
Mike Greiling
James Ramsay
Lin Jen-Shin
Aram Visser
Hiroyuki Sato
blackst0ne
Tomasz Maczukin
Robert Speicher
Eric Eastwood
Phil Hughes
Oswaldo Ferreira
Sean McGivern
Rémy Coutable
Mario de la Ossa
Takuya Noguchi
🙈 jacopo beschi 🙉
Jacob Vosmaer
Douwe Maan
Jan Provaznik