Commit Graph

83 Commits

Author SHA1 Message Date
Fernando Arias a536fe2850 Code cleanup of headerActions and tests
* Remove headerAction getter from job getters
* Remove prop from being passed into header_ci_component
* Remove no longer needed tests
2019-01-11 11:14:53 -05:00
Fernando Arias f3465c7293 Update failing specs & linter errors & changelog 2019-01-10 10:36:27 -05:00
Fernando Arias 42bfffc495 Move job cancel/new button
* Move cancel button to where the Retry is normally placed
* Move new issue button to be in sidebar view for desktop versions
* Update specs

Add changelog entry for moving cancel btn

Remove mobile version job action buttons

* Remove buttons showing up on seperate row on job sidebar
* Show Retry button in mobile version next to build name

Improve flexbox usage for job action buttons

* Allow for cleaner scaling of job name and alignment of buttons

Adjust the debug button icon size

* Adjust debug icon size on the build sidebar so the debug button is the
same height as the other buttons

Tweak job name vertical margins

* Changes are only made to job side vue
* Remove old class that only changed margin on top
* Adjust veritcal margin uniformy set to 0 via bootstrap margin class

Update Karma tests for job side view

* Update karms tests for mobile version of side view
* Removed tests for new issue button since we are fixing in
https://gitlab.com/gitlab-org/gitlab-ce/issues/55944

Fix rspec and static-analysis failures

* Run Prettier
* Update rspec css selectors

Move job action buttons to new line

* Move "New Issue" and "Debug" buttons to seperate line in job sidebar
* Update specs

Run Prettier to format JS

Remove New Issue button from job header

Make sure button spacing follows styleguide
2019-01-10 09:04:17 -05:00
Nathan Friend 7798a4a62a
Fix style issues in job details sidebar
This commit fixes a number of minor style issues in the job details
sidebar - spacing, font weights, button sizes, and font sizes.

More details here:
https://gitlab.com/gitlab-org/gitlab-ce/issues/54814
2018-12-19 15:16:10 -04:00
jhampton 6de31cddb8 Merge remote-tracking branch 'origin/master' into 20422-hide-ui-variables-by-default 2018-12-07 13:21:43 -05:00
jhampton 02ef052363 Prettifies 2018-12-07 13:15:58 -05:00
jhampton 43286857d5 Fixes linting errors 2018-12-07 11:47:12 -05:00
jhampton c2f72ad8a2 Adds toggle behavior
- Adds coverage for hide/reveal toggle button behavior
2018-12-07 10:19:41 -05:00
Filipa Lacerda eb7c16dee4
Adds bottom margin to the environment info block 2018-11-28 12:06:42 +00:00
Filipa Lacerda f2479e1987
Prevents empty button in jobs empty state
Returns `null` instead of an empty object to make
sure Vue doesn't render the button
2018-11-14 11:38:53 -05:00
Constance Okoghenun baa37edd93 Resolve "Issue board card design" 2018-11-07 17:20:17 +00:00
Filipa Lacerda b1fae097bd Merge branch 'winh-delayed-jobs-dynamic-timer' into 'master'
Add dynamic timer to delayed jobs

See merge request gitlab-org/gitlab-ce!22382
2018-11-07 10:27:54 +00:00
Winnie Hellmann b678e07e99 Run yarn prettier-all-save 2018-11-07 10:00:25 +01:00
Winnie Hellmann 997d70eaf9 Add dynamic timer for delayed jobs in job sidebar 2018-11-07 10:00:25 +01:00
Winnie Hellmann ff72bba12c Add dynamic timer for delayed jobs on single job page 2018-11-07 10:00:25 +01:00
Winnie Hellmann 74f22d26a9 Add Vue mixin for delayed job timers 2018-11-07 10:00:25 +01:00
Filipa Lacerda 00c7d78d49
[ci skip] Renders a warning block for archieved job
When the job is archieved we render a affixed warning
on the top of the job log
2018-11-05 17:16:29 +00:00
Achilleas Pipinellis 7f47e13218 Merge branch 'gt-update-typos-in-comments-and-specs' into 'master'
Fix typos in comments and specs

See merge request gitlab-org/gitlab-ce!22683
2018-11-01 10:34:23 +00:00
George Tsiolis 733ae94921 Fix typos in comments and specs 2018-11-01 08:59:20 +02:00
Mike Greiling 160157a92b
Prettify remaining files with differences in CE and EE 2018-10-31 14:33:12 -05:00
Filipa Lacerda 1cc093011f Fix stage dropdown rendering only in English 2018-10-26 07:49:01 +00:00
Steve Azzopardi 50f703f95a Move job stuck status to backend 2018-10-25 11:53:00 +00:00
Winnie Hellmann 60405bd373 Extract JobContainerItem component 2018-10-22 17:43:43 +00:00
Mike Greiling 7a3e605350
Resolve eslint violations 2018-10-17 11:18:17 -05:00
Mike Greiling f666026d71
Prettify all spec files 2018-10-17 11:18:17 -05:00
Filipa Lacerda 5ed91cf81b Resolve "Integrate new vue+vuex code base with new API and remove old haml code" 2018-10-17 10:34:19 +00:00
Johann Hubert Sonntagbauer 6f5723a169 enable jasmine/new-line-before-expect 2018-10-17 06:57:29 +02:00
Tim Zallmann 1103f589f0 Merge branch '52614-update-job-started-check' into 'master'
Updates the check for started in job header

See merge request gitlab-org/gitlab-ce!22329
2018-10-12 17:16:47 +00:00
Steve Azzopardi 464655edb2 Add stage name in job.json response 2018-10-12 17:13:41 +00:00
Filipa Lacerda 85c30d742c Updates the check for started in job header
The function that was checking if the job was started or not
was expecting a boolean, however it was receiving a null.
During the refactor the condition was changed, causing the function
to break with null

This commit fixes the check
2018-10-12 16:26:04 +01:00
Mike Greiling db85dbbf5e Merge branch '51712-new-line-between-declarations' into 'master'
1. enable jasmine/new-line-between-declarations

See merge request gitlab-org/gitlab-ce!22230
2018-10-11 18:35:53 +00:00
Filipa Lacerda dd0806d095 Fix erased block not being rendered when job was erased 2018-10-11 18:33:02 +00:00
Tim Zallmann a8513c7dc3 Merge branch '52472-pipeline-endpoint-json' into 'master'
Adds `.json` to the end of pipelines endpoint

Closes #52472

See merge request gitlab-org/gitlab-ce!22293
2018-10-11 15:18:44 +00:00
Filipa Lacerda e63cbf4ece Stuck block URL links to runners settings 2018-10-11 15:14:40 +00:00
Filipa Lacerda 0073be9bf7 Adds `.json` to the end of pipelines endpoint
When the job page is rendered we fetch the pipeline
endpoint to render the stages in the sidebar.
Without `.json` the response is cached, and when the
user goes back to the pipeline's page it renders the
json output instead of the Vue app
2018-10-11 14:29:35 +01:00
Johann Hubert Sonntagbauer 2a76e04091 enable jasmine/new-line-between-declarations 2018-10-09 19:01:49 +02:00
Filipa Lacerda e13baff004 Renders empty states in the Vue app in Job page 2018-10-04 12:59:57 +00:00
Filipa Lacerda 81bff65fa8 Adds MR reference in job sidebar
In the refactor the `!` reference was missed
This commit adds it back and adds coverage for it.
2018-10-04 09:27:56 +01:00
Filipa Lacerda 9128e7849d Uses Vue app to render part of job show page 2018-10-03 15:29:07 +00:00
Filipa Lacerda f72a1bf09c Moves stages dropdown into the new vue app 2018-10-03 14:13:20 +00:00
Phil Hughes 1eefdf5da5 Merge branch '50904-use-vuex-store-job' into 'master'
Uses new Vuex store in job log page

See merge request gitlab-org/gitlab-ce!21961
2018-09-27 14:50:23 +00:00
Filipa Lacerda 49bd01cf24 Uses new Vuex store in job log page
Removes old mediator and service pattern and uses the new store.
Middle step before moving everything into one single vue app
2018-09-27 14:13:17 +01:00
Filipa Lacerda 90e0709dfb Updates Vue job components to match new API 2018-09-27 11:08:31 +00:00
Filipa Lacerda 32ccde8ccd Use Vue component for job artifacts, Commit and Trigger Variables 2018-09-25 08:07:47 +00:00
🌴🌴 Filipa Lacerda - OOO back on September 17th 🌴🌴 55582b4359 Adds Vuex store for the job log page 2018-09-03 07:49:52 +00:00
Filipa Lacerda ecfdbee6cf Creates vue component for environments block 2018-08-28 07:53:48 +00:00
Filipa Lacerda e8197c7fe7
Moves job log spec files to the components folder 2018-08-20 09:53:43 +01:00
Filipa Lacerda da9b3b3d0f Creates vue components for stage dropdowns and job list container for job log view 2018-08-17 10:52:46 +01:00
Phil Hughes 7abab12e65 Merge branch '50101-commit-block' into 'master'
Creates Vue component for commit block in job log view

See merge request gitlab-org/gitlab-ce!21249
2018-08-17 07:54:38 +00:00
Phil Hughes 7548cdc318 Merge branch '50101-trigger' into 'master'
Creates Vue component for trigger variables block in job log page

See merge request gitlab-org/gitlab-ce!21244
2018-08-17 07:48:28 +00:00