Commit Graph

68 Commits

Author SHA1 Message Date
Phil Hughes fa2af5e0f5
Flash is now a ES6 module
Reduced the technical debt around our JS flash function by making it a
module that is imported rather than relying on the global function.
The global function still exists mainly for technical debt with how
some requests are being completed, but new JS should import the module
directly.

Also reduces some tech debt in the file by removing the need for jQuery.
Instead Flash is now 100% vanilla JS.
2017-10-10 10:14:22 +01:00
Fatih Acet 3446262169 Merge branch 'emoji-dom-size' into 'master'
Improve emoji menu rendering performance

Closes #36949

See merge request gitlab-org/gitlab-ce!14233
2017-09-22 09:49:00 +00:00
Bryce Johnson 014bbe6562 Remove eslint-disable, and use arrow function. 2017-09-20 15:17:08 -04:00
Bryce Johnson 8349782f7f Reverse order in showMenuElement for readability. 2017-09-20 15:11:36 -04:00
Bryce Johnson 8990410ec8 Remove emoji-menu from the render tree when hidden. 2017-09-19 19:56:59 -04:00
Filipa Lacerda 6a1b84c7b4 Use modules in common utils 2017-09-09 09:54:24 +01:00
Fatih Acet 48acfb5c05 IssueNotesRefactor: Show Cmd+Enter to comment tooltip. 2017-08-21 21:48:09 +03:00
Fatih Acet a75de77e10 IssueNotesRefactor: Fix award handler. 2017-08-18 19:02:00 +03:00
Fatih Acet 200cc4f167 IssueNotesRefactor: Stop making request for disabled emojis. 2017-08-18 03:18:10 +03:00
Filipa Lacerda e4f8aa719b Merge branch 'master' into issue-discussions-refactor
* master: (162 commits)
  Since mysql is not a priority anymore, test it less
  Add container registry and spam logs icons
  Fix different Markdown styles
  Backport to CE for:
  Make new dropdown dividers full width
  Bump GITLAB_SHELL_VERSION and GITALY_VERSION to support unhiding refs
  Install yarn via apt in update guides
  Use long curl options
  Remove monkey-patched Array.prototype.first() and last() methods
  Openshift Getting Started
  35659 Rename Pipelines tab to CI / CD in new navigation
  Don't bother going through an entire Banzai pipeline for empty text
  Add active state for pipelines settings on old nav
  Bump rspec to 3.6.0
  Resolve "Specific Async Script Loading by using a Page Variable"
  Revert "Merge branch 'rs-warm-capybara-only-in-ci' into 'master'"
  another rubocop style fix
  Use mixin for new dropdown style
  Migrate Repository#last_commit_for_path to Gitaly
  Migrate blame loading to Gitaly
  ...
2017-08-04 19:38:37 +01:00
Tim Zallmann dab08be606 Resolve "Specific Async Script Loading by using a Page Variable" 2017-08-03 20:31:53 +00:00
Filipa Lacerda 7a98970bd8 [ci skip] Removes Vue from awards handler code 2017-08-01 18:23:59 +01:00
Filipa Lacerda 9ff88aa283 [ci skip] Uses jquery to get correct note in awards 2017-07-29 23:42:30 +01:00
Fatih Acet 3d4d9c5ab9 IssueNotesRefactor: Fix adding main note awards. 2017-07-21 22:35:25 +03:00
Fatih Acet a32f291a9e IssueNotesRefactor: Separate mounted blocks to methods. 2017-07-21 22:35:25 +03:00
Fatih Acet 7edc1bc3a6 IssueNotesRefactor: Implement awarding emoji from emoji dropdown. 2017-07-21 22:35:25 +03:00
Mike Greiling f26d477865 dynamically import emoji helpers for AwardsHandler class 2017-06-28 13:04:34 -05:00
Mike Greiling 88e12ac94b revert removal of requestAnimationFrame and move to a separate MR/discussion 2017-06-27 08:51:52 -05:00
Mike Greiling a2a276a815 rename getEmojiCategoryMap and remove unnecessary parameter 2017-06-27 08:51:52 -05:00
Mike Greiling 9d6bbc92c9 move glEmojiTag method to emoji helper 2017-06-27 00:54:34 -05:00
Mike Greiling 82d67f700e namespace emoji helper methods within AwardsHandler class 2017-06-26 16:03:36 -05:00
Mike Greiling 8455e8c481 move emoji category index to helper method 2017-06-26 14:10:02 -05:00
Mike Greiling 73c5c00133 move emojiAlias logic into helper module 2017-06-26 14:10:02 -05:00
Mike Greiling a7b603a2ac fix method definition styling 2017-06-26 14:10:01 -05:00
Mike Greiling b7a0044a70 move normalizeEmojiName method to emoji helper module 2017-06-26 14:10:01 -05:00
Mike Greiling 35ee21d992 remove problematic use of requestAnimationFrame 2017-06-26 14:10:01 -05:00
Mike Greiling d099744dd4 centralize emoji helper methods 2017-06-23 14:23:20 -05:00
Mike Greiling 3b4c07ac5f refactor AwardsHandler into es class syntax 2017-06-17 22:28:37 -05:00
Kushal Pandya d586b6cced Add ES lint support to identify poorly written Promises 2017-04-20 11:11:51 +00:00
Alfredo Sumaran eeaeb2752a Merge branch '27655-clear-emoji-search-after-selection' into 'master'
Clear emoji search in awards menu after picking emoji

Closes #27655

See merge request !10524
2017-04-17 05:35:34 +00:00
barthc 04e2dde538 frontend prevent authored votes 2017-04-14 09:33:28 +01:00
Eric Eastwood 0370c7c838 Clear emoji search in awards menu after picking emoji
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/27655
2017-04-13 02:22:57 -05:00
Eric Eastwood 4bf6ffa51a Remove `undefined` class from `.emoji-menu-list`
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/30496
2017-04-07 00:07:39 -05:00
Dimitrie Hoekstra 80c9264967 Award emoji button smiley animation 2017-04-06 13:38:09 +00:00
Phil Hughes ab79c76d0c Removes the duplicated search icon in emoji menu
The search emojis title had the same class as the search input which
caused a duplicated icon.

Closes #30416
2017-04-05 10:56:40 +01:00
Mike Greiling 5f7c0bd7b7 remove Cookies class from global space 2017-03-22 03:07:27 -05:00
Eric Eastwood a8a52a587d Protect against unknown emojis in frequently used list
See https://gitlab.slack.com/archives/frontend/p1489690607738864
2017-03-16 17:22:21 -05:00
Eric Eastwood 3f5919e2c4 Add frequently used emojis back to awards menu
Thanks @filipa for the shout`
2017-03-09 13:00:46 -06:00
Eric Eastwood ee9930145f Update emojis to use harmony modules (import/export) 2017-03-08 11:27:14 -06:00
Eric Eastwood 2d6492561c Fix up potential for build finish event to fire for wrong menu 2017-03-06 12:54:46 -06:00
Eric Eastwood a8140d5c01 Fix up `watch` alias lookup in Firefox
It was pulling
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/watch
2017-03-06 12:54:46 -06:00
Eric Eastwood e6fc0207cb Use native unicode emojis
- gl_emoji for falling back to image/css-sprite when the browser
   doesn't support an emoji
 - Markdown rendering (Banzai filter)
 - Autocomplete
 - Award emoji menu
    - Perceived perf
    - Immediate response because we now build client-side
 - Update `digests.json` generation in gemojione rake task to be more
   useful and  include `unicodeVersion`

MR: !9437

See issues

 - #26371
 - #27250
 - #22474
2017-03-06 12:54:46 -06:00
Mike Greiling 0f31c5a92b replace implicit this == window with explicit binding 2017-02-17 16:58:32 -06:00
Mike Greiling 69e4072f89 Merge branch 'master' into go-go-gadget-webpack
* master: (389 commits)
  Document "No gems fetched from git repositories" policy [ci skip]
  Typos
  Small gramatical tweaks
  Typos
  Added PHP & NPM doc
  Use `:empty_project` where possible in request specs
  Add caching of droplab ajax requests
  Use `:empty_project` where possible in model specs
  Revert 3f17f29a
  Remove unused js response from refs controller
  Add MR id to changelog entry
  fixed small mini pipeline graph line glitch
  Prevent form to be submitted twice
  Fix Error 500 when repositories contain annotated tags pointing to blobs
  Fix /explore sorting (trending)
  Simplify wording in "adding an image" docs
  Remove "official merge window" from CONTRIBUTING.md [ci skip]
  Update repository check documentation
  Fixed flexbox and wrap issues
  Update two_factor_authentication.md
  ...
2017-01-27 19:33:58 -06:00
Mike Greiling 588d7e8ae0 resolve all parseInt radix eslint violations 2017-01-18 17:18:40 -06:00
Mike Greiling 04eff5fdb0 resolve all x-spacing and no-spaced-x eslint violations 2017-01-18 17:18:40 -06:00
Mike Greiling ccada28f30 resolve all padded-blocks eslint violations 2017-01-18 17:16:41 -06:00
Mike Greiling 9e4d04913a resolve all no-plusplus eslint violations 2017-01-18 17:15:27 -06:00
Mike Greiling fe964cc235 migrate all javascript asset bundles and require syntax 2017-01-10 12:30:38 -06:00
Mike Greiling 8e0e902b13 resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00