Commit Graph

45 Commits

Author SHA1 Message Date
Tim Zallmann b2dbc93694 Reducing the memory footprint for the rendering 2018-07-23 11:24:07 +00:00
André Luís f2f8ddf4cc Resolve ""Jump to first/next unresolved discussion" jumps to resolved discussions" 2018-07-20 15:24:46 +00:00
Tim Zallmann 6c6988cb5e Merge branch '_acet-fix-expanding-context-lines' into 'master'
Fix rendering context lines on MR diffs

Closes #49242 and #49343

See merge request gitlab-org/gitlab-ce!20642
2018-07-18 16:08:09 +00:00
Tim Zallmann 5ba542b109 Merge branch '_acet-fix-mr-autosave' into 'master'
Fix autosave issues for MR discussions

Closes #48876 and #48877

See merge request gitlab-org/gitlab-ce!20569
2018-07-18 15:12:31 +00:00
Fatih Acet 3dd556f2d6
i18n changes for note cancel confirmations. 2018-07-18 12:55:57 +02:00
Fatih Acet c12ad01693
Fix failing specs :fingers-crossed: 2018-07-18 12:55:56 +02:00
Fatih Acet 9cd5ca2f57
Fix autosave in noteable discussion. 2018-07-18 12:55:56 +02:00
Fatih Acet 5be711ab6e
Add confirmation modal before cancelling the comment form in diff line note form. 2018-07-18 12:55:55 +02:00
Fatih Acet e868d09dbf
Use built-in autosave mixin in diff line note form. 2018-07-18 12:55:55 +02:00
Fatih Acet 7632330e50
Fix showing outdated discussions on Changes tab 2018-07-18 00:07:37 +02:00
Fatih Acet 1cf56fe108
Remove v-once from diff lines components. 2018-07-17 23:55:45 +02:00
Tim Zallmann 422dcfde03 Resolve "MR: Reduce the memory footprint of the component tree" 2018-07-17 15:47:02 +00:00
Filipa Lacerda 289530a084 Resolve "Improve performance of MR Changes tab: reduce event listeners on scroll event" 2018-07-12 12:42:56 +00:00
Filipa Lacerda c5a514de76
Adds specs for toggleFileDiscussions action 2018-07-11 15:30:41 +01:00
Filipa Lacerda 57c32c7dbd
Adds specs for getters in merge request vuex diff module 2018-07-11 12:48:24 +01:00
Filipa Lacerda 135ead1d83
Merge branch 'master' into 48237-toggle-file-comments
* master: (38 commits)
  Update bitbucket.md to fix typo and small grammar touchups.
  Update time_helper.rb to fix output for exact minutes.
  Document update for GitLab Pages users.
  Support manually stopping any environment from the UI
  Fix link to frontend in handbook
  Shorten CHANGELOG filename to avoid breaking ecryptfs users
  Replace 48976-rails5-invalid-single-table-inheritance-type-group-is-not-a-subclass-of-gitlab-backgroundmigration-fixcrossprojectlabellinks-namespace.yml
  Fix mountComponent helper path in docs
  Fix #48537 - Update avatar only via the projects API
  Add additional headline for Adding SSH keys to GitLab
  Request to be a proofreader.
  Fix specs
  Fix search bar text input alignment
  Fix API docs on unauthenticated projects return
  Adds with_projects optional parameter to /groups/:id API endpoint
  Docs: make it clear that you need a completely separate domain for Pages
  Document that we don't want to wait in tests
  Removes unused store in diffs mr refactor Removes double export for actions in diffs module in mr refactor
  Remove useless return
  Use latest gitlab-styles
  ...
2018-07-10 18:11:19 +01:00
Filipa Lacerda ac71675d30
Fixes toggle discussion button not expanding collapsed discussions
Discussions were being toggled by jquery DOM querying them and toggling
visibility but in vue, only the open discussions will be in the DOM
Fix includes:
 - Adds a getter to the store to get the expanded discussions
 - Adds an action to collapse a discussion
 - When the user clicks the button, all data needed is now accessible
   through a getter and we can dispatch an action to toggle the discussion
   within the state, instead of showing/hiding with jQuery
 - Removes hardcoded properties

Resolves #48237
2018-07-10 12:03:00 +01:00
Phil Hughes ca1deb9e5e Merge branch '48951-clean-up' into 'master'
Resolve "MR refactor: All actions under diff module are being exported twice"

Closes #48951

See merge request gitlab-org/gitlab-ce!20499
2018-07-10 07:38:48 +00:00
Filipa Lacerda cb6bc902ed
Removes hardcoded and unused prop 2018-07-09 16:13:10 +01:00
Filipa Lacerda 8186bb3903
Removes unused store in diffs mr refactor
Removes double export for actions in diffs module in mr refactor
2018-07-09 15:46:36 +01:00
Filipa Lacerda 1070558d55
Merge branch 'master' into 48960-namespace-diff-module
* master:
  Resolve "MR refactor: Performance costs of main element with `v-if`"
  Add documentation on private projects
  Make blob and other RPC's mandatory
  Removed return statements from prettier script
  Add missing strings to `locale/gitlab.pot`
  Update `gettext:updated_check` regenerate pot file
  Include wget in apk add command
  [Rails5] Fix 'Invalid single-table inheritance type: Group is not a subclass of Gitlab::BackgroundMigration::FixCrossProjectLabelLinks::Namespace'
  Updated color
  Update doc on new option to add README when creating a project
  Make more things mandatory
  Updated (color of indent guide in Web IDE
  Make all Gitaly diff flags mandatory
2018-07-09 13:15:29 +01:00
Tim Zallmann 9eef6cd1bf Resolve "MR refactor: Performance costs of main element with `v-if`" 2018-07-09 11:54:15 +00:00
Filipa Lacerda 81b9b6f409
Merge branch 'master' into 48960-namespace-diff-module
* master: (29 commits)
  Update the dependencies license list for 11.1.0
  Update .gitignore, .gitlab-ci.yml, and Dockerfile templates for 11.1.0
  This updates only the actual new discussion and not the full tree , which leads to a very costly full rerender
  Resolve "MR Refactor: Improve performance by setting v-once"
  Changed Inline + Parallel Views to v-if instead of v-show
  add basic export to fix timeout problem on import_file_spec.rb
  Add changelog entry for !20465
  Improve render performance of large wiki pages
  Refactor rspec matchers in read_only_spec.rb
  add CHANGELOG.md entry for !20461
  resolve node 6 compatibility issues
  Add missing foreign key in import_export_uploads
  Redesign for mr widget info and pipelines section
  Use proper markdown rendering for previews
  remove extra tick for eks docs
  Make it clear that we need to enable omniauth for SAML and Bitbucket
  Add GPL Commitment language
  Add ExclusiveLease guards for RepositoryCheck::{DispatchWorker,BatchWorker}
  Ability to check if underlying database is read only
  fix spec
  ...
2018-07-09 10:21:18 +01:00
Fatih Acet dc71b4004b Merge branch '48906-adding-a-diff-line-note-freezes-the-browser' into 'master'
Resolve "Adding a diff line note freezes the browser"

Closes #48906

See merge request gitlab-org/gitlab-ce!20476
2018-07-09 08:39:32 +00:00
Tim Zallmann e5b7fa6baf This updates only the actual new discussion and not the full tree , which leads to a very costly full rerender 2018-07-09 09:38:16 +02:00
Tim Zallmann 56cbff350c Resolve "MR Refactor: Improve performance by setting v-once" 2018-07-08 23:17:56 +00:00
Tim Zallmann 5c6d653be1 Changed Inline + Parallel Views to v-if instead of v-show 2018-07-07 20:54:13 +02:00
Filipa Lacerda 156a9d3913
Transforms diffs module to a namespaced one to avoid console error due to rewire export.
Detailed: Because of rewire we need to export a default empty object in our actions to prevent it to export the wrong default in karma. Vuex getters are global, and because the Vuex store uses several non namespaced moduled, there was already a getter named default, due to the same empty export.
In order to solve it I chose to namespace the module. Could also be fixed by importing the getters explicitly instead of all of them.
2018-07-06 17:26:18 +01:00
Filipa Lacerda adb7f45aff
Exports getters individually.
Exports state to allow tests
Adds specs for the getters that didn't have any.
2018-07-06 13:21:02 +01:00
Filipa Lacerda 49828db524 Improves performance on MR refactor and adds specs 2018-07-05 12:05:57 +00:00
Tim Zallmann 6d291cc3a6 File Icons in Merge Requests 2018-07-05 12:02:56 +00:00
Fatih Acet 98aeab2848
Fix parallel diff lines content. 2018-07-04 01:34:43 +02:00
Fatih Acet 483864db77 Improve performance of toggling diff view type 2018-07-03 23:18:27 +00:00
Tim Zallmann fb44cb3d90 Performance Improvements to Vue MR page 2018-06-30 13:17:46 +00:00
Tim Zallmann 9ecb06ae2a Resolve "Merge request collapse icon is tiny" 2018-06-29 21:27:58 +00:00
André Luís 28170488e5 Resolve "Merge request refactor: Title and copy to clipboard button are behind the action buttons" 2018-06-29 18:41:34 +00:00
Constance Okoghenun 60379c7c98 Resolve "Merge request refactor displays changes dropdown incorrectly" 2018-06-29 14:27:27 +00:00
Fatih Acet d690cd9992 Prevent fetching diffs and discussions data unnecessarily on MR page 2018-06-29 07:22:07 +00:00
Fatih Acet fbf747194f Componentize diff lines and diff comments 2018-06-27 21:20:41 +00:00
Tim Zallmann 292cf66890 Merge branch 'acet-mr-diffs-autosave' into 'master'
Implement MR diff notes autosave feature

Closes #48300

See merge request gitlab-org/gitlab-ce!20114
2018-06-26 21:25:46 +00:00
Tim Zallmann 53f77cfee1 Added Diff Viewer to new VUE based MR page 2018-06-26 18:49:22 +00:00
Fatih Acet c622252bd8
Use refs instead of querySelector. 2018-06-26 17:54:35 +02:00
gfyoung 23cdae8eee Enable "prefer-destructuring" in JS files
Partially addresses #47006.
2018-06-25 11:53:57 -07:00
Fatih Acet 4e734a9004
Implement MR diff notes autosave feature. 2018-06-22 22:16:46 +02:00
Felipe Artur 3e66795ef1 Changes tab VUE refactoring 2018-06-21 12:22:40 +00:00