Commit Graph

144 Commits

Author SHA1 Message Date
Z.J. van de Weg 93b555af85 Handle legacy jobs without name
Older pipelines can contain jobs without a name, in which case
'nameless' is used right now, so we can properly still handle other
actions on these jobs.

Fixes gitlab-org/gitlab-ce#33403
2017-06-13 11:19:45 +02:00
Douwe Maan 6bea29649e Merge branch 'fix/import-commit-status-issue' into 'master'
Ignore commit status name validation on importing

Closes #33490

See merge request !12039
2017-06-12 15:38:09 +00:00
Filipa Lacerda 452202e36d Improve Job detail view to make it refreshed in real-time instead of reloading 2017-06-12 09:20:19 +00:00
James Lopez eaf71fc963 ignore name validation on importing 2017-06-12 10:11:08 +02:00
Grzegorz Bizon 79380fe5fb Merge branch 'master' into feature/gb/persist-pipeline-stages
* master: (524 commits)
  Improve user experience around slash commands in instant comments
  Fix LFS timeouts when trying to save large files
  retryable? is now available for CommitStatus
  Resolve "Documentation of `.gitlab-ci.yml` states incorrect example for variables"
  Fix test failures
  Add slugify project path to CI enviroment variables
  Fixed typo: craeted -> created
  32118 Make New environment empty state btn lowercase
  Expose import_status in Projects API
  32832 Remove overflow from comment form for confidential issues and vertically aligns confidential issue icon
  Fix test failures
  Allow manual bypass of auto_sign_in_with_provider
  Fix keys seed
  Allow users to be hard-deleted from the API
  fixup some classnames and media queries
  Enable the Style/PreferredHashMethods cop
  Lint our factories creation in addition to their build
  Don’t schedule workers from inside transactions
  Allow scheduling from after_commit hooks
  Forbid Sidekiq scheduling in transactions
  ...

Conflicts:
	app/serializers/pipeline_entity.rb
	db/schema.rb
	spec/factories/ci/stages.rb
	spec/lib/gitlab/import_export/safe_model_attributes.yml
	spec/services/ci/create_pipeline_service_spec.rb
	spec/spec_helper.rb
2017-06-05 12:51:59 +02:00
Kamil Trzciński 9ccb289aa1 Merge branch 'zj-job-view-goes-real-time' into 'master'
Initial implementation for real time job view

Closes #31397

See merge request !11651
2017-06-05 10:24:57 +00:00
Z.J. van de Weg 1709e5cf87 retryable? is now available for CommitStatus 2017-06-04 12:44:00 +02:00
Douwe Maan e4eac1fff1 Don’t schedule workers from inside transactions 2017-06-02 11:43:32 -05:00
Grzegorz Bizon fe0b2f81c7 Refine implementation of pipeline stage seeds 2017-06-02 12:16:11 +02:00
Z.J. van de Weg 336635f283 Test the ExpireJobCacheWorker and related changes
These were untested by the cherry picked commit.
2017-05-22 22:07:11 +02:00
Kamil Trzcinski da0c543e28 Add MISSING e-tag refresh of resource for Job, and Pipeline Graph 2017-05-22 22:07:11 +02:00
Regis Boudinot 81df0034f4 Merge branch 'retried-in-database-mysql' into 'master'
Retried in database

Closes #25737

See merge request !11115
2017-05-10 22:07:05 +00:00
Kamil Trzcinski f09dcbd9bd
Make retried to be nullable 2017-05-09 20:09:41 +02:00
Kamil Trzcinski f2a4420d66
Store retried in database for CI builds 2017-05-07 22:43:53 +02:00
James Lopez 702b291f81 remove gl_project_id for I/E version update 2017-05-02 14:55:32 +02:00
Lin Jen-Shin 057c0d7a5c Also track auto-cancelling in jobs, detail:
Not only tracking auto-cancelling in pipelines,
we'll also track this in jobs because pipelines
could be retried and the information would get lost
when this happened. Also erase auto-cancelling
relation for pipelines when they're retried.
2017-04-06 21:32:56 +08:00
Kamil Trzcinski bb910c3b46
Make CI build to use optimistic locking only on status change 2017-03-28 17:50:28 +02:00
Kamil Trzciński 12dd5ac221 All CI offline migrations 2017-03-17 23:06:11 +00:00
Grzegorz Bizon c4d5b231ed Ignore optional actions when calculating warnings 2017-03-06 14:43:32 +01:00
Grzegorz Bizon 305064a639 Fix invalid description in commit status specs 2017-03-06 12:43:29 +01:00
Grzegorz Bizon ac5bd3b73c Reinstitute a core `manual` status for manual actions 2017-03-06 10:04:04 +01:00
Grzegorz Bizon dd24091191 Add support for blocking actions to CI/CD pipeline 2017-03-06 10:04:04 +01:00
Grzegorz Bizon 79ea01bfaf Refactor code related to pipeline blocking actions 2017-03-06 10:04:04 +01:00
Kamil Trzcinski be039d22d7 Make manual actions blocking 2017-03-06 10:04:04 +01:00
Douwe Maan 56de781a2c Revert "Enable Style/DotPosition"
This reverts commit e00fb2bdc2090e9cabeb1eb35a2672a882cc96e9.

# Conflicts:
#	.rubocop.yml
#	.rubocop_todo.yml
#	lib/gitlab/ci/config/entry/global.rb
#	lib/gitlab/ci/config/entry/jobs.rb
#	spec/lib/gitlab/ci/config/entry/factory_spec.rb
#	spec/lib/gitlab/ci/config/entry/global_spec.rb
#	spec/lib/gitlab/ci/config/entry/job_spec.rb
#	spec/lib/gitlab/ci/status/build/factory_spec.rb
#	spec/lib/gitlab/incoming_email_spec.rb
2017-02-23 09:33:19 -06:00
Douwe Maan 1fe7501b49 Revert "Prefer leading style for Style/DotPosition"
This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.
2017-02-23 09:33:05 -06:00
Douwe Maan b3ff48c9a1 Move up delegate calls 2017-02-23 09:32:42 -06:00
Douwe Maan 206953a430 Prefer leading style for Style/DotPosition 2017-02-23 09:32:22 -06:00
Douwe Maan 5cd9c7c6ea Enable Rails/Validation 2017-02-23 09:31:57 -06:00
Douwe Maan 3dadf306dd Enable Style/DotPosition 2017-02-23 09:31:56 -06:00
Grzegorz Bizon 346a7c696a Add after_stage scope to commit status class 2017-02-14 11:38:19 +01:00
Grzegorz Bizon ffcf3c6858 Skip job only when canceling the pipeline it belongs to 2017-02-13 15:11:21 +01:00
Grzegorz Bizon 008f22cd82 Fix pipeline specs related to canceling builds 2017-02-13 15:11:21 +01:00
Grzegorz Bizon a70a83cf29 Skip buils that were canceled but not started yet 2017-02-13 15:11:21 +01:00
Mike Greiling 1c5a506588 rename sort method 2017-01-02 11:44:08 -06:00
Mike Greiling 2eb0beb661 add natural sorting token for build names 2017-01-02 11:44:08 -06:00
Grzegorz Bizon 5f590a71fd Improve readability in methods for detailed status 2016-12-13 13:24:25 +01:00
Kamil Trzcinski 980009e6e8 Fix auto loading of constants for Ci Statuses 2016-12-12 12:59:01 +01:00
Kamil Trzcinski 633e64382d Added Ci::Status::Build 2016-12-12 12:59:01 +01:00
Kamil Trzcinski 260d754ca8 Fix handling of allowed to failure jobs 2016-12-06 14:13:21 +01:00
Kamil Trzcinski d865aedafc Introduce `Ci::Stage`, right now this is artificial object that is build dynamically. 2016-12-06 14:13:21 +01:00
Kamil Trzcinski 4e06818d33 Support pipelines API
Pass `updated_at` to get only incremental changes since last update
2016-12-06 14:13:21 +01:00
Lin Jen-Shin da9726170c Move has_trace? to CommitStatus than GenericCommitStatus
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7617#note_18762721
2016-11-22 13:36:19 +08:00
Kamil Trzcinski d8aed6a27b Fix optimistic locking 2016-10-26 11:37:23 +02:00
David Wagner 03b6108f6f Remove redundant class_name and foreign_key overrides
They were Rails' default and are unnecessarily overridden.

Signed-off-by: David Wagner <david@marvid.fr>
2016-10-24 22:29:48 +02:00
Grzegorz Bizon 2e3bc85421 Do not return from proc-closure in pipeline transition 2016-10-12 15:21:11 +02:00
Grzegorz Bizon 419518df67 Merge branch 'master' into feature/improve-mrwbs-and-todos-for-pipelines
* master: (221 commits)
  Add CHANGELOG entry for 8.12.6
  Added 'Download' button to snippet view
  Merge branch 'api-fix-project-group-sharing' into 'security'
  Add 8.12.5, 8.11.9, and 8.10.12 CHANGELOG entries
  FIx JS bug with select2 because of missing `data-field` attribute in select box.
  Remove pointless `.vagrant_enabled` file
  allow multiple labels commands
  Move some CHANGELOG entries to the 8.13.0 part
  Move operations/ to new location
  Move health check docs under user/admin_area/monitoring
  Make guests unable to view MRs
  Add examples of fake tokens to be used in docs
  Remove duplicate CHANGELOG entry
  Allow browsing branches that end with '.atom'
  Refactor the SubGit/SVN documentation
  Document the new CI_DEBUG_TRACE variable
  Remove redundant images
  changed the scss for the top line connectors to be exactly centered
  Rearrange GitLab basics READMEs
  New images for GitLab basics "Create MR" docs
  ...

Conflicts:
  app/models/commit_status.rb
2016-10-12 11:52:54 +02:00
Grzegorz Bizon 904de2d64b Check for transition loopback in commit status 2016-10-08 20:42:09 +02:00
Grzegorz Bizon 3fb4d86c6d Add temporary fix for race condition in MWBS 2016-10-08 20:34:45 +02:00
Grzegorz Bizon 74fd5cab15 Improve transitions and run hooks after transaction 2016-10-08 20:25:16 +02:00