Commit Graph

30 Commits

Author SHA1 Message Date
Thong Kuah f0391c2517 Add frozen_string_literal to spec/support
Using the sed script from
https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-07-25 17:33:34 +12:00
Sean McGivern b94daa35a4 Merge branch 'master' into michel.engelen/gitlab-ce-issue/55953 2019-07-03 10:28:13 +01:00
Natalia Tepluhina d4151b14c2 Rebased and squashed commits
- all commits squashed to make danger review happy
2019-07-03 08:26:57 +00:00
Michel Engelen ad5bd4ad4f updated tests to comply with the corresponding EE branch 2019-07-02 14:30:19 +02:00
Michel Engelen 6906755213 updated tests for !29553 2019-07-02 14:29:15 +02:00
Heinrich Lee Yu 96ed5a8bd7 Upgrade to Capybara 3
Fix whitespace in specs because normalize_ws is slightly
different from Capybara 2 behavior
2019-06-12 18:40:18 +08:00
Michael Kozono 8fc2347fa9
Quarantine flaky test 2019-04-09 11:04:26 -07:00
Thong Kuah 4ec16912b8 Autocorrect with RSpec/ExampleWording cop
- rewords examples starting with 'should'
- rewords examples starting with 'it'

Note: I had to manually fixup "onlies" to "only"
2019-04-05 08:43:27 +00:00
Winnie Hellmann a2e9ad83f4 Display reply field if resolved discussion has no replies 2018-12-14 11:49:53 +00:00
Winnie Hellmann 1cae0af4b8 Fix collapsing discussion replies 2018-12-04 10:09:51 +00:00
Fatih Acet cd5ddc4f2e Discussions redesign 2018-11-08 07:58:45 +00:00
Jan Provaznik 65664c2eae Refactor discussions/notes code 2018-04-03 16:03:00 +00:00
Nick Thomas 93ea3234df
Use the DatabaseCleaner 'deletion' strategy instead of 'truncation' 2018-01-24 17:25:55 +00:00
🙈 jacopo beschi 🙉 729f05f0e3 Adds Rubocop rule for line break around conditionals 2018-01-11 16:34:01 +00:00
Annabel Dunstone Gray a2e2b11cf5
Fix merge_request_spec 2017-11-07 10:27:20 -07:00
Mike Greiling 519ffa1ebf
Merge branch 'master' into sh-headless-chrome-support
* master: (297 commits)
  Fix deletion of container registry or images returning an error
  The fog-aliyun gem had a bug in v0.1.0 for file storage creation/update. This merge requests update the gem to v0.2.0 which contains the fix:
  Decrease ABC threshold to 54.28
  Update VERSION to 10.2.0-pre
  Update CHANGELOG.md for 10.1.0
  Document `CI_SHARED_ENVIRONMENT` and `CI_DISPOSABLE_ENVIRONMENT`
  Fix the external URLs generated for online view of HTML artifacts
  Use title as placeholder instead of issue title for reusability
  Fix failure in current_settings_spec.rb
  Clarify the difference between project_update and project_rename
  URI decode Page-Title header to preserve UTF-8 characters
  Update Gitaly version to v0.49.0
  Decrease Perceived Complexity threshold to 14
  Resolve "Remove help text regarding group issues on group issues page (and group merge requests page)"
  Force non diff resolved discussion to display when collapse toggled
  Added submodule support in multi-file editor
  add note about after_script being run separately
  Check for element before evaluate_script
  Merge branch 'master-i18n' into 'master'
  Update Prometheus gem to fix problems with other files overwriting current file
  ...
2017-10-23 10:32:14 +03:00
Clement Ho 04b616a60e Force non diff resolved discussion to display when collapse toggled 2017-10-20 10:40:26 +00:00
Mike Greiling c489b23708
fix shared discussion_comments examples (for realz this time!) 2017-10-13 13:48:48 -05:00
Jose Ivan Vargas e118e3cdaa fixed shared discussion_comments example 2017-10-10 15:57:21 -05:00
Mike Greiling 85b915c39b
fix click trigger method 2017-10-10 15:43:05 -05:00
Mike Greiling f783798825
Merge branch 'master' into sh-headless-chrome-support
* master: (113 commits)
  Introduce new hook data builders for Issue and MergeRequest
  Don't create todos for old issue assignees
  Start adding Gitlab::HookData::IssuableBuilder
  Include the changes in issuable webhook payloads
  Rename the `codeclimate` job to `codequality`
  Don't show an "Unsubscribe" link in snippet comment notifications
  Add QA::Scenario::Gitlab::Group::Create
  Removes CommitsList from global namespace
  Fix wiki empty page translation namespace not being removed
  Fixes mini graph in commit view
  Fix link to new i18n index page
  Update i18n docs
  Move i18n/introduction to i18n/index
  Resolve "Simple documentation update - backup to restore in restore section"
  Remove AjaxLoadingSpinner and CreateLabelDropdown from global namespace
  Move cycle analytics banner into a vue file
  Updated Icons + Fix for Collapsed Groups Angle
  Don't create fork networks for root projects that are deleted
  Remove executable permissions on images to make docs lint happy
  Sync up hard coded DN class in migration
  ...
2017-10-09 15:00:00 -05:00
Felipe Artur b54203f0ad Commenting on image diffs 2017-10-07 04:25:17 +00:00
Stan Hu 41e5ec8f74 Merge branch 'master' into sh-headless-chrome-support 2017-09-05 11:33:09 -07:00
Jarka Kadlecova b67e333ce8 fix static_analysis (rubocop) 2017-08-14 07:15:52 +02:00
Filipa Lacerda 60adf5a93a Update dropdown tests to match bootstrap one on issue page and droplab on other pages 2017-08-12 23:38:45 +01:00
Filipa Lacerda ab88fcf117 Uncomments tests 2017-08-12 00:14:45 +01:00
Fatih Acet 3c946b932b IssueNotesRefactor: Fix Rspec tests. 2017-07-21 22:35:26 +03:00
Stan Hu 5854ab2f7d Convert variants of trigger('click') -> click 2017-06-16 23:08:27 -07:00
Luke "Jared" Bennett 16e291b9c6 Resolve "start discussion toggle clicking divider causes UI break" 2017-04-19 21:18:39 +00:00
Luke "Jared" Bennett 159140010b
Separate examples for each other 2017-04-12 12:30:28 +01:00